Date:   Fri, 10 Mar 2023 12:17:13 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc:     Meadhbh Fitzpatrick <meadhbh.fitzpatrick@intel.com>,
        linux-crypto@vger.kernel.org,
        Damian Muszynski <damian.muszynski@intel.com>
Subject: Re: [PATCH] crypto: qat - change size of status variable
Message-ID: <ZAqvSeXLDG26E8+O@gondor.apana.org.au>
References: <20230309113306.4008-1-meadhbh.fitzpatrick@intel.com>
 <ZAm3cSjNderM7gzn@gondor.apana.org.au>
 <ZAm9MpyFnU1q2pmc@gcabiddu-mobl1.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZAm9MpyFnU1q2pmc@gcabiddu-mobl1.ger.corp.intel.com>
Precedence: bulk

On Thu, Mar 09, 2023 at 11:04:18AM +0000, Giovanni Cabiddu wrote:
>
> You are right. Thanks for spotting this.
> When reviewing it I mixed up the cmp_err and xlt_err with the status which
> is a u8.

In general s8/u8 should only be used when you are directly reading
or writing from hardware.  Once the value has entered your driver,
you should use int/unsigned int to deal with them.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt