From:   meenakshi.aggarwal@nxp.com
To:     V.sethi@nxp.com, pankaj.gupta@nxp.com, gaurav.jain@nxp.com,
        herbert@gondor.apana.org.au, davem@davemloft.net,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Subject: [PATCH] crypto: tls - Use data directly in completion function
Date:   Fri, 10 Mar 2023 15:59:12 +0530
Message-Id: <20230310102912.1966201-1-meenakshi.aggarwal@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KmnAr9VEgZ/LiJ53Ze98Gdh8oHGkNfJJtX71RpKCwM9jWJvnIbYKxq2v6UmL?=
 =?us-ascii?Q?cHzNRAXnWMT4rb2zBepk/6Z/8J/NTKEPrNUJvo22Btd/osuYcgilf7ndoxMw?=
 =?us-ascii?Q?jZX7/pEuVNwh/Hfy5l2NAl9g1BaDm6WZMWM3ceMtPAQzn3wNfE/V6V8FwxsO?=
 =?us-ascii?Q?y9ZU5uKYHKMZFYijwYgvbFetowmVZUHfAmmfBFDx6Q36AE8I1CXc4YFo7e26?=
 =?us-ascii?Q?yui2vDrTuaF8Q12hwUD+VlwK5tAMcBc/LiFgolu1d18giMkEKzcOEmrm652G?=
 =?us-ascii?Q?ojA4RGi6BWY449xlFNFdAyL/+eJdEyl5GhbRENhuAUS1dnskGJ+xoEcdi6fv?=
 =?us-ascii?Q?CY0PBNAcDK3z+32HJl2hYy3A2/RF8IgwKAE0Xdp9cIyWQPq1I/oV2OyU+bxw?=
 =?us-ascii?Q?tDqtvQ2/Jknwrd+Rigx4GWpxFvcBJRTbhtXrxeXMpnyqUcItPXpzhW3ckC8H?=
 =?us-ascii?Q?OmTExXX0yzYIylIRoeRXsujaLSTzQRVfy/VDJ22HJYQJORZGvR55D9ys/923?=
 =?us-ascii?Q?5YYiXr43If+va7UScxb5jIXQhX1/1W+uYF4HmiFWSBCU7X/haEgkIDbQGUSh?=
 =?us-ascii?Q?1TjfHnQ0uUe70k0uZ/gfRqcYy+TC5hKaXNBqmfGPYrDIM6uC8p0BeaCYnJfO?=
 =?us-ascii?Q?sl7Ur1WisEp5scRXA2zM8lG0MUokvlcbdD3KJ4KWNdjZRRZOO+864km4CdWV?=
 =?us-ascii?Q?glqEk1LxcWmifDBXc9f25IqSqbVRPWzZdVPf+517ekRWY4JmX8KDGo0D6kNX?=
 =?us-ascii?Q?klgeKMipbOGmDWIwQ8GuA5+H/pTzVaQwpLPekZOZ+RvxYZuMb1gLGbo6y3xJ?=
 =?us-ascii?Q?pxpdl+IG83b36xBTh7cEnR8axDLBUTupQlS9haMG0Br7mI3/8mM4gzIBNkcn?=
 =?us-ascii?Q?F6taAAWXssDKPr1A9ZNXNtPsNg/qhPlkCZaCUm1GJGGCa/FEuWFNg9fOxZ2Z?=
 =?us-ascii?Q?1P27KSu8gnDejO6LJbX3PxCfteKsxz+oJP7pdSKqUgeS14vhH+HquYS7EpFW?=
 =?us-ascii?Q?Vsm1eOr4bepKIuXCTa2WTLclmWnh213rbKI+q/3lvgnl0qBVrRP+UYNODn3A?=
 =?us-ascii?Q?5F2vapv3ueJzrL1uouMLOwDo1tRDg01sIEjzqxZFovWf0WfEpA/fYqUCZ+mE?=
 =?us-ascii?Q?uG/IqF36uLwc5Jm/AXl5l7/FSnOCYWIo1xsbC41gejmMrU08VMLMuOXbRY1K?=
 =?us-ascii?Q?QVcDM0UE0E4So5T4BEw3TsCCJB7v73VPUxf833uUO7sMSeh/KHQzugJFD6Js?=
 =?us-ascii?Q?JiSu8FX/e2f7zVn4of1J0xGZRxTyseL8fiK6AfmZKYJGScGO0vPi1sjRZEYR?=
 =?us-ascii?Q?05s1/laXQoJkdeNooT/sggtOaCkWX6XdlG4PugYitqCytV+8GZnBFpsvNKIE?=
 =?us-ascii?Q?P7YhmyhhJgE63S88PIaXL221HNkZrEF+UY8qKpQdYpwLWBs3bmKLPpscStuY?=
 =?us-ascii?Q?zNOf8eJdttrQGBbNUyzjvczm6KJ8BFWL01Lz+R2fCOxru+vn4Bw2Igdi4ng+?=
 =?us-ascii?Q?czYyY5lvHqYOU9jbC839TC8/L/c3lM72z1fvsFl7qT0Xi3PR7M3bqvmdasVE?=
 =?us-ascii?Q?W+jkFqLjN2ITAlHPYI47W3hJa7nJUVWP2I2Crrn0Za3PSF+7zHQPZ7oeNTeB?=
 =?us-ascii?Q?bA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05822f71-2644-4289-7a76-08db215257c8
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9563.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 10:29:35.0597
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hU21fX/tLRcNZcI3SWrjMbIeUbSSK5KIIWL8T2V33FZuFlr0j4taQCuS57Vu27Ob03p5YgvilFfmaHBGRo2rQho1x/DsKXtjI5l95y3EPBY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7313
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>

Facing build error in building tls
error: passing argument 3 of ?ahash_request_set_callback?
from incompatible pointer type [-Werror=incompatible-pointer-types]

Issue introduced after changing prototype of "crypto_completion_t"
function pointer in include/linux/crypto.h, conversion of
completion function of tls was missed.

Changes are done to use data directly in completion function of tls.

Fixes: 255e48eb1768 ("crypto: api - Use data directly in completion function")
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
---
 crypto/tls.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/crypto/tls.c b/crypto/tls.c
index e04f3b450b43..f16810238d1a 100644
--- a/crypto/tls.c
+++ b/crypto/tls.c
@@ -1,6 +1,6 @@
 /*
  * Copyright 2013 Freescale
- * Copyright 2017 NXP
+ * Copyright 2017, 2023 NXP
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of the GNU General Public License as published by the Free
@@ -50,9 +50,9 @@ struct async_op {
 	int err;
 };
 
-static void tls_async_op_done(struct crypto_async_request *req, int err)
+static void tls_async_op_done(void *data, int err)
 {
-	struct async_op *areq = req->data;
+	struct async_op *areq = data;
 
 	if (err == -EINPROGRESS)
 		return;
-- 
2.25.1