Date:   Fri, 10 Mar 2023 19:30:28 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        samitolvanen@google.com, stable@vger.kernel.org
Subject: Re: [PATCH] crypto: arm64/aes-neonbs - fix crash with CFI enabled
Message-ID: <ZAsU1Aj6nIe1zlWl@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230227063223.1829703-1-ebiggers@kernel.org>
Precedence: bulk

Eric Biggers <ebiggers@kernel.org> wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> aesbs_ecb_encrypt(), aesbs_ecb_decrypt(), aesbs_xts_encrypt(), and
> aesbs_xts_decrypt() are called via indirect function calls.  Therefore
> they need to use SYM_TYPED_FUNC_START instead of SYM_FUNC_START to cause
> their type hashes to be emitted when the kernel is built with
> CONFIG_CFI_CLANG=y.  Otherwise, the code crashes with a CFI failure if
> the compiler doesn't happen to optimize out the indirect calls.
> 
> Fixes: c50d32859e70 ("arm64: Add types to indirect called assembly functions")
> Cc: stable@vger.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> arch/arm64/crypto/aes-neonbs-core.S | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt