Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 711CDC6FA99 for ; Fri, 10 Mar 2023 11:32:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229891AbjCJLcE (ORCPT ); Fri, 10 Mar 2023 06:32:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230050AbjCJLcD (ORCPT ); Fri, 10 Mar 2023 06:32:03 -0500 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C2ADB9515; Fri, 10 Mar 2023 03:32:02 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1paayU-002Y9V-85; Fri, 10 Mar 2023 19:31:51 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 10 Mar 2023 19:31:50 +0800 Date: Fri, 10 Mar 2023 19:31:50 +0800 From: Herbert Xu To: Jonathan McDowell Cc: Antoine Tenart , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] crypto: inside-secure: Handle load errors better Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Feb 28, 2023 at 06:28:23PM +0000, Jonathan McDowell wrote: > 2 minor patches to improve the error handling of the safexcel driver > when it fails to load. > > Firstly, make it clear when the reason for a load failure is because the > firmware is not available. > > Secondly, ensure we clean up the ring workqueues / IRQ affinity settings > to avoid a kernel warning when the driver fails to load. > > v2: > - Expand error clean up to cover ring initialisation failures > > Jonathan McDowell (2): > crypto: inside-secure: Raise firmware load failure message to error > crypto: inside-secure - Cleanup ring IRQ workqueues on load failure > > drivers/crypto/inside-secure/safexcel.c | 39 ++++++++++++++++++------- > 1 file changed, 28 insertions(+), 11 deletions(-) > > -- > 2.39.2 All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt