Date:   Sat, 11 Mar 2023 16:03:53 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@redhat.com>
Cc:     Horia =?utf-8?Q?Geant=C4=83?= <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Gaurav Jain <gaurav.jain@nxp.com>,
        Mathew McBride <matt@traverse.com.au>,
        linux-crypto@vger.kernel.org
Subject: Re: Hitting BUG_ON in crypto_unregister_alg() on reboot with
 caamalg_qi2 driver
Message-ID: <ZAw16S7OQyYCAK90@gondor.apana.org.au>
References: <87r0tyq8ph.fsf@toke.dk>
 <ZAqwTqw3lR+dnImO@gondor.apana.org.au>
 <87ilf8rakq.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87ilf8rakq.fsf@toke.dk>
Precedence: bulk

On Fri, Mar 10, 2023 at 02:37:57PM +0100, Toke H?iland-J?rgensen wrote:
>
> Also, absent of a fixed driver (which doesn't sound like it's a trivial
> fix?), how do I prevent the system from crashing on shutdown? The
> BUG_ON() seems a bit heavy-handed, could it be replaced with a WARN_ON?

Yes I think that's probably OK.  Could you please send a patch?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt