From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Horia =?utf-8?Q?Geant=C4=83?= <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Gaurav Jain <gaurav.jain@nxp.com>,
        Mathew McBride <matt@traverse.com.au>,
        linux-crypto@vger.kernel.org
Subject: Re: Hitting BUG_ON in crypto_unregister_alg() on reboot with
 caamalg_qi2 driver
In-Reply-To: <ZAw16S7OQyYCAK90@gondor.apana.org.au>
References: <87r0tyq8ph.fsf@toke.dk> <ZAqwTqw3lR+dnImO@gondor.apana.org.au>
 <87ilf8rakq.fsf@toke.dk> <ZAw16S7OQyYCAK90@gondor.apana.org.au>
Date:   Sat, 11 Mar 2023 17:21:21 +0100
Message-ID: <87h6urqmwu.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Herbert Xu <herbert@gondor.apana.org.au> writes:

> On Fri, Mar 10, 2023 at 02:37:57PM +0100, Toke H=C3=B8iland-J=C3=B8rgense=
n wrote:
>>
>> Also, absent of a fixed driver (which doesn't sound like it's a trivial
>> fix?), how do I prevent the system from crashing on shutdown? The
>> BUG_ON() seems a bit heavy-handed, could it be replaced with a WARN_ON?
>
> Yes I think that's probably OK.  Could you please send a patch?

Sure, can do! :)

-Toke