Date:   Sun, 12 Mar 2023 15:27:10 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@redhat.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Horia =?utf-8?Q?Geant=C4=83?= <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Gaurav Jain <gaurav.jain@nxp.com>,
        Mathew McBride <matt@traverse.com.au>, stable@vger.kernel.org,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: Demote BUG_ON() in crypto_unregister_alg() to a
 WARN_ON()
Message-ID: <ZA1+zr0NapJlsKk9@gondor.apana.org.au>
References: <20230311162513.6746-1-toke@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230311162513.6746-1-toke@redhat.com>
Precedence: bulk

On Sat, Mar 11, 2023 at 05:25:12PM +0100, Toke H?iland-J?rgensen wrote:
>
> diff --git a/crypto/algapi.c b/crypto/algapi.c
> index d08f864f08be..e9954fcb61be 100644
> --- a/crypto/algapi.c
> +++ b/crypto/algapi.c
> @@ -493,7 +493,7 @@ void crypto_unregister_alg(struct crypto_alg *alg)
>  	if (WARN(ret, "Algorithm %s is not registered", alg->cra_driver_name))
>  		return;
>  
> -	BUG_ON(refcount_read(&alg->cra_refcnt) != 1);
> +	WARN_ON(refcount_read(&alg->cra_refcnt) != 1);

I think we should return here instead of continuing to destroy
the algorithm since we know that it's still in use.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt