Date:   Mon, 13 Mar 2023 09:08:36 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Horia =?utf-8?Q?Geant=C4=83?= <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Gaurav Jain <gaurav.jain@nxp.com>,
        Mathew McBride <matt@traverse.com.au>, stable@vger.kernel.org,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: Demote BUG_ON() in crypto_unregister_alg() to a
 WARN_ON()
Message-ID: <ZA53lHkyWcTTCWXF@gondor.apana.org.au>
References: <20230311162513.6746-1-toke@redhat.com>
 <ZA1+zr0NapJlsKk9@gondor.apana.org.au>
 <ZA2zLtqrI4aeLSTj@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZA2zLtqrI4aeLSTj@kroah.com>
Precedence: bulk

On Sun, Mar 12, 2023 at 12:10:38PM +0100, Greg KH wrote:
>
> Also, this still panics a box with panic-on-warn enabled, so if this can
> be handled, returning an error is good.

Well it can't really be handled because the driver is trying
to unregister an in-use algorithm so it's going to die one way
or another.

But returning here at least means that if this is happening
through shutdown then the system at least gets a chance to
reboot.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt