From:   Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
To:     Varun Sethi <V.Sethi@nxp.com>, Pankaj Gupta <pankaj.gupta@nxp.com>,
        Gaurav Jain <gaurav.jain@nxp.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] crypto: tls - Use data directly in completion function
Thread-Topic: [PATCH] crypto: tls - Use data directly in completion function
Thread-Index: AQHZUzs1GrLLqVso40eqVqf5w6Qskq74ccXw
Date:   Mon, 13 Mar 2023 09:14:29 +0000
Message-ID: <DU0PR04MB95639B763B060C2AEFC3F64D8EB99@DU0PR04MB9563.eurprd04.prod.outlook.com>
References: <20230310102912.1966201-1-meenakshi.aggarwal@nxp.com>
In-Reply-To: <20230310102912.1966201-1-meenakshi.aggarwal@nxp.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?j5fPXU2wlayudV8QmXkJPERXYxb9qG30a2WsRy5h60VeN8IhAtd0szD0Sf7k?=
 =?us-ascii?Q?ZW2LgR7VshKtpHN6RoU0eJ5X01vKwJ0+iK3rZjfuqybFNM3S89G5EZa5hnA8?=
 =?us-ascii?Q?rGZPHio1UkzrU/fbDkJfSFaBzor+ulM4k0FfTwanl+d5cQaDmJF416qZlmQI?=
 =?us-ascii?Q?wIzLV0mBOuk313LGpcBQdPij6ctQJ+Kmp+BSJ3UhfSNtG3nQh8l8nHEsKoDd?=
 =?us-ascii?Q?7Mzx5hKIjGKC7y9qgR1cM/D5bNx3HMlSUIFhGHr5ONsJfTuGeQ+lOKRHcEr9?=
 =?us-ascii?Q?ryw37Re5wQVq1cXZNT1+6YjDNqpW6Wz+G3i2cTXrzPg6+TvXm1PnEFbgeBLc?=
 =?us-ascii?Q?Zc2aP2hwfeyP3w56wkR1WG7K7KIscJTrAbahmi/v5mHumH/WXGT8pPwwyoQr?=
 =?us-ascii?Q?HCTrkCFYceQASK0grj1EDe5x1wJEkK47W/FnBtEBnhIRoVPr3YYXmeHUs20G?=
 =?us-ascii?Q?lfyEZ/Zdeu0PJv07VIHP0lvCC89d7puYq50DqLUsYboW018aiaUF3sCVQWs+?=
 =?us-ascii?Q?+8vXY+IAMqe4i2SZ2nbm7zI9+38OIEoi7e/cUci0DxJnWs5pr46fhWGFHMB8?=
 =?us-ascii?Q?XnHLPHNRQz5omt9ZrxuArI5TiGv96bEAEwj/eeiYS6ipHZc/Sp7buj5PMrzd?=
 =?us-ascii?Q?qbd638NKf2L/w3UhmVc4J0yed23Z2BK2JGM+7pq6lPA8UV4TpkB8RHkHyfxy?=
 =?us-ascii?Q?WVljAtn73m6GqDfVeO33UQ4oWTb0utGPiMqf4aKiKipZDLAUvXsEoZYvaDcn?=
 =?us-ascii?Q?C9DajhYlf7TsGxjynsNCw1S7MjNTt44qFoVEwKn0WfMVsn12XikZpmv3uige?=
 =?us-ascii?Q?NG+CGtBxd+8aQ9/aCxILa8m4g6AWn1yRz7NX0FKbdWfAU9ZFCptXx8HIgTu8?=
 =?us-ascii?Q?B+VF80RkwiHhCqBvCdKLRLEoHROqFVzhbHHQ4fsrULpX6gwf4Lyc18chSomv?=
 =?us-ascii?Q?fXoMlvselZoD0zO8vwiydLlnkBTgnN4RCOnmcy4HBwdh20PXnuHW/QnZloot?=
 =?us-ascii?Q?x8Cc9OxqfnAjJW17TCyyK43idmUEaFmgqgvTIqBT9pl+9Gg+YXykAAjD4Spd?=
 =?us-ascii?Q?ebXRex7TP8k5nxnuPSONtp1YVLC1E95QnWi8A41XrKp9knHDdVJBsf17nXOB?=
 =?us-ascii?Q?ochxtM/Qne2+jBrjJFOinSdev4X1YDHz98vCMX7ECAIiH46psOgHoxcTyA3W?=
 =?us-ascii?Q?OGLnu8fNVzXwA/p5DbVgSCy55RvrIJnoZU5vzZ57WnjRFKWX3MkpbICTFPf8?=
 =?us-ascii?Q?d4fJVRuSMqzM5AEmnu2FklJgn+Ai+Tu6muOLVejY/USxJIhDGeJJBy5kuV2k?=
 =?us-ascii?Q?+jc2h0Q5twTls6IZrhuMW0igDa0cp93SNUi5oZGH6/ZSLj4vek2O5GIRJ9ss?=
 =?us-ascii?Q?x24JWBNnBjTqwmiDzWKcGypQzxrskab5+aezZN3CHLOI3X9HnFMDMWg0lgsk?=
 =?us-ascii?Q?swLDuXFkQN/t8b+KUQ590us+LMyIhkd2br/GxoqDXA1D2dBvUeUjFhBt8xcG?=
 =?us-ascii?Q?L+ts3p1K+pscKoRhVQnsNw2I4aGQ3ncnMB7/ibUWCpmncescGOX1AVO9J+Ia?=
 =?us-ascii?Q?5+zb9WWbOqQuiACr8uSU8Fae12lav5GAVBH6ywsEztj/FMzt5zG97Sa7gGyV?=
 =?us-ascii?Q?bQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9563.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6010b8ed-af92-4c8c-5b80-08db23a359d9
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2023 09:14:29.3678
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0Nzhd+qopwQzD9pjdHxRERxhaYrjTV+jgyTgPGrn9l86l1K6fcg78DcXdXAznLLIhdyEV8AVomAIJlRYOIf+RpiXepwOecBSuwgjLpe8fv4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9445
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Please don't review the patch, sent by mistake.

Thanks,
Meenakshi

> -----Original Message-----
> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Sent: Friday, March 10, 2023 3:59 PM
> To: Varun Sethi <V.Sethi@nxp.com>; Pankaj Gupta <pankaj.gupta@nxp.com>;
> Gaurav Jain <gaurav.jain@nxp.com>; herbert@gondor.apana.org.au;
> davem@davemloft.net; linux-crypto@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Subject: [PATCH] crypto: tls - Use data directly in completion function
>=20
> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>=20
> Facing build error in building tls
> error: passing argument 3 of ?ahash_request_set_callback?
> from incompatible pointer type [-Werror=3Dincompatible-pointer-types]
>=20
> Issue introduced after changing prototype of "crypto_completion_t"
> function pointer in include/linux/crypto.h, conversion of completion func=
tion of
> tls was missed.
>=20
> Changes are done to use data directly in completion function of tls.
>=20
> Fixes: 255e48eb1768 ("crypto: api - Use data directly in completion funct=
ion")
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> ---
>  crypto/tls.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/crypto/tls.c b/crypto/tls.c index e04f3b450b43..f16810238d1a
> 100644
> --- a/crypto/tls.c
> +++ b/crypto/tls.c
> @@ -1,6 +1,6 @@
>  /*
>   * Copyright 2013 Freescale
> - * Copyright 2017 NXP
> + * Copyright 2017, 2023 NXP
>   *
>   * This program is free software; you can redistribute it and/or modify =
it
>   * under the terms of the GNU General Public License as published by the=
 Free
> @@ -50,9 +50,9 @@ struct async_op {
>  	int err;
>  };
>=20
> -static void tls_async_op_done(struct crypto_async_request *req, int err)
> +static void tls_async_op_done(void *data, int err)
>  {
> -	struct async_op *areq =3D req->data;
> +	struct async_op *areq =3D data;
>=20
>  	if (err =3D=3D -EINPROGRESS)
>  		return;
> --
> 2.25.1