From:   meenakshi.aggarwal@nxp.com
To:     horia.geanta@nxp.com, V.sethi@nxp.com, pankaj.gupta@nxp.com,
        gaurav.jain@nxp.com, herbert@gondor.apana.org.au,
        davem@davemloft.net, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] crypto: caam/jr - fix algorithms exit/cleanup
Date:   Tue, 14 Mar 2023 23:37:33 +0530
Message-Id: <20230314180733.4167836-1-meenakshi.aggarwal@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kdJCN5HzPSbg8+iUoIKBOaspMafeN8mQ7IBELYuRcXhCQf4Eo3Ra5aMZq6C5?=
 =?us-ascii?Q?7i+yaVnCxPPY+Cwo0kVPdoei1hA7Tq9wU2+iog7zrW0Qtb4y+ouJOi01N+Vv?=
 =?us-ascii?Q?PhWsV8Tqgf0QZrRIn1IvHgauJLAaneZzgxAFVcpa78b35Vhu+1+ELnU01Bhz?=
 =?us-ascii?Q?t90EYXNa1uVx5yPJTEgqNcdvtimn5An6gadvuD+f6hXRAA8OSVBKRcrSd5/N?=
 =?us-ascii?Q?u+o2zkZOAaOKcZPIcoR8jG9p47asOAjbJrtQ6Due9Bf49y+4BSDadvqY4RdH?=
 =?us-ascii?Q?1ORlSGOY4mR+5oYcQPQuonSChU2M6/bL/DbbN132RPVKS8XEhA/dIvJbOeRb?=
 =?us-ascii?Q?63w8VMphVhkjbAW93WhUa2XRYMdS0fI++PtmZJzljet7oBDpg/VfJ/5+Q6x/?=
 =?us-ascii?Q?ulhrHyT8/QhGA3DuE27e7jJzZc+wrUOw5dIgG9bXp3YDwMc/Jw+p3loaTMe4?=
 =?us-ascii?Q?fHHmz8SC5NUqun0U/9ZxXyxaGjCpG6LMfpC/4i7eLk+Tr6Zz5tRxY8uBlPiE?=
 =?us-ascii?Q?GzdoLhBllViSb9wbI4NqLFYVK78UUa4/ajum2v6HWbIuTnDRKcfvFfyDmYew?=
 =?us-ascii?Q?1cJsm56REQkH24WylqLKT06TgH+ZjblUzALYSjCwXlMnmfhrUF3rOGFTKRCu?=
 =?us-ascii?Q?+x0d5roeO2w1SLr0dyninbP7gPnoac/u4l9kq17M8fUFuzZWO3JZe4B0nWjP?=
 =?us-ascii?Q?gZFVCyiHABSJu4wF/iBRyhru6M+Oy/HepHrDUPLkVrxdthbFKOG12GBm4FNV?=
 =?us-ascii?Q?2rkb5bKdUrdKYnhVJIgarp77nPP3mRhw0+IwHPjkqrEPitEh7HiOlHWLK8b0?=
 =?us-ascii?Q?fNO5tyScAlIN74uArID5TmU8Susli32vFl+xoLiXE7/OvcB3vKRAUAQ+byEi?=
 =?us-ascii?Q?Q++K+L/OxOrd6AHtW12jCDQIipdtwyYhbzckKXUjCtLZBHosktwY3nGBnHhq?=
 =?us-ascii?Q?5YH1POg4ZrooZ2C/l3u2ZOnOI5qvRFGJM+1cH9UhN3GciBwV1wfaqXys8p33?=
 =?us-ascii?Q?9cNHD+Lx/eE921Kir8vhYUD5H7bwPD1vZ9DQpbbp3Oc77GID2hS392We0VXg?=
 =?us-ascii?Q?CtKltY/Esr5bZo2HLP6uqB97y3Smdzi9r3qbhpTlEcL/Y49PPXt1RKvDsbFl?=
 =?us-ascii?Q?MguDEeVqDY6Ibg67ek9gG+uSj39xnh0i7MhZ2P/Uh9E4u3DBkSkCGzW3Ipo8?=
 =?us-ascii?Q?soQ/X2gfQQF/0y45aBkKfM1Yokgwg7tZn3QZ7/Z0KaBFwh0i/qObkFJkBbYf?=
 =?us-ascii?Q?0I+jLqT9C2cLl5oDGo3kItlU8BUIjiHZkri/9t4uEQUbjHgEFj3917LyPdI+?=
 =?us-ascii?Q?7ttRokJSJxWEx57UNQbGJCfVasuc1gTNzUE1K147aK+OcClsvqM21LH8cYbQ?=
 =?us-ascii?Q?pznz+ndkVCuebQA50u+MWbEyOAw99QV4SCAeHT4CosAsbNyj2l89UFLfCf81?=
 =?us-ascii?Q?9/pzKrs9p1NGzmYdmMDQYX9jizMX6rXbV1P/K//RNisWd6epYYHhOnoBZWKK?=
 =?us-ascii?Q?r3njkEi9dYEA2TOoqYHyplULHdl+FBVXefp+nyGgJ5v1d1LxyWVhXPwBYr1Z?=
 =?us-ascii?Q?JyIYh0H7wa2o7+NgjJIZTMQ9doUGA7KLk7+wvHH9csYX1zqz4gLoUYgpUZVE?=
 =?us-ascii?Q?cQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e55e93f6-4d29-4b3a-13ab-08db24b70fbf
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9563.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 18:08:06.7352
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6OkOBBCEoYhczCl+uVo+Ho7DhAi/KkpuOkSFiwPDNWjC30EOdpbytVq61T+Vj1UgydeeeXNRTZISA7pkVk2vt38+3fDydEYk206NPZ4BfDw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7755
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

From: Horia GeantA <horia.geanta@nxp.com>

Current implementations is not being able to gracefully unregister
crypto algorithms from crypto API while there are users / allocated
tfms (cra_refcnt > 1).

When unloading the caam_jr module, the .remove callback for the last JR
device exits with -EBUSY and doesn't perform the clean-up
(crypto algorithms unregistering etc.).

One side effect of this is leading to an oops, which occurs due to a
corruption in the linked list of "misc devices"
(drivers/char/misc.c - misc_list)

Signed-off-by: Horia GeantA <horia.geanta@nxp.com>
---
 drivers/crypto/caam/jr.c | 39 +++++++++++++++++++++++++++++++++------
 1 file changed, 33 insertions(+), 6 deletions(-)

diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index 724fdec18bf9..9918ae0a33a7 100644
--- a/drivers/crypto/caam/jr.c
+++ b/drivers/crypto/caam/jr.c
@@ -27,8 +27,36 @@ static struct jr_driver_data driver_data;
 static DEFINE_MUTEX(algs_lock);
 static unsigned int active_devs;
 
-static void register_algs(struct caam_drv_private_jr *jrpriv,
-			  struct device *dev)
+static void init_misc_func(struct caam_drv_private_jr *jrpriv,
+			   struct device *dev)
+{
+	mutex_lock(&algs_lock);
+
+	if (active_devs != 1)
+		goto algs_unlock;
+
+	jrpriv->hwrng = !caam_rng_init(dev);
+
+algs_unlock:
+	mutex_unlock(&algs_lock);
+}
+
+static void exit_misc_func(struct caam_drv_private_jr *jrpriv,
+			   struct device *dev)
+{
+	mutex_lock(&algs_lock);
+
+	if (active_devs != 1)
+		goto algs_unlock;
+
+	if (jrpriv->hwrng)
+		caam_rng_exit(dev);
+
+algs_unlock:
+	mutex_unlock(&algs_lock);
+}
+
+static void register_algs(struct device *dev)
 {
 	mutex_lock(&algs_lock);
 
@@ -38,7 +66,6 @@ static void register_algs(struct caam_drv_private_jr *jrpriv,
 	caam_algapi_init(dev);
 	caam_algapi_hash_init(dev);
 	caam_pkc_init(dev);
-	jrpriv->hwrng = !caam_rng_init(dev);
 	caam_prng_register(dev);
 	caam_qi_algapi_init(dev);
 
@@ -136,8 +163,7 @@ static int caam_jr_remove(struct platform_device *pdev)
 	jrdev = &pdev->dev;
 	jrpriv = dev_get_drvdata(jrdev);
 
-	if (jrpriv->hwrng)
-		caam_rng_exit(jrdev->parent);
+	exit_misc_func(jrpriv, jrdev->parent);
 
 	/*
 	 * Return EBUSY if job ring already allocated.
@@ -595,7 +621,8 @@ static int caam_jr_probe(struct platform_device *pdev)
 
 	atomic_set(&jrpriv->tfm_count, 0);
 
-	register_algs(jrpriv, jrdev->parent);
+	register_algs(jrdev->parent);
+	init_misc_func(jrpriv, jrdev->parent);
 
 	return 0;
 }
-- 
2.25.1