Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp891473rwl; Fri, 24 Mar 2023 03:32:31 -0700 (PDT) X-Google-Smtp-Source: AKy350axKnEBI+e45xpHG1HM0poqzJpHH5nfsIp9z8/943Sje7OtCo75ce8hw7BXAuEAYsTGSfEZ X-Received: by 2002:a17:906:7490:b0:933:fa42:7e36 with SMTP id e16-20020a170906749000b00933fa427e36mr1985459ejl.5.1679653951554; Fri, 24 Mar 2023 03:32:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679653951; cv=none; d=google.com; s=arc-20160816; b=Abp3XzhiSSZMlqogP7odH0v7PM3nTrhJmtQBAw9JVDTTLTRpRRVstKCHqH1iliYnQL KfNOC8+RnWzqXpzm08kpqIbrhqSrK1kVzvOx91eOuXdSqdlQh659zt7c9dh7e8AIQSeg hgdkSFl4Uku65yFhogiRaXCkqOUc9jeoD/gsP0JqOtNzXyT8gVTa/kpL3rNuvmMtXFBr gXga3XjhhzS0mQigvnZ4eRTkaGKqFvB4mENwLQX+qSdMR41BVcQMWmucXZUXPvh7fWlm UKHUTggIoxyR3Ey6r/c5qo1IkxYFI4TtZlEFHFktBFBMM6We0B5p33auq2tL3W5+TmHF 9KSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=QKc/b3H/YYbAHtkKMJMkxXGc+VZz62hMk0nxdt6pE2k=; b=CEOcRp5c9QE3IrYnH0Z+P7wwEgGb9lCxkwI43O7Ym86wjoYXqa7qNXdnaBoaJviRMO iHnfT21YxcXkXZQ4d3eP+rtPDh8XVZckUq06AdlK25Bsrh6mkBAIDuQFN2gGWY76r8SO dbIIhXDtsnAEx9SnYaTTXuB77ep0GZFNULAdecsS+7idlaMntTnDvVTwXKdYVMYEP7R9 fhykXcyGyqbfQVoQvV+Bl06WG5Si7PO7jaa73J0BaHjZWYff92l39V4aCiXNmraDyZ+P i7QwwHpZ3+Xh1MFdLlLh1Ak4rRewR4LzHRyP2rnwzFcuPS46vi97uQejRK0JFSuTCnY/ lH6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w16-20020a170906d21000b009153f0ec59bsi17536914ejz.800.2023.03.24.03.32.06; Fri, 24 Mar 2023 03:32:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231737AbjCXK3s (ORCPT + 99 others); Fri, 24 Mar 2023 06:29:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231805AbjCXK3h (ORCPT ); Fri, 24 Mar 2023 06:29:37 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69AAF20544 for ; Fri, 24 Mar 2023 03:29:35 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1pfefk-008FcZ-Kb; Fri, 24 Mar 2023 18:29:25 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 24 Mar 2023 18:29:24 +0800 Date: Fri, 24 Mar 2023 18:29:24 +0800 From: Herbert Xu To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Daniele Alessandrelli , "David S. Miller" , linux-crypto@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] crypto: keembay-ocs-aes: Drop if with an always false condition Message-ID: References: <20230314182338.2869452-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230314182338.2869452-1-u.kleine-koenig@pengutronix.de> X-Spam-Status: No, score=4.3 required=5.0 tests=HELO_DYNAMIC_IPADDR2, PDS_RDNS_DYNAMIC_FP,RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS,TVD_RCVD_IP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: **** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Mar 14, 2023 at 07:23:38PM +0100, Uwe Kleine-K?nig wrote: > A platform device's remove callback is only ever called after the probe > callback returned success. > > In the case of kmb_ocs_aes_remove() this means that kmb_ocs_aes_probe() > succeeded before and so platform_set_drvdata() was called with a > non-zero argument and platform_get_drvdata() returns non-NULL. > > This prepares making remove callbacks return void. > > Signed-off-by: Uwe Kleine-K?nig > --- > drivers/crypto/keembay/keembay-ocs-aes-core.c | 2 -- > 1 file changed, 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt