Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <5915902.lOV4Wx5bFT@positron.chronox.de> <20230324174709.21533-1-vdronov@redhat.com>
 <7502351.DBV9aYCCVu@tauon.chronox.de>
In-Reply-To: <7502351.DBV9aYCCVu@tauon.chronox.de>
From:   Vladis Dronov <vdronov@redhat.com>
Date:   Sat, 25 Mar 2023 15:44:59 +0100
Message-ID: <CAMusb+RsaSdztEgUMO=JD-ZcJ19v41r1Mw0oY-CUgtJTr+FzTg@mail.gmail.com>
Subject: Re: [PATCH v3] Jitter RNG - Permanent and Intermittent health errors
To:     Stephan Mueller <smueller@chronox.de>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        linux-crypto@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Stephan,

On Fri, Mar 24, 2023 at 6:56=E2=80=AFPM Stephan Mueller <smueller@chronox.d=
e> wrote:
>
> Thank you very much. I have fixed it in my local copy, but will wait for
> another bit in case there are other reports.

A couple of more suggestions, if I may. These are really small,
I'm suggesting them just due to a sense of perfection.

1) A patch name. All the patches in this area look like
"crypto: jitter - <lowercase letters>". Probably a patch name could be
adjusted as "crypto: jitter - permanent and intermittent health errors"?

2) You use panic("Jitter RNG permanent health test failure\n") in your
patch. With that, probably, jent_panic() could be removed, since
nothing is using it, couldn't it?

Best regards,
Vladis