Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2290705rwl; Sun, 26 Mar 2023 20:15:13 -0700 (PDT) X-Google-Smtp-Source: AKy350b7O8yugbkODd2XaCkBzK4mGqw2GqDO83itI37nNGeWkUPsbX+aZRFNIh6y8oD6v5IW3W+q X-Received: by 2002:a17:903:788:b0:1a1:bf37:7c2e with SMTP id kn8-20020a170903078800b001a1bf377c2emr8771231plb.4.1679886913300; Sun, 26 Mar 2023 20:15:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679886913; cv=none; d=google.com; s=arc-20160816; b=SMHjYy1a40iAzZ6hH2TK72hulV9xUfnGncCwjHiBJ1BftjW10/T8rTmgsYsPLqJrt5 NdNIkQ4nFI7kLQMSwy1QWfX6Drj9as7mngL78eXqoTh75IdQgYzgGQ8sraLnOvCOuklU dm+qjqay6O3REwANLRPLZsT8cIZpvLX9SxtXP00emLB7B/HntHFLnKFqW86blyIq5cfD btD8urjvjsHj/+AygrhCDTcplulF3lauFIOn2b+Tksm8DtKihD5rsHUnV7ulufe2FYMT bvdiO2YGcLyt9yZu4+LRGhkL6wQqMSLrCan058Vr8q+F59QCQocAWRcJ0b4QmHcB2VOo O8vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=xmeHHCrkCyBPLaORsBj0Cpc/4uRrp4nTvg0u9Q8HWxY=; b=Fah1G9Y7fg9zXbEbsiEwOaBEvj0P+IIgv+9/Mdgw+AT3+shL8Rs+9veGKJJnP5DkgP sXCJk3VGSJbZXss6wdMq/rdcte00skgpwHlMNtxhhS+oP2nwWNwUIl7/zoEYJo7IzzOM 22nXVG2H/GeHpaXKQQ6jWCYpDv8r9uFueFQCnCviEAcwcD+/T7LiO3ZID6FcOF6bAoDG b5Zb47pTPCG+/kns/yv1AegUZ//MFyrVo1N5eTHVaMMjuFE+LyupUiOcuKSQOwaiCTGk TKk7zaXQPsxUC3RIQRWXwxkIDGy2Ky+WfRzviOkJAL96lnHNgkb9CvpHobOZ3K9zoupQ htIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q1-20020a170902dac100b001a04202f782si29115859plx.122.2023.03.26.20.14.50; Sun, 26 Mar 2023 20:15:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbjC0DMr convert rfc822-to-8bit (ORCPT + 99 others); Sun, 26 Mar 2023 23:12:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbjC0DMq (ORCPT ); Sun, 26 Mar 2023 23:12:46 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCE593A9F; Sun, 26 Mar 2023 20:12:43 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 2CB7424E309; Mon, 27 Mar 2023 11:12:37 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 27 Mar 2023 11:12:37 +0800 Received: from EXMBX168.cuchost.com ([fe80::3c2d:dee5:4938:3fc4]) by EXMBX168.cuchost.com ([fe80::3c2d:dee5:4938:3fc4%16]) with mapi id 15.00.1497.044; Mon, 27 Mar 2023 11:12:36 +0800 From: JiaJie Ho To: Herbert Xu CC: "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" Subject: RE: [PATCH v3 4/4] crypto: starfive - Add hash and HMAC support Thread-Topic: [PATCH v3 4/4] crypto: starfive - Add hash and HMAC support Thread-Index: AQHZVbQZd9+lAcQFW0yunvw0rKV1eK8JONIAgATPZGA= Date: Mon, 27 Mar 2023 03:12:36 +0000 Message-ID: <436f7f43f79b43209d3477c9d99addf6@EXMBX168.cuchost.com> References: <20230313135646.2077707-1-jiajie.ho@starfivetech.com> <20230313135646.2077707-5-jiajie.ho@starfivetech.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [202.188.176.82] x-yovoleruleagent: yovoleflag Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org > On Mon, Mar 13, 2023 at 09:56:46PM +0800, Jia Jie Ho wrote: > > > > +static void starfive_hash_dma_callback(void *param) { > > + struct starfive_cryp_dev *cryp = param; > > + > > + complete(&cryp->tx_comp); > > +} > > Please get rid of tx_comp and do the rest of the processing here. Hi Herbert, Thanks for reviewing the patch. I'll update this in next version. Best regards, Jia Jie