Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7c2665ab7e8560f705eb9b6b21c5f6eeebd85eb8.camel@linux.intel.com>
Subject: Re: [PATCH v2 04/15] dmaengine: idxd: Export descriptor management
 functions
From:   Tom Zanussi <tom.zanussi@linux.intel.com>
To:     Dave Jiang <dave.jiang@intel.com>, herbert@gondor.apana.org.au,
        davem@davemloft.net, fenghua.yu@intel.com, vkoul@kernel.org
Cc:     tony.luck@intel.com, wajdi.k.feghali@intel.com,
        james.guilford@intel.com, kanchana.p.sridhar@intel.com,
        giovanni.cabiddu@intel.com, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org
Date:   Tue, 28 Mar 2023 11:12:16 -0500
In-Reply-To: <79d0618f-950c-f2f0-7286-41e199ba0edb@intel.com>
References: <20230328153535.126223-1-tom.zanussi@linux.intel.com>
         <20230328153535.126223-5-tom.zanussi@linux.intel.com>
         <79d0618f-950c-f2f0-7286-41e199ba0edb@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

Hi Dave,

On Tue, 2023-03-28 at 09:04 -0700, Dave Jiang wrote:
>=20
>=20
> On 3/28/23 8:35 AM, Tom Zanussi wrote:
> > To allow idxd sub-drivers to access the descriptor management
> > functions, export them.
> >=20
> > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> > ---
> > =C2=A0 drivers/dma/idxd/submit.c | 3 +++
> > =C2=A0 1 file changed, 3 insertions(+)
> >=20
> > diff --git a/drivers/dma/idxd/submit.c b/drivers/dma/idxd/submit.c
> > index c01db23e3333..9d9ec0b76ccd 100644
> > --- a/drivers/dma/idxd/submit.c
> > +++ b/drivers/dma/idxd/submit.c
> > @@ -61,6 +61,7 @@ struct idxd_desc *idxd_alloc_desc(struct idxd_wq
> > *wq, enum idxd_op_type optype)
> > =C2=A0=20
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return __get_desc(wq, i=
dx, cpu);
> > =C2=A0 }
> > +EXPORT_SYMBOL_NS_GPL(idxd_alloc_desc, IDXD);
> > =C2=A0=20
> > =C2=A0 void idxd_free_desc(struct idxd_wq *wq, struct idxd_desc *desc)
> > =C2=A0 {
> > @@ -69,6 +70,7 @@ void idxd_free_desc(struct idxd_wq *wq, struct
> > idxd_desc *desc)
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0desc->cpu =3D -1;
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0sbitmap_queue_clear(&wq=
->sbq, desc->id, cpu);
> > =C2=A0 }
> > +EXPORT_SYMBOL_NS_GPL(idxd_free_desc, IDXD);
> > =C2=A0=20
> > =C2=A0 static struct idxd_desc *list_abort_desc(struct idxd_wq *wq,
> > struct idxd_irq_entry *ie,
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 struct idxd_desc *desc)
> > @@ -215,3 +217,4 @@ int idxd_submit_desc(struct idxd_wq *wq, struct
> > idxd_desc *desc)
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0percpu_ref_put(&wq->wq_=
active);
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 0;
> > =C2=A0 }
> > +EXPORT_SYMBOL_GPL(idxd_submit_desc);
>=20
> This one should use the EXPORT_SYMBOL_NS_GPL() as above?

Yeah, not sure how I missed that one ;-/

Thanks for pointing it out.

Tom