Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Mar 2023 10:40:38 -0700
From:   Eric Biggers <ebiggers@kernel.org>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: lib/utils - Move utilities into new header
Message-ID: <20230328174038.GA890@sol.localdomain>
References: <ZB10ijozlmPmxjJr@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZB10ijozlmPmxjJr@gondor.apana.org.au>
Precedence: bulk

On Fri, Mar 24, 2023 at 05:59:38PM +0800, Herbert Xu wrote:
> The utilities have historically resided in algapi.h as they were
> first used internally before being exported.  Move them into a
> new header file so external users don't see internal API details.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> ---
> 
>  include/crypto/algapi.h |   63 -----------------------------------------
>  include/crypto/utils.h  |   73 ++++++++++++++++++++++++++++++++++++++++++++++++
>  lib/crypto/utils.c      |    2 -
>  3 files changed, 75 insertions(+), 63 deletions(-)
> 

Thanks for doing this!  There are other files in lib/crypto/ that include
<crypto/algapi.h> currently.  It seems they should be changed to include
<crypto/utils.h> instead?

- Eric