Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2001952rwl; Wed, 12 Apr 2023 23:41:30 -0700 (PDT) X-Google-Smtp-Source: AKy350ZXO6LleEY2OkWUcM31uLTNf+s/lCroHE5jeVxxRWCpgzGiVaKlCBLh/D6EDuaEOzBHrl67 X-Received: by 2002:a17:903:2352:b0:19a:7217:32af with SMTP id c18-20020a170903235200b0019a721732afmr1852792plh.5.1681368090191; Wed, 12 Apr 2023 23:41:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681368090; cv=none; d=google.com; s=arc-20160816; b=a03GWzmDjT1IzTV2SMlfX3XT9ozYyAoUAjc2+AMrAAY/FIzvvF8TOKpkRijD4iBh3n K6r728XyNYyglbD6X4H+xIvHqvudNOWvNWZby5bTYxNPVNro08KNvjkP2ldj072+BxmL 3ll7Xlj+ZbMpT0ukV0UjeW2YvNYJrrahXRUWCS8heOSXAIgBvT0jGMDMR1mmlWpsoiWO 7VuowCwA8vI1Qmk1/9EIL4w8QvxSbTQn0Npx8Nbwoi6qNHIUydAe9ZblBfTmgSounPS/ OiInnU8qZlnOr89lEP2h/K3H8L/JltfrBAL0WQ44XeHK0GAcMr2zEc+snpPJuGQTqgqy AujQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization:dkim-signature; bh=y6rFAsx3AMO/NMfWX40xAA11ybh8cS3RvU0h7vdkgkI=; b=llLpJnW5qPruBH6zdprsq9w/mfKj9KaYHUSjCVHysVxqIF4AYOlUgKbK1I1verOBJt j/RrQfMiQQUMn1nlhbfquTH1K0uaIa3wq+POrfLFKkiORhvQHW+18K6Su3FY/cAbBmDM DGFobIJiYcmOV9w9ZBl8FmVlN5XanIPxnsjyMttUhSPXIWp6J7dUpxtNPzyoqAASV/Fi nIiCdjIAIiDEr+RLJtuvWBf2JOSTgbXcB8mWuC+zWPTGrWn5oFAkY+9sL5cJQKvvjwke 5GHq25JZdKQJZdgHkxOAruUAX7pePA3c6yU3aphterRw2XVIbSaZUcFpXATsGiInsQ8+ fSeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CTw36T7+; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q7-20020a17090311c700b001994712728csi1341382plh.607.2023.04.12.23.41.15; Wed, 12 Apr 2023 23:41:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CTw36T7+; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229535AbjDMGhL (ORCPT + 99 others); Thu, 13 Apr 2023 02:37:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjDMGhL (ORCPT ); Thu, 13 Apr 2023 02:37:11 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C9D87EF8 for ; Wed, 12 Apr 2023 23:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681367791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y6rFAsx3AMO/NMfWX40xAA11ybh8cS3RvU0h7vdkgkI=; b=CTw36T7+G/EDxP6AwGiulOa5cY9wxYqhIdjJRgLCn8B6eOGOza2oHFHiCCL/EQ33So0ly0 jw1GUxTN4bfrlK3Ro7FCaEbCX2Mz19xHU9b3MwM1CC4HXYxfIJTjhPYt95ak0KeEIKS6x/ TVY5mNDgWKpY3MSF8t1/4Iw6K1NuaBk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-113-qa-1fW4gNjGaJMXqhTI9-A-1; Thu, 13 Apr 2023 02:36:27 -0400 X-MC-Unique: qa-1fW4gNjGaJMXqhTI9-A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DF31D1C07552; Thu, 13 Apr 2023 06:36:26 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.177]) by smtp.corp.redhat.com (Postfix) with ESMTP id F04272027043; Thu, 13 Apr 2023 06:36:25 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <380323.1681314997@warthog.procyon.org.uk> <48886D84-1A04-4B07-A666-BB56684E759F@oracle.com> <385663.1681321803@warthog.procyon.org.uk> To: Herbert Xu Cc: dhowells@redhat.com, Scott Mayhew , Chuck Lever III , Ard Biesheuvel , Jeff Layton , Linux NFS Mailing List , "linux-crypto@vger.kernel.org" Subject: Re: Did the in-kernel Camellia or CMAC crypto implementation break? MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <413270.1681367785.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Thu, 13 Apr 2023 07:36:25 +0100 Message-ID: <413271.1681367785@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Herbert Xu wrote: > > I have them built into the kernel, both in sunrpc and my krb5 lib. Bo= th are > > failing. > = > So are there Crypto API test vectors for these algorithms and if so > are they succeeding or not? If they are working but your own vectors > going through your code isn't, then I would start looking there. krb5: Running camellia128-cts-cmac key alg: No test for cmac(camellia) (cmac(camellia-asm)) krb5: Running camellia128-cts-cmac enc no plain alg: No test for cts(cbc(camellia)) (cts(cbc-camellia-asm)) I'm guessing not. Do you know if there is "standard" test data somewhere? rfc3713 appendix = A has three but are there more? David