Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2466841rwl; Thu, 13 Apr 2023 06:56:33 -0700 (PDT) X-Google-Smtp-Source: AKy350bLr1/WzOu7Q4Kr9EdMx4uhQgGSd6vFYA2hYFAegobDkuP4Q9XXAsfT4WJPnMLc/EoNrI1F X-Received: by 2002:a05:6a20:3d1c:b0:e9:1dd:dafc with SMTP id y28-20020a056a203d1c00b000e901dddafcmr2777705pzi.4.1681394192777; Thu, 13 Apr 2023 06:56:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681394192; cv=none; d=google.com; s=arc-20160816; b=Q3FTeVStbRagLZtp5W7/IzQnoDu9nFSKUjGWBPPHfSjBFT3ZG/DSjoodQar3tsf2/C GKPW9mM0EgTBqYTpTn61ZidgNyUsPcEg1ZKcbH+ilBerjNTmnt/xQ61mhu/v/+pIEgWc uMpyya48qaflcltAevetQ+sVybxaZ3XNIniqd3duS83xQkCyPf+BV2Ep0Xm0nprDgGVz hthjLi4pLRhssKFMHj0QgQhJg5S6a67ldGzHalueYX3UEiYMUw/LBsoafDRc0tPnT3/X aii+iU6ux5TpAdyM7FvQadeUm/B7G3d02mR3QHiHAALUtv7VVnTqx1JEIK1cYWQvQU0G EcuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:from:organization :dkim-signature; bh=B7GgR7IsxIkffahtry2Nj63PUFsJG3FcJvFXpSBJLNA=; b=je2HTNdhlEIJQAi5bTHrSFEqRHjVIEb33y+A+Sb4lo7Ba03rt6/PuCNHd2cckDiNud 7NMiJvGeoaUReRRQtBGN6S50sE3LEw43PReNJEJ72fqX+BDbVqt/QdeutHrxLxT2SnqH y+792Ypdp0/LvtTU+O4qTzkP0UAb1x9a0vZDrkStCdUBoSX0p6iNBczF8WKdtfI1q983 eFzU+AnkLLHni4h4KQE4pm4JoReFcvmwWXNp1mXkrGGQSyN93E3SaV2MgGnVphcet1B8 3iSAaCAbBk5cPwayq6x4aq8ErbdPEpQ7CqLHqYWEItyScTb2J11yT5jjLIoYfAmOfCY3 lnkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WeYtm5z8; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o14-20020a63e34e000000b00517ab01bb8fsi2358255pgj.100.2023.04.13.06.56.19; Thu, 13 Apr 2023 06:56:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WeYtm5z8; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231417AbjDMNwv (ORCPT + 99 others); Thu, 13 Apr 2023 09:52:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231527AbjDMNws (ORCPT ); Thu, 13 Apr 2023 09:52:48 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7ACE132 for ; Thu, 13 Apr 2023 06:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681393921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B7GgR7IsxIkffahtry2Nj63PUFsJG3FcJvFXpSBJLNA=; b=WeYtm5z8FECNSeXo8cURFN0w7g/55IbCvNz/JYUyccAX5INFGHT4/aa3xY789loElB28sU 6CLfix8z7GRHQqkOwa4LCVysPDoRI6eV5yzJzQkyTZEv7eMqlv2ZQS4EuybQTHHJtFmgvG ypXparrjTW4gwdK90lc0yrfrvR2vCRc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-22-jphSqTr7PGaLvWhPkTXB_g-1; Thu, 13 Apr 2023 09:51:59 -0400 X-MC-Unique: jphSqTr7PGaLvWhPkTXB_g-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C45411C07597; Thu, 13 Apr 2023 13:51:57 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.177]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0C43492B00; Thu, 13 Apr 2023 13:51:56 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells To: Chuck Lever cc: dhowells@redhat.com, Scott Mayhew , Herbert Xu , linux-nfs@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] sunrpc: Fix RFC6803 encryption test MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1078409.1681393916.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Thu, 13 Apr 2023 14:51:56 +0100 Message-ID: <1078410.1681393916@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org = The usage_data[] array in rfc6803_encrypt_case() is uninitialised, so clea= r it as it may cause the tests to fail otherwise. Fixes: b958cff6b27b ("SUNRPC: Add encryption KUnit tests for the RFC 6803 = encryption types") Link: https://lore.kernel.org/r/380323.1681314997@warthog.procyon.org.uk/ Signed-off-by: David Howells cc: Chuck Lever cc: Scott Mayhew cc: Herbert Xu cc: linux-nfs@vger.kernel.org cc: linux-crypto@vger.kernel.org --- net/sunrpc/auth_gss/gss_krb5_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sunrpc/auth_gss/gss_krb5_test.c b/net/sunrpc/auth_gss/gss= _krb5_test.c index ce0541e32fc9..aa6ec4e858aa 100644 --- a/net/sunrpc/auth_gss/gss_krb5_test.c +++ b/net/sunrpc/auth_gss/gss_krb5_test.c @@ -1327,6 +1327,7 @@ static void rfc6803_encrypt_case(struct kunit *test) if (!gk5e) kunit_skip(test, "Encryption type is not available"); = + memset(usage_data, 0, sizeof(usage_data)); usage.data[3] =3D param->constant; = Ke.len =3D gk5e->Ke_length;