Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <48886D84-1A04-4B07-A666-BB56684E759F@oracle.com>
References: <48886D84-1A04-4B07-A666-BB56684E759F@oracle.com> <380323.1681314997@warthog.procyon.org.uk>
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     dhowells@redhat.com, Herbert Xu <herbert@gondor.apana.org.au>,
        Scott Mayhew <smayhew@redhat.com>,
        Ard Biesheuvel <ardb@kernel.org>,
        Jeff Layton <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: Did the in-kernel Camellia or CMAC crypto implementation break?
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1078649.1681394138.1@warthog.procyon.org.uk>
Date:   Thu, 13 Apr 2023 14:55:38 +0100
Message-ID: <1078650.1681394138@warthog.procyon.org.uk>
Precedence: bulk

Chuck Lever III <chuck.lever@oracle.com> wrote:

> Ah, I see Scott is Cc'd. Yes, Scott reported this to me yesterday.

Found it (see patch sent separately).  There was an uninitialised variable in
sunrpc.

The krb5lib problem was that I'd lost the byteswapping of the usage value in
the test data when I split it out of the net/rxrpc/ directory, e.g.:

@@ -167,7 +167,7 @@ const struct krb5_enc_test krb5_enc_tests[] = {
 		.plain	= "'1",
 		.conf	= "6F2FC3C2A166FD8898967A83DE9596D9",
 		.K0	= "5027BC231D0F3A9D23333F1CA6FDBE7C",
-		.usage	= 1,
+		.usage	= htonl(1),
 		.ct	= "842D21FD950311C0DD464A3F4BE8D6DA88A56D559C9B47D3F9A85067AF661559B8",
 	}, {
 		.krb5	= &krb5_camellia128_cts_cmac,

David