Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     David Howells <dhowells@redhat.com>
CC:     Scott Mayhew <smayhew@redhat.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sunrpc: Fix RFC6803 encryption test
Thread-Topic: [PATCH] sunrpc: Fix RFC6803 encryption test
Thread-Index: AQHZbg8kxXVDLyEa0UeUNTJmfmNujK8pQ98A
Date:   Thu, 13 Apr 2023 13:58:26 +0000
Message-ID: <1CFEE00F-FD42-4900-9080-3E084F60FD74@oracle.com>
References: <1078410.1681393916@warthog.procyon.org.uk>
In-Reply-To: <1078410.1681393916@warthog.procyon.org.uk>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?65MOZSLG+Q8ubm0uGNz0JoW8qCPNzAo1FyCwZBbCU8PDOBRWinkF6JZvng1P?=
 =?us-ascii?Q?hyQBys9Ebz+iY/wUN7TjK5xlm/FxXTeLca1Orsve9aitkwPsnKWxDNpt1qHm?=
 =?us-ascii?Q?t2Lct4mQBLfxlBk5uu7c48i6xciYlra2z/7lX5+sZu2PUEPPc9GGOWsIjach?=
 =?us-ascii?Q?qqfehqAo9kYrxQu5cZ4JzWeODAXE1YJjJIJeRS1LwPLeYqSSjVQRgIYmH3Is?=
 =?us-ascii?Q?braobB4esyKq9B/AT47SQE6VXT3x8CRye0HZUSIABzKdI39dls4EOOyOzuvL?=
 =?us-ascii?Q?rZE8VQTm4Nu/ig9TQ84JyyGaRwUXoInJkYLL+AN8t8L/KnLWypFTh46VSxsZ?=
 =?us-ascii?Q?UMPVQNRmDNWCM51oEL5CgCSzeYU29cq5XZ4vVbWs7eRVqG2AkecYg7zD2qER?=
 =?us-ascii?Q?COgogJC1vcKISpRBMcs59lTfjGL2+tGdTMBXwbeMyGdCkx5AJoqSZ95QUJpK?=
 =?us-ascii?Q?R8pAOKMdKrmk1PC9rZN8iMAX+aSaFoZuEEEqNXpXMzuPqyhl+LYJx3SgrAMN?=
 =?us-ascii?Q?XFaXwWKDYnsQk+wcJ8uNsDdbcolka+fQlQjT2uiJWFl+ooCv570YLUFixMcX?=
 =?us-ascii?Q?eFWEPWPfn+scZ6PKyYZAja0uaw2XvMtfnYT7Gyyfy+lmCTCWYIrQ+UAQI0WE?=
 =?us-ascii?Q?/5RQ/O2lCEK6570D2VCmXF2iE65v93jEPxyVsOfakG5EJ7IqmaLRa1M8dJK5?=
 =?us-ascii?Q?H45ohVgy58bshlkB7vYOSq0yGLVXnhi+wEkEj24yspIE1TyEbzwz8x/ZN5f6?=
 =?us-ascii?Q?L1ks2cShIs2TEVi31tWhK4dfzIsdiPkYUfoSsvPs9H3aMWdcBlQrC3bPEPkY?=
 =?us-ascii?Q?clNkGzD900MnOT/kCbPlZF0/O4N2zZ3Tai3Vxj+6YkPdeaDfdGDirLZ7rF7C?=
 =?us-ascii?Q?OUR53KEmqp6oZ5mcjjD3iFjwqrHMpUrEixaeprCNbUle2ei6INIr8P8aO0FI?=
 =?us-ascii?Q?Ma+IkRX82N44kmlRTpcdlWYQQUC2PaBsAxTNv5pS+p55/HukrRVq6Xqefo2f?=
 =?us-ascii?Q?/GxqTOreC4pxw4IbcdDuyIYSWmnzjbv4ub7cxJWh6mB47yw5VDCqOrLh5yyG?=
 =?us-ascii?Q?F7Gy3lu7a8UeWFvwmjx+z5yJ46l9oIJ/njXdfbpfdHURrq6RYWuUmxLrY/d1?=
 =?us-ascii?Q?IvQwTKq1P7yVw4OHOAX5cTSZY5VWr6cnZwsrqmsAd80kw8xy+yBqOXhH9bHy?=
 =?us-ascii?Q?nLEeOBRamGdDyiz00TE2dL2mRwBqreQKPRYLeGY9e3pLjPUOU8F2xPuml6X6?=
 =?us-ascii?Q?XxJijlQ2QDLk7NLdIOEX/Ob3Szy1PBNb/HMgsfVVdloLrJsHP5nOLuroo3um?=
 =?us-ascii?Q?kTKJ0bl1Qx23E9rR/3yvXj/JHoPQDA+kVi3D7FiqdhNJqYp5UO9/bdqQG93V?=
 =?us-ascii?Q?CtWfkKsXU4nh8e55Sxn5N3I/4vHReJRzfHxFKg/7kZA3mjL+GjKc5W0y49et?=
 =?us-ascii?Q?Jm3gyWVUUIBY/TuWUIxKe2LX3jQHAnouX4TQTIkAadA6zCXUOD0+Ng4mP+Y7?=
 =?us-ascii?Q?Mh/QUNOuRdW5nTWORcCA4bIfhEDTSPHPcDsLbgXSHvEpK96flQlCtlw268z1?=
 =?us-ascii?Q?D+kDBMwwakr9cBpUbGwnBalLP6aowW1se+AmJG+DJhbOjxSSJUhtbJS92Ilm?=
 =?us-ascii?Q?oA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <ADCD8F7C2C9E544E9565DDEAFF4FB879@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Io3nW26UXxf8yS2p1ktC4UGkIc/6kkLW+HkkIvsznxLSnfBDZSTz4h6Yj74ilxEcPf1XbkwWTrKh1wZ+xQEDKACCP6H7UWv2YOvn/oRmcfwRHMRuZ8Cypz/naQFKH7YRC3TS5ykDBvPpP/VUeR10zSRpq2SVOc0dF6UlIJCSQgX85H2mms4C1vMp+/2pbIeyi6yl5DPOaYYZvG4T+7/VU/kkF38kurxSn1C2GF2YpFZ0V1JLHuhDuMjV6bI4x0/QlpkAl1t0oJClIT9nxjL/gKgyc5w8JyKLzwXx6O9VHLfMDJyrQ6LYgBdEbU5CZFtpadtGTImRLMsTWQYvxGfhgJrPm09cOKhaAZL3BVgUwkVkEk8xM7aUnrwcEOMIkaCZFF6B3wtSSAFSc/b9mxior5WXrtscW3ukDNiqCTbg+0WUVYAKPK5Ft0zxiDtZeS0zBqIbH4FLussgbk71J06nHpSr8pjxvDi0hN4y5mj3nrsEeQu+j033Wkd6i4xsMNocIqBztdrUymg2phAiWP4SYGvfcN9ddbyJ5Pin8UC4VWw5idRdJb+5dCD6HVVnMWiswrx/YPdR2ceMdSRY4si8sE8S2zGOXhrKyW6I9bdlUf/xvnmP6bcWmk6u9U1eSO0eCdriUg3vZyYFcSlNuCkEMViUHOYRhefpplk4FoHq8wDePkwUIDXMTu4RMyBxUIYhZUVxXeIl+C296r4uUG6jnLRSHqE+JNrB22wfMVtFakz2JdkFx5Qq3tIQJZd24dADwtY86qP6X+0CR9LhrvL9H5J34Rdbl+IBLfelHRgUw8KhgV4Lom2eHAJZb6ShkNBhGoGk1CKEqft5oIe5MmGjzA==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fea062a-8ebe-430e-071d-08db3c272790
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2023 13:58:26.8027
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1QOsRZXkPSfhsv4JCqvaBRQjYkml0ktwpoZTHfgCIn349xBzEvN5/MQrL4FFdzG2Q1tT5KIqBjnk3dmfkuiv2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4413
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-13_09,2023-04-13_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 adultscore=0 spamscore=0 suspectscore=0 bulkscore=0 mlxlogscore=999
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304130125
X-Proofpoint-GUID: dyF0HLjU2Af77YLmc31GpcNetLgwcTWf
X-Proofpoint-ORIG-GUID: dyF0HLjU2Af77YLmc31GpcNetLgwcTWf
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


> On Apr 13, 2023, at 9:51 AM, David Howells <dhowells@redhat.com> wrote:
>=20
>=20
> The usage_data[] array in rfc6803_encrypt_case() is uninitialised, so cle=
ar
> it as it may cause the tests to fail otherwise.
>=20
> Fixes: b958cff6b27b ("SUNRPC: Add encryption KUnit tests for the RFC 6803=
 encryption types")
> Link: https://lore.kernel.org/r/380323.1681314997@warthog.procyon.org.uk/
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Chuck Lever <chuck.lever@oracle.com>
> cc: Scott Mayhew <smayhew@redhat.com>
> cc: Herbert Xu <herbert@gondor.apana.org.au>
> cc: linux-nfs@vger.kernel.org
> cc: linux-crypto@vger.kernel.org
> ---
> net/sunrpc/auth_gss/gss_krb5_test.c |    1 +
> 1 file changed, 1 insertion(+)
>=20
> diff --git a/net/sunrpc/auth_gss/gss_krb5_test.c b/net/sunrpc/auth_gss/gs=
s_krb5_test.c
> index ce0541e32fc9..aa6ec4e858aa 100644
> --- a/net/sunrpc/auth_gss/gss_krb5_test.c
> +++ b/net/sunrpc/auth_gss/gss_krb5_test.c
> @@ -1327,6 +1327,7 @@ static void rfc6803_encrypt_case(struct kunit *test=
)
> if (!gk5e)
> kunit_skip(test, "Encryption type is not available");
>=20
> + memset(usage_data, 0, sizeof(usage_data));
> usage.data[3] =3D param->constant;
>=20
> Ke.len =3D gk5e->Ke_length;
>=20

Many thanks! I will apply this to nfsd-fixes.


--
Chuck Lever