Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3268514rwl; Thu, 13 Apr 2023 19:14:33 -0700 (PDT) X-Google-Smtp-Source: AKy350aCli+MrKINZnhGtRWGm1zCfTyr46lVMLSlomkuylEcFFwRV3cR9UE/en4BNrROYIufR3Wh X-Received: by 2002:a05:6a00:44c6:b0:638:2493:1710 with SMTP id cv6-20020a056a0044c600b0063824931710mr803106pfb.3.1681438473623; Thu, 13 Apr 2023 19:14:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681438473; cv=none; d=google.com; s=arc-20160816; b=Bw7QyZfv0jxmMX9HWxRGsIALhSrhqyCHDrBpRExXfazGIVI7sgqBglrTEyyX0adgv1 RXkB1+6jp+38uc6YbtkSIozjpJWAoRej/cSEtzC0ZXLiX2u2FgpqLtvE0cJNh+mRUGIX QqfyrISoQNkns/M9Wf1TOSX6Xy9Uu1BOvNUrnbSANBc9b2JmtWvQIRdfYsnaQ+puljBp f83t4SlFr50FLHXGIuUymSjT3o46UGnxks6ixl0BJ1Tv1rcad1xtQ+bX468AOsZYkHyy bKeH/1QOKONV0qBXRK+L6SAlGRD34DzbC822Op1TM66P4HOpsJVginsG+rf7MROncI7Q yYgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ygQQXb9rRJXNm2j1F2SX8A/UQ+u9UpSxn42Ls6Hmx0w=; b=uJZ/dqfMiw41wdLT07lmJAo5fGdwml8rGIGVMvJk5zMABdMwur7DNIj6W/cKRLZley 8Hyt7yoFnDIl+FmgjwS67opM9fs0bGZfE7mTxULvoSDZDZsrAZxQcBWNtpTJukRv3ko1 8afHtL29vVD8dJS5kBMKW92E0Hmd+kW1NYr/yHLEe7r7UvooRdstwROnYuyt+RKKdTTm EympQ0JwqBmQFhC+xxWCxvE3HKwpJ3ppOlRP640kDBklLDYqApZWVYfCn+ZvmZHLfvFD eZk99Cf/M0hDPlEw5iHXztlAi47Psb/oC/rr8ykYgvcvJfl7XsPI5yq3G5svSBlK8dEo SJ5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w7-20020a623007000000b0063b2255954csi2899931pfw.366.2023.04.13.19.14.08; Thu, 13 Apr 2023 19:14:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229736AbjDNCI6 (ORCPT + 99 others); Thu, 13 Apr 2023 22:08:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbjDNCI6 (ORCPT ); Thu, 13 Apr 2023 22:08:58 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 262A72D4A; Thu, 13 Apr 2023 19:08:55 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1pn8ri-00FiCd-4a; Fri, 14 Apr 2023 10:08:43 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 14 Apr 2023 10:08:42 +0800 Date: Fri, 14 Apr 2023 10:08:42 +0800 From: Herbert Xu To: David Howells Cc: Chuck Lever III , Scott Mayhew , Ard Biesheuvel , Jeff Layton , Linux NFS Mailing List , "linux-crypto@vger.kernel.org" Subject: Re: Did the in-kernel Camellia or CMAC crypto implementation break? Message-ID: References: <48886D84-1A04-4B07-A666-BB56684E759F@oracle.com> <380323.1681314997@warthog.procyon.org.uk> <1078650.1681394138@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1078650.1681394138@warthog.procyon.org.uk> X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_00,HELO_DYNAMIC_IPADDR2, RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS,TVD_RCVD_IP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Apr 13, 2023 at 02:55:38PM +0100, David Howells wrote: > > Found it (see patch sent separately). There was an uninitialised variable in > sunrpc. Now that you have it working, perhaps you could convert some of your test vectors into crypto API test vectors? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt