Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Stephan Mueller <smueller@chronox.de>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-crypto@vger.kernel.org, Vladis Dronov <vdronov@redhat.com>,
        Marcelo Cerri <marcelo.cerri@canonical.com>
Subject: Re: [PATCH v2 1/2] crypto: jitter - replace LFSR with SHA3-256
Date:   Thu, 20 Apr 2023 13:05:27 +0200
Message-ID: <15434794.O8ra6N0tA4@tauon.chronox.de>
In-Reply-To: <ZEEMK/zlZdz2t7CA@gondor.apana.org.au>
References: <2684670.mvXUDI8C0e@positron.chronox.de>
 <2283439.ElGaqSPkdT@positron.chronox.de>
 <ZEEMK/zlZdz2t7CA@gondor.apana.org.au>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Am Donnerstag, 20. April 2023, 11:55:55 CEST schrieb Herbert Xu:

Hi Herbert,

> > +	rng->entropy_collector = jent_entropy_collector_alloc(1, 0, sdesc);
> > +	if (!rng->entropy_collector)
> > +		ret = -ENOMEM;
> 
> Is this supposed to fail or not?

Correct. Thanks a lot for the catch. I will update this.

Ciao
Stephan