Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     kernel test robot <lkp@intel.com>, oe-kbuild-all@lists.linux.dev,
        linux-kernel@vger.kernel.org,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        linux-samsung-soc@vger.kernel.org,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        linux-amlogic@lists.infradead.org,
        Sean Wang <sean.wang@mediatek.com>,
        Avi Fishman <avifishman70@gmail.com>,
        Tomer Maimon <tmaimon77@gmail.com>,
        Tali Perry <tali.perry1@gmail.com>,
        Patrick Venture <venture@google.com>,
        Nancy Yuen <yuenn@google.com>,
        Benjamin Fair <benjaminfair@google.com>
Subject: Re: [PATCH] hwrng: Kconfig - Add HAS_IOMEM dependencies for
 exynos/meson/mtk/npcm
Date:   Fri, 21 Apr 2023 16:00:30 +0200
In-Reply-To: <ZD+oZ9DWiTxeo3RY@gondor.apana.org.au> (Herbert Xu's message of
        "Wed, 19 Apr 2023 16:37:59 +0800")
Message-ID: <oypijdv8hp49oh.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <ZD+oZ9DWiTxeo3RY@gondor.apana.org.au>
        <CGME20230421140034eucas1p1f74c5d5dc69eea89ca520660b250d824@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2023-04-19 =C5=9Bro 16:37>, when Herbert Xu wrote:
> On Wed, Apr 19, 2023 at 11:43:42AM +0800, kernel test robot wrote:
>>
>>    s390-linux-ld: drivers/char/hw_random/exynos-trng.o: in function `exy=
nos_trng_probe':
>>    exynos-trng.c:(.text+0x39e): undefined reference to `devm_platform_io=
remap_resource'
>>    s390-linux-ld: drivers/char/hw_random/meson-rng.o: in function `meson=
_rng_probe':
>>    meson-rng.c:(.text+0x10a): undefined reference to `devm_platform_iore=
map_resource'
>>    s390-linux-ld: drivers/char/hw_random/mtk-rng.o: in function `mtk_rng=
_probe':
>>    mtk-rng.c:(.text+0x40e): undefined reference to `devm_platform_iorema=
p_resource'
>>    s390-linux-ld: drivers/char/hw_random/npcm-rng.o: in function `npcm_r=
ng_probe':
>>    npcm-rng.c:(.text+0x2ca): undefined reference to `devm_platform_iorem=
ap_resource'
>
> OK, this patch should fix these ones at least:
>
> ---8<---
> Add missing dependencies on HAS_IOMEM as otherwise they will trigger
> failed builds with COMPILE_TEST enabled.
>
> Also add dependencies on OF where appropriate.
>
> Change the default so that these drivers are not enabled just because
> COMPILE_TEST is turned on.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304191106.swKbBeDh-lkp@int=
el.com/
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>

Acked-by: =C5=81ukasz Stelmach <l.stelmach@samsung.com>

> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kcon=
fig
> index ae508e96cfc2..f3146470ce88 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -400,9 +400,9 @@ config HW_RANDOM_POLARFIRE_SOC
>=20=20
>  config HW_RANDOM_MESON
>  	tristate "Amlogic Meson Random Number Generator support"
> -	depends on HW_RANDOM
>  	depends on ARCH_MESON || COMPILE_TEST
> -	default y
> +	depends on HAS_IOMEM && OF
> +	default HW_RANDOM if ARCH_MESON
>  	help
>  	  This driver provides kernel-side support for the Random Number
>  	  Generator hardware found on Amlogic Meson SoCs.
> @@ -427,9 +427,9 @@ config HW_RANDOM_CAVIUM
>=20=20
>  config HW_RANDOM_MTK
>  	tristate "Mediatek Random Number Generator support"
> -	depends on HW_RANDOM
>  	depends on ARCH_MEDIATEK || COMPILE_TEST
> -	default y
> +	depends on HAS_IOMEM && OF
> +	default HW_RANDOM if ARCH_MEDIATEK
>  	help
>  	  This driver provides kernel-side support for the Random Number
>  	  Generator hardware found on Mediatek SoCs.
> @@ -456,7 +456,8 @@ config HW_RANDOM_S390
>  config HW_RANDOM_EXYNOS
>  	tristate "Samsung Exynos True Random Number Generator support"
>  	depends on ARCH_EXYNOS || COMPILE_TEST
> -	default HW_RANDOM
> +	depends on HAS_IOMEM
> +	default HW_RANDOM if ARCH_EXYNOS
>  	help
>  	  This driver provides support for the True Random Number
>  	  Generator available in Exynos SoCs.
> @@ -483,7 +484,8 @@ config HW_RANDOM_OPTEE
>  config HW_RANDOM_NPCM
>  	tristate "NPCM Random Number Generator support"
>  	depends on ARCH_NPCM || COMPILE_TEST
> -	default HW_RANDOM
> +	depends on HAS_IOMEM
> +	default HW_RANDOM if ARCH_NPCM
>  	help
>  	  This driver provides support for the Random Number
>  	  Generator hardware available in Nuvoton NPCM SoCs.

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmRClv4ACgkQsK4enJil
gBDEswf7BMFGz7sr6Hns4MWdMpjlwix4EMNruEIgZGpf/j0cw5+SZJoHq9jbZf3v
qsHL0KO35EJKwGDg/1IeGvhmDVs2H3JaoqrWFcVefd818IyYdYL2J0xJuj5vrkHV
mQxneDpdsLj/L0UHizakKVTAHmR6LvMFU9U+jvgTFTGIRyURJoZaXIrtDJCcu10I
2KCLqggMBlkNp1Pqqc+OhDVlL1lHeOwS9dCt9XkvFANKYDdGoDTIbWb5ripx4zrJ
7CI2ML8j0leEwNwaporniHAtIRyU81UQtdTKILr/GUfmtP340WGqgvt+TwqcGZ38
mnj8IDtWJNNo5MIuDJR5XiDJJMTnww==
=F7gO
-----END PGP SIGNATURE-----
--=-=-=--