Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp537410rwr; Wed, 26 Apr 2023 02:58:50 -0700 (PDT) X-Google-Smtp-Source: AKy350bOjPD218euGPwLis9Ln9vIAO+8s/sgM1UY9Rig8rxxhMjgdTndmHyN+UidVlLf+As1ydFO X-Received: by 2002:a05:6a20:440d:b0:f5:9f72:1aa2 with SMTP id ce13-20020a056a20440d00b000f59f721aa2mr9748975pzb.6.1682503130039; Wed, 26 Apr 2023 02:58:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682503130; cv=none; d=google.com; s=arc-20160816; b=iuDvoqObJpTNRdPUJcsXu0DKU+RPIPTntuxz0Wr1p8h8bzUB/B3gGr8Y6KbSMCIQXq 7YdOpg8y3zeqIwWy2PSTsMr8WdI16pK7Is3vBQRS+BPwYGXq9hSpa2GvCeHHtuoU7duH OHWfnTlf/cbUDUgHEvilbewGcCKLpswk6u/cZYaZsDO2M+C7lGWT59a64d5BDp01Scto kY68a05w9k1EU8QTYkhGdQU7MSTKHRc54s8lTh0+MihAuy+32YVa+r3BlFkgUUZuIIkC 6GFEiFDHGgR7TrJH1Ro3LAianBeFMjoNZ8K3FnP2Wlx0DEx+Bvs/US+rDL02snx0L9bo sNsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=jcEzgIvOABQVnUYKyLWzjigIAuWM5jEZy93DUFYIqQU=; b=nO2XeLGnftkMz+ngMLIu1A+8LgFdZFvCQouOwoPG48F+LFCqV/+ZuArm+pXLDu43dB 1fpfbKgdlGQ5Q9PQzc0Kywaar8zhv9SmIvRrLLb/S4LtNOue23RmAAHACG4PwAElvWcW b4YzyXNC6TptW9zEUK/rA1ty0lxHytT7Kq+uU27TAwO6LMwDcvbEJSNobZe7TWEAq6wn W6K8Th8bmRySTBlkbid4wEvpIp6eNfEmXWSNLc7vAEZKRLBCaasWC1P4ybR7Z1cNmjBK wC6v6X2ELxNrnoGp/v4AhoDRD4BBApEbUZ17n9YtCKU6cYsYiavHpySgvyQsTIoa8/+F qjVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l63-20020a638842000000b00513f15fed4fsi15817127pgd.590.2023.04.26.02.58.33; Wed, 26 Apr 2023 02:58:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239464AbjDZJsq (ORCPT + 99 others); Wed, 26 Apr 2023 05:48:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240281AbjDZJsp (ORCPT ); Wed, 26 Apr 2023 05:48:45 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B94A32726 for ; Wed, 26 Apr 2023 02:48:43 -0700 (PDT) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Q5vBW3zdKzLnl5; Wed, 26 Apr 2023 17:45:55 +0800 (CST) Received: from [10.67.110.176] (10.67.110.176) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 26 Apr 2023 17:48:39 +0800 Subject: Re: [PATCH -next] crypto: jitter - change module_init(jent_mod_init) to subsys_initcall(jent_mod_init) To: Herbert Xu CC: , References: <20230425125709.39470-1-cuigaosheng1@huawei.com> From: cuigaosheng Message-ID: Date: Wed, 26 Apr 2023 17:48:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.176] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Submitting patches directly to stable branches will not be accepted. Maybe it doesn't need fixing,we can also compile ecdh into modules to get around this problem. Thanks for your time. On 2023/4/26 17:26, Herbert Xu wrote: > On Wed, Apr 26, 2023 at 05:18:11PM +0800, cuigaosheng wrote: >> Thanks for taking time to review this patch. >> >> We have not used subsystem initialisation ordering to guarantee the >> order of registration since commit adad556efcdd ("crypto: api - Fix >> built-in testing dependency failures"),but this patch is not a bugfix, >> it's not merged into the earlier stable branch. > You're going about this backwards. We don't apply patches to > the mainline kernel to fix problems that only exist in an older > version. > > If you have a problem with an older kernel then you should fix > it there. > > Cheers,