Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7f257119-339b-1d42-4252-181f9666d78e@infradead.org>
Date:   Fri, 28 Apr 2023 14:00:02 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v3 15/15] crypto: iaa - Add IAA Compression Accelerator
 stats
To:     Tom Zanussi <tom.zanussi@linux.intel.com>,
        herbert@gondor.apana.org.au, davem@davemloft.net,
        fenghua.yu@intel.com, vkoul@kernel.org
Cc:     dave.jiang@intel.com, tony.luck@intel.com,
        wajdi.k.feghali@intel.com, james.guilford@intel.com,
        kanchana.p.sridhar@intel.com, giovanni.cabiddu@intel.com,
        hdanton@sina.com, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org
References: <20230428205539.113902-1-tom.zanussi@linux.intel.com>
 <20230428205539.113902-16-tom.zanussi@linux.intel.com>
Content-Language: en-US
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230428205539.113902-16-tom.zanussi@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 4/28/23 13:55, Tom Zanussi wrote:
> diff --git a/drivers/crypto/intel/iaa/Kconfig b/drivers/crypto/intel/iaa/Kconfig
> index fcccb6ff7e29..cffb3a4359fc 100644
> --- a/drivers/crypto/intel/iaa/Kconfig
> +++ b/drivers/crypto/intel/iaa/Kconfig
> @@ -8,3 +8,12 @@ config CRYPTO_DEV_IAA_CRYPTO
>  	  decompression with the Intel Analytics Accelerator (IAA)
>  	  hardware using the cryptographic API.  If you choose 'M'
>  	  here, the module will be called iaa_crypto.
> +
> +config CRYPTO_DEV_IAA_CRYPTO_STATS
> +	bool "Enable Intel(R) IAA Compression Accelerator Statistics"
> +	depends on CRYPTO_DEV_IAA_CRYPTO
> +	default n
> +	help
> +          Enable statistics for the IAA compression accelerator.

The line above should use one tab + 2 spaces for indentation
instead of bunch-of-spaces.

> +	  These include per-device and per-workqueue statistics in
> +	  addition to global driver statistics.

Thanks.
-- 
~Randy