Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d886d1dd-51c8-d2e6-940b-9e5041707c6e@intel.com>
Date:   Fri, 28 Apr 2023 17:14:36 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v3 01/15] dmaengine: idxd: add wq driver name support for
 accel-config user tool
Content-Language: en-US
To:     Tom Zanussi <tom.zanussi@linux.intel.com>,
        <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
        <vkoul@kernel.org>
CC:     <dave.jiang@intel.com>, <tony.luck@intel.com>,
        <wajdi.k.feghali@intel.com>, <james.guilford@intel.com>,
        <kanchana.p.sridhar@intel.com>, <giovanni.cabiddu@intel.com>,
        <hdanton@sina.com>, <linux-kernel@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>, <dmaengine@vger.kernel.org>
References: <20230428205539.113902-1-tom.zanussi@linux.intel.com>
 <20230428205539.113902-2-tom.zanussi@linux.intel.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20230428205539.113902-2-tom.zanussi@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTh2RUdFWGRXYzF4cEljb1gxWXNhSVBUN1hTVEtkb2hNU2RTc2NKcHdXVnVM?=
 =?utf-8?B?TnczcVA3QzdoRjAxcGV5eXdBZUFHZldPS0p4RXF0Ym5jbVVWcnNDU1V1dzI3?=
 =?utf-8?B?RTdGaExoMjdIcmRPaCtXYlpZSndIeDRWU3kvWUlpN3p1dXhKblRVV1RMV0dj?=
 =?utf-8?B?SGZ1RXlJZHVzaHdxY1Z0cjVYYW4zOTJiR3N2bk9tOWV5WWJCVkxKTnhBdnRW?=
 =?utf-8?B?VHBmQjd0TU41VGlJOXJCNjlPWkx1YmNwUWZCNko1ZkcwR21ORGpodHFUdmNr?=
 =?utf-8?B?M0lXMEt0bEN6YlZmQUZpQWxha2thMWtyRGFKeFpQUk5xUlJXOVFwektqVjNx?=
 =?utf-8?B?bmR5cnpVWnB6UTV3QkdXU1NHUkNoalZMRGFXL2U1a05yQXJ3QzFVclpTYlJK?=
 =?utf-8?B?aG1ZTGJacVh5N3Yzc1p4OVpnL05SRHplMGtpaDExdUJEeWlOUUI1RUQ2VXpS?=
 =?utf-8?B?YjM0Sys0OEgyZWhRYXFSVXorM1ZmbDFFM0JocGthc3E1RG9xV2hraitpczRj?=
 =?utf-8?B?NE5uS3U2cW0zMFNWTFcydFBTZE1XYlNzZEJLbFlaa2dkSVNRd0w0Zml3YkV0?=
 =?utf-8?B?bmVaY2R4NExhWTRnbEVkcWN2anE3NHZ6RW5qcVA3MldKU21hYnRPeFA5T2Vw?=
 =?utf-8?B?ODQwVm9SYkJSTjFuWmZJOS9QVS9EenREQWNGbUw2Z0V5T0M4dnJYZ1VMaFlY?=
 =?utf-8?B?YzIyV0ZoOGc5dVphL01OZEh5d1R2c1NSMzBmVkQ5VFVuZjlEcXBZVFNWV1BL?=
 =?utf-8?B?L25uR1hyV0xINXg4TmZuZmg0L2h4cDNjcTFCb2pnQ01mZm5ZYjBrSngzcVBX?=
 =?utf-8?B?VHZOazJVL3BzNUs1R0x1Njh2WTVmTzBGem1kSWlpOVo0aTVkaGNJam5LOG41?=
 =?utf-8?B?MkNUS2t6ZStWTGErY0JEbFdrcUtPa24vZEt1cmViMzdlSmNRcDRGeUozeDNp?=
 =?utf-8?B?NWFyRXQzNm45bUJyTTZTV3hPQUxveVQ2U09QWnlSalVoVW4xcTAySlRJQVlP?=
 =?utf-8?B?YVJqU1U0Uk9aKzM0dmZUbkdzdUpyeEZjdnIzc3FqZm40U1JWamQwK0VoTGxP?=
 =?utf-8?B?UGtGTktSZjVuL1p1T1hEY3k2Tm1rUDBKUXZkK3ZRTWxFQjBFeVhwWER2TWE5?=
 =?utf-8?B?enJYdWlacEtqZWpzaUJMTjJ0U090NlRsYXZFRkZIekd0Wk5oTzVtOTFzU25h?=
 =?utf-8?B?YU1FUHFVVHE3dU5xN0E5WUFBc0VxaFJ0MVlYTElEekxKdXpuZThKcU9QQXl5?=
 =?utf-8?B?V3V0QlVyQytFOUFGUURPV0t5VDIxUEc4NTAvb0F0cWRrUUpoclVNeDRFOFI5?=
 =?utf-8?B?UWJITHpuazJ1YWovZVc2K25rYnJibzdNbmdVNjVGNXlBdkJaZ3RkRHRWaG12?=
 =?utf-8?B?NjRpcnNGVWw1b2VSaTB1WjJqNnZwYjdXTWFGWFgwMFNLNG5xRC8rTnZRS2Va?=
 =?utf-8?B?b0dQbkJ0ejB1SnRMTTF0M2JjcmRQVDVaNzZnTStuUWpjc2FrRXR6Y1R1QTQr?=
 =?utf-8?B?VFg1dmpiV3UwOUtWZXB1cGY4UXVKY21KRkhKRHY5Qkc0VXZzOHUyMytRZWp0?=
 =?utf-8?B?OGpKMXBZeWliNmJqeUo0SGVJUVBQM25TK1Q0QmtuNm9Rb08vVzFpMzlCTWJC?=
 =?utf-8?B?NTU1WVF4OS8rZytkOUdWZ1Q4UEJGa3hkK1BlSnRrYjc2c3E2Y0FZVmNEeDVt?=
 =?utf-8?B?K0Mwc2Q3UkROMmdzWk1GK1hFZE9zWGtuZWthTXJaYXJyeUJKd01EQkdvTThP?=
 =?utf-8?B?UTJObUlLam5uK2V0MnRZVlgveU5iSGdjMGJaME1VMUJOZWVoU2VIWVlQMVFo?=
 =?utf-8?B?eWJ2dlp2cHRjSnFXME14aHVrdVd2VzFRbFVIODAwNzU3MGR2VFdVT1RGdjNF?=
 =?utf-8?B?TTlCZm9KSERPL1o5Y2NJcjdBQnFNdUtFR2V4dGsvWkRKMENrdldiemdxazRn?=
 =?utf-8?B?OFljb3Z6T2VlN0c3L1ZPSTRhVVY2Q0tLd1hwd3JERFBtY0wrM1FRR0E1UStN?=
 =?utf-8?B?NWw1d3dBMFJEbkJpaWo4NmpuK3ZXMXJac1phRWUwRGRtRzdtZGYxUytLRGVw?=
 =?utf-8?B?UU5tMHN3MGQ0VlBMc0xKMjRLdHNBeTMzbDlZOWNwcEdoYVRYTGNxNzZHMEpS?=
 =?utf-8?Q?wn9vMGN83L9+v3JZeoOh6bMsF?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d78147b-0654-4e70-bb83-08db4846ab70
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2023 00:14:16.6508
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LpcCgUe9lxRFwtTh16PNF0wGoaNoQmINw4TyTJrNzHfQ1rBoc0KEKujOrDwuV1DMLlsNLl2si1E+ChRHtkijyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6683
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi, Tom,

On 4/28/23 13:55, Tom Zanussi wrote:
> From: Dave Jiang <dave.jiang@intel.com>
> 
> With the possibility of multiple wq drivers that can be bound to the wq,
> the user config tool accel-config needs a way to know which wq driver to
> bind to the wq. Introduce per wq driver_name sysfs attribute where the user
> can indicate the driver to be bound to the wq. This allows accel-config to
> just bind to the driver using wq->driver_name.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> ---

...

> diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> index 7ced8d283d98..505118fc19de 100644
> --- a/drivers/dma/idxd/idxd.h
> +++ b/drivers/dma/idxd/idxd.h
> @@ -214,6 +214,8 @@ struct idxd_wq {
>   	char name[WQ_NAME_SIZE + 1];
>   	u64 max_xfer_bytes;
>   	u32 max_batch_size;
> +
> +	char driver_name[WQ_NAME_SIZE + 1];

It's confused to use "WQ_NAME_SIZE" for driver name size.
Maybe it's better to have a new definition "DRIVER_NAME_SIZE"?
BTW, WQ_NAME_SIZE is 1024 which is unnecessary big for storing 
driver_name[] in the structure. It would be better to have a smaller 
size (e.g. 128) in DRIVER_NAME_SIZE.

Thanks.

-Fenghua