Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp2922845rwr; Fri, 28 Apr 2023 19:41:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ck8hsQ+UNuZfgxuQltB6ZSOoeFtDR2mpnP/VqFVFW06Z5fZTqDYo8Zc8BXNWVgKmPMgEP X-Received: by 2002:aa7:88c7:0:b0:63b:8cbc:bc0f with SMTP id k7-20020aa788c7000000b0063b8cbcbc0fmr10796051pff.22.1682736076861; Fri, 28 Apr 2023 19:41:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682736076; cv=none; d=google.com; s=arc-20160816; b=CqXDqbZW0QLNLEcWBSLVszRsAGKP+3D0GtJ4hl5/RPHLytTohmJvaU8joiy0r9Soj4 dZQkhc+9fiuVO7myz4dtSzPyg/nvRPdpykQFcoe3CDqs/upV7uGomFYkArhhBknYLUZp GTMA7dRolq23cTdW/VITxwqgI6rb/KE0Xx5sQoL9hADRh89yxyHL7i6I/BZTGMlG8PLu q4wxzhcJJNkOGM6cNulXMlbB4lAKkxE6Mmrcp4w6jjEvo9U0yWF9S899FAneeztdBLZ3 bA/rDE1FGjg7l3khbGILgpo08Vo8WqfqwZg059eT27Zw/5CzjcLLUGlObELLdBZWpQ9T bxJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=+VbzhKX8KyWXXSbsbGtVXK/3HSJI8EHHi0iaF6HDus0=; b=CvJQzJWKRx0RaCbFPRpy818/r5bcTRtFquqXV7RqcFjILIBNKCrKpx6+2t+4KDevob usvGI4vopnxC4din0YbKPnMVXfPaKK1kU+Z2jSxQaQEFyCFOTZYIOJwdhTBNsLTOPRvn C14Y1PvTTbx4KP1M9kcvBxUWU82qs1Kvkw7vkSbZuT995OKFhrqnt2Uj2akLE0nYyXbV 8R/xj783+bcV7OjG+5FHbzAa1uTfuLLGBVsTuzQyFE8ExfbsJX18H26FLDteaAVbzI8T 4IhwfTPdpPFkW6N2Bz0VuR4Y6SB+2qCHPeHA1NEasnpamPef2a/npCoZcgRqSbct1rXt jMlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=ku47PZtJ; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e3-20020aa798c3000000b00638f2eb16f9si22803616pfm.343.2023.04.28.19.40.53; Fri, 28 Apr 2023 19:41:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=ku47PZtJ; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230249AbjD2CVJ (ORCPT + 99 others); Fri, 28 Apr 2023 22:21:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229940AbjD2CVI (ORCPT ); Fri, 28 Apr 2023 22:21:08 -0400 Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A54421FDB; Fri, 28 Apr 2023 19:21:07 -0700 (PDT) Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-549d9c2935fso329124eaf.2; Fri, 28 Apr 2023 19:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682734867; x=1685326867; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+VbzhKX8KyWXXSbsbGtVXK/3HSJI8EHHi0iaF6HDus0=; b=ku47PZtJcy5ST8LFXA0TA3wTiFinOlI0dsiopX2V20ErUzUGQo2sBs2NsB6CiOo/lE 5cwWh+mMqvjeSlrxHpB0VEBO6F+0Omgbyk/K8710zsE3XZL4kRlswv0wnaI59vIUf583 s7l7BGVJBa4nIkiH8d2r62/scAQgR1uKptXg/LFMH0gU5DALVj9/B/EXtGzIcVEVT4P4 JYvs7chDtttmwsUMXhd19C3OIKZrS6lvo0ZLBbBRzyaB8eDPN+lhCCpHxyyckJwn3oLV HFplcWB4hTwhKgptePg/ORFeM/wijSLFOgv/frCojt2f92exbdg6JOM9+m5FKVDUctRI sbkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682734867; x=1685326867; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+VbzhKX8KyWXXSbsbGtVXK/3HSJI8EHHi0iaF6HDus0=; b=Q0dxq8oLKCashDqphudm5x7vjPyG3yXcGAjyjqd07CSgBHt1+KNnHqmp0QZzFQ8JEm SfurRu6IRSnl32AHwTQ/5pwWsF5SmlWK6MA5tP9jlTqP1mbN9VFaBLWZWsQF7Sen2+jt a29qRSept2BiF9BGk5NsYSEXYmJQcXHVZTNYrsLhoewVxHHQJF6xIPjDyJF9uMMGF72R R5MRU/aTXPQdbwyaoQchcCCFYr6+ND9Z9P0n2LmDdtD4AsPVG0HZEEK53VIKxdEOSZv8 D69WG5Xvt419Sb1JENDCpEsD6/pZn/j79bYDAvoPRESFz7q/XkxyE2w0rPLLahNMRhc0 IhaQ== X-Gm-Message-State: AC+VfDxqwZfhZrPJUzigE666AXqH6Lb96UU2Py2Gjg5kDGuVV0gozZdy ugiry9RnW68HB8u3JlgeP8uk8NBzf/gf/97dX1q0LNFkzt7rmNyB X-Received: by 2002:a54:4490:0:b0:38d:61e9:12cd with SMTP id v16-20020a544490000000b0038d61e912cdmr3655317oiv.21.1682734866902; Fri, 28 Apr 2023 19:21:06 -0700 (PDT) MIME-Version: 1.0 References: <20230428110058.1516119-1-letrhee@nsr.re.kr> <20230428110058.1516119-2-letrhee@nsr.re.kr> <20230428232938.GB3150@sol.localdomain> In-Reply-To: <20230428232938.GB3150@sol.localdomain> From: Letrhee Date: Sat, 29 Apr 2023 11:20:54 +0900 Message-ID: Subject: Re: [PATCH 1/3] crypto: LEA block cipher implementation To: Eric Biggers Cc: Dongsoo Lee , linux-crypto@vger.kernel.org, Herbert Xu , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, "David S. Miller" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Thank you for taking the time to review the implementation. I appreciate your feedback and will respond to other reviews soon. As you mentioned, I agree that using loop unrolling in generic C code can be unnecessary and make it difficult to verify against the original paper. Additionally, I acknowledge that the submitted code may lack sufficient comments. I'll follow your suggestion and re-implement the code. Thank you again for your review.