Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <348157d8-f3dc-6894-2bad-6d2a85cf879e@amd.com>
Date:   Mon, 1 May 2023 13:47:08 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2 04/10] crypto: ccp: move setting PSP master to earlier
 in the init
Content-Language: en-US
To:     Mario Limonciello <mario.limonciello@amd.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        John Allen <john.allen@amd.com>
Cc:     David S Miller <davem@davemloft.net>, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230428185543.8381-1-mario.limonciello@amd.com>
 <20230428185543.8381-5-mario.limonciello@amd.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20230428185543.8381-5-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVhXMmJjb0FNUlF3b2RWbjE2bjFrY1JEYk4rbGlFYUp3NjNZNWVxNkpkMCt5?=
 =?utf-8?B?RXRZRnh2eU0wOWNBZ0F4eVlIR0RIUncwT1U0Q1kwa0NvNlNMYkFjL2hBYWd2?=
 =?utf-8?B?VEJManVlTC94V3hnUzVDcUN0eFZhYWd0azdpWkpMUnk4U3Y1KzM5eDd5MENo?=
 =?utf-8?B?dlBnZi9hMXlJZWRYcGwwaVFUME5hd09KTUJzOG1mU053c1k1TDYvcEtrSlQ4?=
 =?utf-8?B?M01tRS9UeTFmb3A4VjliaXRNZmhTSUZaWlBFYWdROHRJRGw3TktxMlFLNk43?=
 =?utf-8?B?NXFnTGZ4NU9qTFVUZkJFZ3ltTnlZa2lRNG1Jb3NRUGpuazdIODZaVHFwenVi?=
 =?utf-8?B?RmxzeHJnRGdvS2FNc3NmS3A1eFVINXQ5QnpOWDJldGlXRDJ2YTA4RUM4WWtD?=
 =?utf-8?B?Z0UweEM3UHhoMjJBZjh1OStMdVdDSmRhMVR5by9Ja3BKTjAzN1BRb3d1UFZm?=
 =?utf-8?B?R2FUVGhTWThwVUM2SmFsMXNDeEVQM08xVWJ5ZHNMSEVWbVVyWllSWHg0Z2lH?=
 =?utf-8?B?TGFCR0YxcGg0TXgyNGJxbVVIZ0FxOWNlT0tSSWdYeEpmeURoS2g1ZmpYOExI?=
 =?utf-8?B?VUtrRk1qMC9nTlR2TGgzSWhZVXJzVC9rVGp5bU9BeFhmejhYOUFxSGhBRHlo?=
 =?utf-8?B?K0dITEJJUGtlRFJJbTlvWkZNOUVEM1dOY1VzMmp3WldEWHBLMDBuTXMvVGx5?=
 =?utf-8?B?TUtNZWV0ZXZUWFo1K20rMmtaeUYwVURzZTRqalArdnZJRUQ0RjI4TE1hNTBJ?=
 =?utf-8?B?amtwbGVTSGQxUzhEckFtajlnY3lWQjYvRkZpaW9EbjBjdWxmdTFncDQwNXNa?=
 =?utf-8?B?aC9RcnVPSEh4Q3FsbDU0OE5BYVBBNlcrcmVDZHBmM0NxaTllbWlUWVV1TGJJ?=
 =?utf-8?B?dG9JSmJZeWZZaU5iUmRuUE1uQmUwZVhmbkNzWjBmc2E2MXN2emhHU0t5UVN2?=
 =?utf-8?B?dHBhckhDWmg2eHFQcG5uZTR0NVZ6WHk2M09mOCtZSjlQdXFlTURiL3BHOEN6?=
 =?utf-8?B?UHA4MlVlaGwxaU5Ub3ZBQ2dndWtVZDdwK29NNWpVQ0dPK1BqNjZ0SjlBSVdi?=
 =?utf-8?B?dGZXOVFPTkE2OU9VWFBnanVKY2tOMGxYWjNmYnZMMDhqNER3TUJUNEwrS1B5?=
 =?utf-8?B?QXVNZlZWTUtnbDFubjRpR1BXNzFGL3RMMEN0UnJVQW1OSEltd2NTK0hROXF4?=
 =?utf-8?B?cGFUcWxyQVRkekY2VmxSeVVJNGIrcDVUZTNtd3FUNjkramdYQnloMEZYMm8x?=
 =?utf-8?B?ckNzK1lhdW9PaCtUQWRaT29SNGs4R0FuZnZsbStSZ0U0b0JYdmhUeDVDS3BG?=
 =?utf-8?B?ZjZGcGo0TG5nQk51TGo4aU9rK1JxbWc1QXZUZ3l3NHpXeWphZHNJVThKTU9S?=
 =?utf-8?B?amJSUzYzSTN3R0E3cDJoaGRoRlNZNHlxK3BUWk5EMDJZTFB1TlVtZ1Vpd3Jy?=
 =?utf-8?B?RjhlVmE3ZEJQMzJUWXRwOFBwMFVJRkRmZXBFRHVjUXkyMEpETk84RDFlT1My?=
 =?utf-8?B?S1FReE1wY0RBTXdlc0g3UzFTdDlhZmt4a3Z3QzVHeExoaVdzd3hJemN6dHNY?=
 =?utf-8?B?UHVPMFZTcDJ2ZGlrRzdNN1h2LzI0amJaMHc4WXY3cFRyMUcxbUF0Rmorb2kr?=
 =?utf-8?B?OVVBcmtnd212eEdHNWREL2xjdGhHdW92RldWajhyV1VMOTA5cTVRandpR240?=
 =?utf-8?B?WE5PLysxRWJUclBGbVQvRkpJajJyaXN5RmdsZC9lSkI2V1FhVVpVN1hCU25s?=
 =?utf-8?B?QU1zYU5UYlhmY1NLc05lL0R2MWtrdmNRRHFYZTJXVSswc2duV1JiV3pNZ2c0?=
 =?utf-8?B?KytYY1JvZ3k1ODgyUkJnL3pibEh2STlOQzlIVWl1a0NQY0c4U3JhYU1seStn?=
 =?utf-8?B?NnF2ZHF1L0JWQURrcVBJOXhKZnVxa3hYMXdUNWxnVG9kS1YycmlqNUZlSFVZ?=
 =?utf-8?B?M0k1TTJGLzVPYStxZHEzOFYzdGcvVk9XR1h1cUVxQ2wySjhJZW9LVWVucktx?=
 =?utf-8?B?ajV1NlpNdkVPS2tkV3ZnMFQzVTFWa3c4ak9zWXdnWEN0WlpTWi9mUit3ekxZ?=
 =?utf-8?B?OWdsV1RWbHpRYnFHNE9jd1FGdnlFU3hUWnp5ZzJDMG1rOVV6eVY0YzdSd0Vl?=
 =?utf-8?Q?CTHEIUv5B+UyBs7Ku1D7UpgOl?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92684161-38b9-442d-dbe5-08db4a747913
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 18:47:11.2768
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7AadhE6yTZzXqsQEWg4Tl9ncpgXP/7OB+w/oUQ7MoxzsQh/v1uui1h8Fhk8aW/NsSNpQXYmWbueqdcnH1Rd4XA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5411
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 4/28/23 13:55, Mario Limonciello wrote:
> Dynamic boost control needs to use platform access symbols
> that look for the PSP master as part of initialization.
> 
> So move the PSP master before psp_init() so that dynamic boost
> control can be initialized properly.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   drivers/crypto/ccp/psp-dev.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c
> index e3d6955d3265..e9136e398174 100644
> --- a/drivers/crypto/ccp/psp-dev.c
> +++ b/drivers/crypto/ccp/psp-dev.c
> @@ -173,13 +173,14 @@ int psp_dev_init(struct sp_device *sp)
>   		goto e_err;
>   	}
>   
> +	/* master device must be set for platform access */
> +	if (psp->sp->set_psp_master_device)
> +		psp->sp->set_psp_master_device(psp->sp);
> +
>   	ret = psp_init(psp);
>   	if (ret)
>   		goto e_irq;

If psp_init() fails, should we check for and call clear_psp_master_device now?

Thanks,
Tom

>   
> -	if (sp->set_psp_master_device)
> -		sp->set_psp_master_device(sp);
> -
>   	/* Enable interrupt */
>   	iowrite32(-1, psp->io_regs + psp->vdata->inten_reg);
>