Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <40de89f7-a87a-283d-9da0-d0681d12a541@intel.com>
Date:   Mon, 1 May 2023 13:48:39 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v3 07/15] dmaengine: idxd: add callback support for iaa
 crypto
Content-Language: en-US
To:     Tom Zanussi <tom.zanussi@linux.intel.com>,
        <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
        <vkoul@kernel.org>
CC:     <dave.jiang@intel.com>, <tony.luck@intel.com>,
        <wajdi.k.feghali@intel.com>, <james.guilford@intel.com>,
        <kanchana.p.sridhar@intel.com>, <giovanni.cabiddu@intel.com>,
        <hdanton@sina.com>, <linux-kernel@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>, <dmaengine@vger.kernel.org>
References: <20230428205539.113902-1-tom.zanussi@linux.intel.com>
 <20230428205539.113902-8-tom.zanussi@linux.intel.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20230428205539.113902-8-tom.zanussi@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzlTWFkwS0FGZ0xzMldRZElkZVdPOUtMNXRlOFZGb0JSREw4S1pTcDB1QjAy?=
 =?utf-8?B?VFNaQytqRUViRnUzOXgwNFZNZysrMFFNYjNRL2pTeUJNamZlK0JQSkd1SFdI?=
 =?utf-8?B?bExtcXBrdlppZEZUV1NSSGg2Q2VhZGdZZXYwZDFWc3hnaFQycTZ0em1SUUVL?=
 =?utf-8?B?SkxGNTBaMUEreHpsL3BpQThOTWZSYmI1b2cxeDdQQVNGWHVzUmI4R1RySzhI?=
 =?utf-8?B?aENmcEJneTJka2xFWjNOK2NaZFA1eHl2b1BlcWpOMFpiWVVISllFMXQvZ09m?=
 =?utf-8?B?M1RlMFYxRi9BT2tVRTVtN3RMZU5iUURJVjZjUUJBOWxDLzRZMzZkS3huUEk2?=
 =?utf-8?B?ajQ4dERxck5jdG9XdTNWUFF3UEtEZmxHMEJyamRxbVRQdHlOcW5qelpmME1a?=
 =?utf-8?B?ek1QelpBeVB4MGVuTkZaYUFhYng3dmZCZ1hKMmc5T0pvVm5xaXpreVowU1RR?=
 =?utf-8?B?OWR5UW8rUkpMZjNiQmdpLy9sVERldDZFeUUwc28xU25zWWo4Rm91QjE3RkxH?=
 =?utf-8?B?cHJ0TFRUNFo5Q054TW5MbGJweGdURmFUY3BhRjFGdDdYa202Tlc3cDlzbGZk?=
 =?utf-8?B?ckg0VzJwd3BqUXZmYXhxb29hZnNHRVlPNG5zWERTdzRVc3BVYmVIdWI3cTNp?=
 =?utf-8?B?MXRwbXhqd2k0UE9VTlVHcDNiSlRxRVVkcXRWYTBXNWRiMEFqVHlpd1ZLVEtx?=
 =?utf-8?B?RjhtbDVXbkloMUhKTnQxMmRYYWpGajMvNUpsMGoxc0hKb1R6RDVjYUxBZ1hh?=
 =?utf-8?B?UWNVTkJmNVk2SUN6eFlGRWlaVzVhZjVxcWg0eXdld2xMM3g0aDZMaG9DektE?=
 =?utf-8?B?MWJvK0JlcjVCWmZXNG9kWjIxTmttbitMdUlFTHZvS1VKQkxMQlJBYUdmaWxL?=
 =?utf-8?B?b09Ec2ZsbUdxVGdlSDd3b0NWeUhZUXppNW5FQTRaZjV3TXZ1VDhKTm9ab3Vn?=
 =?utf-8?B?THpEam9wdmUxRUVORG5obXpkaVlUK0p6M05oSzFoemt0K21mc1MzZjB5cTNY?=
 =?utf-8?B?UmtsUFJ4RVZWT3B4NmR0bzFrcm90OEJFSkh1aDE0WmdReC9qUEQ4alNzRHZz?=
 =?utf-8?B?d2xlcS9MUHdIN1VUSXdCZ0Z1OG8vdVJzR084czlnRUN0RlM0L1F2cFo2NUZT?=
 =?utf-8?B?cE9GcTgyVEVKd1JtcllSdE9pYzVqMFRtSFpoMjJFU3pGNyt4RFhMUkYyOEdJ?=
 =?utf-8?B?UXdVK0w3M1J2ZSs3aVUwejNvdFo4VnM2T1V4NGxlNk1yYzh2V0VYY0k3VE9H?=
 =?utf-8?B?UVlIU2lPYllrM1UybE0yWUpJSzlBVVBBMjdSSkRpT0tlNGRGa3JaY1NRL0JI?=
 =?utf-8?B?NGVWY2cyclpVK0FONmVLMndaNHo0cU12b3luakFreE1HSldESHBwVFc5TlRH?=
 =?utf-8?B?Z1NyanUzeThkYVRtVk1XT080TzFJTTZwRTBUZ0toWnpJZE05OExPeTdhRGRq?=
 =?utf-8?B?OGpzTDFuY2NiV0IzVkQ0dkhyZU94UXRaNjFVSzZPbUJkeDQ3c3hMazIvWVNo?=
 =?utf-8?B?MlJ1NUlPNVU2Qm1MV0I2TURISHNqbTZWREx1RkU5bVA5ZnVxcklFeDN1K2hy?=
 =?utf-8?B?d0ZHU01pblJmbWdoUGowVmkvaFhJclBoR28xRzY0R3VMY1dyaDFhYk44clRK?=
 =?utf-8?B?WnFIQUgvSytTSGdnZW04SzBMOVdWQ3RDRUt2YlNpSFRyU1dYOWp0U1d4My9E?=
 =?utf-8?B?SlZGSHI1Lys2UnU2bTk1cFZ4dWQzZzRNcEVIZFpHd1FtUTlMTklSU0VQa2Zk?=
 =?utf-8?B?UE1zbElXSS9ZU2E5c0EyR2Z4cENZNlpnZiswT1NVY3ZYK21iWGdhTUdBSk1j?=
 =?utf-8?B?QTMyaTlPbEVoTTZaK3BBUEwzaFJSaTNOWjNXOFNYWENIb3hUNy9MY3dsV3JL?=
 =?utf-8?B?dWh6SFdNamorN1dub3cyZHB6bmNWcTJYSkp1MXJ5RzBmdGlIbXhpaEFycXF1?=
 =?utf-8?B?VFc5VzBqa3ozWi9zdERvSklsMjExSVRHc1h3TVNlRGM3YWNWQ25iME92TXVY?=
 =?utf-8?B?aXhQWXo3Y2ptVFBTSyt5OG81SFdjeXMzNlZ0cGY0N3dvV0pELzJmZ1RBc1hj?=
 =?utf-8?B?ZnVaMHlXNG5ZaWFPZzBZTzc3OThQcER6SERWaVNZcUorMkY3Y1V5eEVwdkFY?=
 =?utf-8?Q?dnZfa8dmYSqQTviNB2+OYP9cU?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e6b79e8-2ce1-4473-1e33-08db4a85651a
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 20:48:19.3605
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uyRSg+RK8oFA4WFCqZCSMegxCSw4vuGL9/rrxkv9wOzbjjMe0M6XDKW8itDhEJ4Qyo03M6uy35hn0HgQHFCXhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7863
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 4/28/23 13:55, Tom Zanussi wrote:
> Create a lightweight callback interface to allow idxd sub-drivers to
> be notified when work sent to idxd wqs has completed.
> 
> For a sub-driver to be notified of work completion, it needs to:
> 
>    - Set the descriptor's 'Request Completion Interrupt'
>      (IDXD_OP_FLAG_RCI)
> 
>    - Set the sub-driver desc_complete() callback when registering the
>      sub-driver e.g.:
> 
>        struct idxd_device_driver my_drv = {
>              .probe = my_probe,
>              .desc_complete = my_complete,
>        }
> 
>    - Set the sub-driver-specific context in the sub-driver's descriptor
>      e.g:
> 
>        idxd_desc->crypto.req = req;
>        idxd_desc->crypto.tfm = tfm;
>        idxd_desc->crypto.src_addr = src_addr;
>        idxd_desc->crypto.dst_addr = dst_addr;
> 
> When the work completes and the completion irq fires, idxd will invoke
> the desc_complete() callback with pointers to the descriptor, context,
> and completion_type.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua