Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1b2eb485-2320-b33b-a0ac-53f7cb170adc@intel.com>
Date:   Mon, 8 May 2023 11:18:24 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH v6 07/12] x86/cpu/keylocker: Load an internal wrapping key
 at boot-time
To:     Eric Biggers <ebiggers@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
        <dm-devel@redhat.com>, <gmazyland@gmail.com>, <luto@kernel.org>,
        <dave.hansen@linux.intel.com>, <tglx@linutronix.de>, <bp@suse.de>,
        <mingo@kernel.org>, <x86@kernel.org>,
        <herbert@gondor.apana.org.au>, <ardb@kernel.org>,
        <dan.j.williams@intel.com>, <bernie.keany@intel.com>,
        <charishma1.gairuboyina@intel.com>,
        <lalithambika.krishnakumar@intel.com>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>
References: <20220112211258.21115-1-chang.seok.bae@intel.com>
 <20230410225936.8940-1-chang.seok.bae@intel.com>
 <20230410225936.8940-8-chang.seok.bae@intel.com> <ZFWLoOZZTnBrid+7@gmail.com>
Content-Language: en-US
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <ZFWLoOZZTnBrid+7@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0FkVmI1cTZyYlR1MUNnWVowSmhlNDRxZ2xGeHlHOWVFZ0k3a0FrdXNnRita?=
 =?utf-8?B?aEtRUWhhaDY4Mmw4Rk5SelJqWDkxOU5VQy80YnlQRnZSSVZoNkM5aFFyTkRN?=
 =?utf-8?B?UlpJR295aytlVlQzcFBiK3NhS0EwSmVXN3VId0w5UllmN1RkaXhWZnlOandI?=
 =?utf-8?B?eHFuR2NHSVhTdGVLUldYeFlxNEl5cG1JVWNMcFM4Vm9GV285dE9DMVJObzVY?=
 =?utf-8?B?R3hCbnp2TFlyV1k4WUN0NENPZVg4TFV0RXlMWXBRMnVzQUt2WmRqcUZ6NEJx?=
 =?utf-8?B?WUNHejRmSldvMDNtdEd6YUpnUTVqNmQ4K2RTOUtFQkdjajZEM1RUb1hVRGRv?=
 =?utf-8?B?c21sYkpoNjRDdEU4amIvMmNIeVEzTzJVQ1NkbTUrcnpwMVVPcW0wWldmK1NU?=
 =?utf-8?B?MzQ3Ykg0ZmNJVVQ2dVhaM3l3UGp4dzEzaFdoMU91NWxKaHRWTnBiRlRON2pW?=
 =?utf-8?B?ZXQyNThRQlhpTDZ3d3VwRnJKcEc5WEcyakdsSERuT0FjRU1BWVpreVJnZkRE?=
 =?utf-8?B?eVhOYit3RzJGdG1XdVlzYUpVVVcvQlhGVjlGck9CWEU4V3hCd0ZEeDQwK2Y0?=
 =?utf-8?B?VVg4SjdzTm9NT1B5WUdUc3krd3FLVjc0U2dQaExNZmthTnFjRHJCMG1Ealhj?=
 =?utf-8?B?Z281dHp5ZFc1RUF6bG9JRDdRTjcwWkcwYWkyRStsaHRMYU9DK05RamxhdHZu?=
 =?utf-8?B?MUcrZ2VtUGVIT0xCc0JzWUJVdE5Hb3ZKTzA5WlY0RkdtbGJTc3B1emdDVGMy?=
 =?utf-8?B?NmlpT3k3STR0NDY3VS9JN25WVkh5eFJiYnFKKzQwTjZvd1R6RUl0MXdoQmNx?=
 =?utf-8?B?dVljRTNqbXBJZVJBNDA3eEtEejBocklsZU1ZcDRkUGVGQW91R2ZrOEtxaTMw?=
 =?utf-8?B?TXBOdUs0T2Vwblhid3M2MDE1aWt5OUZkMURXOGNES2oyTGFxZGFlcCtKM28x?=
 =?utf-8?B?NW1WVzhCUXh1QjQzcDJRMEJtWUtIRjFCaFdvOG1EazZrekZGeVVOeTV6UXlW?=
 =?utf-8?B?blpVZzB4d1RCWVpPcHBRVGVkU1hCWVJwUmR1MlpxK0xPejEzZDQwMVh3RDJ4?=
 =?utf-8?B?czVNRzI0Zjd6R09ubHJKR1dBRkd0dmNBdzFSMitPMTFvRm1nY0xVUmtNZ05R?=
 =?utf-8?B?cldsV1BpNmZTRnJQS0I3Ym8rOWtSNGVXNkZpUGVhSDZkVVVDcjhiOG50OHhF?=
 =?utf-8?B?WG81SWdiZ2hPVHN6dStXc0ZNUU0zTW9TMEhRNzVvTEJ6ZUY3V0xuVUtEc2Zr?=
 =?utf-8?B?UDEyZk1xVFNtMCtYSlpKcTlodXVWenViUVJhaXd0eW1ZRUdmMGNYcnpGZXFV?=
 =?utf-8?B?VjhKNkpNaXRSMXdtYjhCSE53SGpxNkNWWHFna0JibkdSQzBjWHV6MWJYbjJV?=
 =?utf-8?B?VXI1SVMvcld5dEYvR242SUJHald3UFlmM1l3REQ3eEFxMGQ5dGhtVnRlclA5?=
 =?utf-8?B?YWJUbUdReVVQYTFnbG9JQ1BaSzlObXJ2MTVRbkE3alkrM2MxWFY0M09RZFRQ?=
 =?utf-8?B?d3FWQ1BxcjNwTDZZMVVybUNrNlF3NXE3aUNvMzlQR3RYR3VSWHZjYzRaT0R3?=
 =?utf-8?B?YjAzVjJxa3c3K3h3eEZ1YXlyUHFzY3ZLaXJUUnh3VjIzNnk4aUNrdXd1N2tm?=
 =?utf-8?B?b1JTaGwxbmlpODFkaGIzTm9JWVRzNHdkSmtNeDdJQW9sYjdYL0xyenZJMFhQ?=
 =?utf-8?B?QUFzWWxJVmpGM0xHNnhzK1dma1VCOVJCQkozcXU0RG9rcXIzSHFKb2xGZ01v?=
 =?utf-8?B?bGhPQ0hLbG5BUWJMVE5peFZiV3Q5TGNtQUlCMlFXejZLMTFPajU5NXd3Q0Fh?=
 =?utf-8?B?ODYzVEZqU05ZYnJsNldnVHlsYkl4MFI0K0R2bzNHRmcrZEErWitDWlBUU2dY?=
 =?utf-8?B?Z3lMV3kwRFJPbjVHMHhxV25EdGRTS1Z3M1RiM0tpa2I5ZjlwcXJFVDhnUFhM?=
 =?utf-8?B?NzkwSzE2Y3VPdmdhU2ZsazhDYjBKNHdxUUV5VGxCdlVYYkltQkVGR3FVL2h6?=
 =?utf-8?B?UmZUZGRnUFdqZkRKaERWZjJUelJ0Y1RhUHBtMXVjakNhaE1wYy9WWlR6dHZj?=
 =?utf-8?B?bVJFcENhQVZ1TGJUQ1ZMOHNhNWFzeEZ2WlhHSk5IVzhNdVlrcThlMnhXaWFE?=
 =?utf-8?B?YXhuME1MWW9DejZNYXBkU2doaDRxVG1IRFZOTWNZcHIvdHJ6TmtMZkYrbTVh?=
 =?utf-8?B?bVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 88713e1c-1050-46e9-dd72-08db4ff09e19
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 18:18:26.8462
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BPijgCBilUVic8bheFdezpuHbRvMSEH2tR6iEjtKYgdNic3f38MKzTIvCZ3xiN5sUpOnwDek+KHrs7B0pD1Q/aic2LedvmC+QNzzDPiCgkM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7335
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 5/5/2023 4:05 PM, Eric Biggers wrote:
> On Mon, Apr 10, 2023 at 03:59:31PM -0700, Chang S. Bae wrote:
>>   
>> +#ifdef CONFIG_X86_KEYLOCKER
>> +void setup_keylocker(struct cpuinfo_x86 *c);
>> +void destroy_keylocker_data(void);
>> +#else
>> +#define setup_keylocker(c) do { } while (0)
>> +#define destroy_keylocker_data() do { } while (0)
>> +#endif
> 
> Shouldn't the !CONFIG_X86_KEYLOCKER stubs be static inline functions instead of
> macros, so that type checking works?

I think either way works here. This macro is just for nothing.

Thanks,
Chang