Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     "Chang S. Bae" <chang.seok.bae@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "dm-devel@redhat.com" <dm-devel@redhat.com>
CC:     "ebiggers@kernel.org" <ebiggers@kernel.org>,
        "gmazyland@gmail.com" <gmazyland@gmail.com>,
        "luto@kernel.org" <luto@kernel.org>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "bp@suse.de" <bp@suse.de>, "mingo@kernel.org" <mingo@kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "ardb@kernel.org" <ardb@kernel.org>,
        "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
        "bernie.keany@intel.com" <bernie.keany@intel.com>,
        "charishma1.gairuboyina@intel.com" <charishma1.gairuboyina@intel.com>,
        "lalithambika.krishnakumar@intel.com" 
        <lalithambika.krishnakumar@intel.com>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: RE: [PATCH v6 07/12] x86/cpu/keylocker: Load an internal wrapping key
 at boot-time
Thread-Topic: [PATCH v6 07/12] x86/cpu/keylocker: Load an internal wrapping
 key at boot-time
Thread-Index: AQHZbAHvJOw7tE8EFUqNRCfBgGyiXq9Qxy3A
Date:   Mon, 8 May 2023 19:18:50 +0000
Message-ID: <MW5PR84MB184225DA6EA0FA7A9191C057AB719@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20220112211258.21115-1-chang.seok.bae@intel.com>
 <20230410225936.8940-1-chang.seok.bae@intel.com>
 <20230410225936.8940-8-chang.seok.bae@intel.com>
In-Reply-To: <20230410225936.8940-8-chang.seok.bae@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xfyeahWxSSOyh5EVAEqRm6bWsiCJBOU5IGIcoh1bFSTISdpLlZVlBAAnylK5?=
 =?us-ascii?Q?by+lwKF0YP+0FZQoVEWL0jQ+E5fImzdDN+rd8RrYjN9l+On0dI6/oDGfjXOC?=
 =?us-ascii?Q?plYnBifFsiGbyQvqhq58AE0XYHWyeWNdfazCG1tcwgIW9oyXJuMR/0QVcMHk?=
 =?us-ascii?Q?jxTYs6Ihbrg1bx8BknFefS7FRZAg1uEgcw110pF+3iOhWNE5n9BwweSyrYeT?=
 =?us-ascii?Q?cSOsy0xJVQGLyuB+Y+iLfgKWgwm5LxkiqXl/Ji+Srd13RHv6pluPAI3u/RLH?=
 =?us-ascii?Q?GUg5iW9nAcRVHAOevmN3+7nYJZdlA85Z19iXNiONb6is81GCLlA54ipjAHLH?=
 =?us-ascii?Q?Pd8IwBL0zJ91SUAE3M4P19SELO9/S4ysTceHSpn6P7vxN6/RkRpTj4KR6CPr?=
 =?us-ascii?Q?GPiHspqo294pP0CuYKJo/rhf5oAVb5Qx3HfOUFls3TV3fp2NiEKanZcXktJV?=
 =?us-ascii?Q?rIPedUiGHEv8ShBRwm919T1kh5G9B57dQ6DRoIiGSNbR/Wi8ren++Gu9cox7?=
 =?us-ascii?Q?SOUUC6rkvxX2XY1W+6mdPjx2sY2+/djfFrosV9dmMGCjF0jJA92CHDK1hwmA?=
 =?us-ascii?Q?L0KQhFPd5mW9IW3aEniNr62kHSyIw9Wv2rqc24bj4zaSq1beta1jPp5PZY/0?=
 =?us-ascii?Q?IREj9HntRV7zE/eExuoSlSBVMSB8c3kkPFd87c01sTqFJC0NyjGzXjoF7pu5?=
 =?us-ascii?Q?NrveEF1fY1LzMEyzYZyR8EvfLe9xlfam6bvY5opeq0LAR914gWBBNqpOLHDF?=
 =?us-ascii?Q?mKYOSWqqwJ6Mws42te3q/lY4bTaSACM3rPenV5lqZfUksMTFNL6L32M5MBdN?=
 =?us-ascii?Q?sXvCIpRuq5t3eOGDFxsvMwtHoqScW2O2Oqi9eEi3/C7AHmzlmFBLVUCxs/T5?=
 =?us-ascii?Q?LTk6Yui410l0ERJAA5Y4KyfHhz4viO96NEiu0ILqbyaoPNNNJjI1u2AETwkg?=
 =?us-ascii?Q?aLJ8cLI3U0VzpjkLvDU+0PViNl+6RqsRTCg4jpH5RU+E2Lqk1vpctHbGRvke?=
 =?us-ascii?Q?6YOE4YBeuQ1HnYlP+CEide+Tu+kfGflBo/MuOR9qH1JYuI5Y9cxlI3fvJcYe?=
 =?us-ascii?Q?ZRXYvcqysNp8kueBSX2h8q6t9kAuslh7E1BClyEh3goDkMSpNIkDLk/V2fuq?=
 =?us-ascii?Q?c34B/qmszrynK++Qg+1pHT7cwNgh6/F2WKJhD9/tVsSwJjMpt3ZMYofBBB2E?=
 =?us-ascii?Q?qo6Zzs8k29UeyUkeXiLK/26r0KX5CJqrCgyZXpyvl/j73zTrhD3gcLRRCcJ9?=
 =?us-ascii?Q?tzRMzUYr5mM9S72ZPcDhUczEQDd4tXFFwh4j48nK/Cd6Dewuo7akOG1J7o6v?=
 =?us-ascii?Q?yWbNdmfXpUnaYtTOjdTsOyWrUMnkEc838lCw1fDM86Ckmt7skh3knuJyrJzw?=
 =?us-ascii?Q?aZuPTHzaOUwiXJH8Yvj9pNxe0enrV8gMJfejaPO2YuraVPg6jWSFF6Oh4h3d?=
 =?us-ascii?Q?rCkmyKl6lovQFnb+cba912K8Pg0PAHyr0p9OWpq2wWhbTcCZZy+DvCc7+TnS?=
 =?us-ascii?Q?necTu5orTJCvtMy81P9gXEcOZxiqmv5o8rvV8r6j+mEGNugArAwbwiOvBbKk?=
 =?us-ascii?Q?/E4wgUaJDkG8tI4mukU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e56d50d-37f6-411c-91a6-08db4ff90df1
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2023 19:18:50.1877
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Isr9Ni/qTcxXU8M7JMdCjKcoTuI+hZdfzV6rmIYY/aOzUlNhClwxWCvnrT01Vced
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR84MB1781
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: v3wbkFgu3jKvIdIjXX92AWIU-_NGDmG9
X-Proofpoint-GUID: v3wbkFgu3jKvIdIjXX92AWIU-_NGDmG9
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-08_13,2023-05-05_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0
 mlxscore=0 impostorscore=0 malwarescore=0 phishscore=0 spamscore=0
 clxscore=1011 suspectscore=0 priorityscore=1501 mlxlogscore=908
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2305080128
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


> diff --git a/arch/x86/kernel/keylocker.c b/arch/x86/kernel/keylocker.c
...
> +void __init destroy_keylocker_data(void)
> +{
> +	memset(&kl_setup.key, KEY_DESTROY, sizeof(kl_setup.key));
> +}

That's a special value for garbage collected keyring keys assigned
a keytype of ".dead". memzero() or memzero_explicit() might be better=20
for this use case.