Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d9bad7c2-14d7-7f06-da50-81069853babd@intel.com>
Date:   Tue, 9 May 2023 10:48:57 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v4 01/15] dmaengine: idxd: add wq driver name support for
 accel-config user tool
Content-Language: en-US
To:     Tom Zanussi <tom.zanussi@linux.intel.com>,
        <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
        <vkoul@kernel.org>
CC:     <dave.jiang@intel.com>, <tony.luck@intel.com>,
        <wajdi.k.feghali@intel.com>, <james.guilford@intel.com>,
        <kanchana.p.sridhar@intel.com>, <giovanni.cabiddu@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
        <dmaengine@vger.kernel.org>
References: <cover.1683573703.git.zanussi@kernel.org>
 <a874741f266f57502d671843b9d4a9b563c372e3.1683573703.git.zanussi@kernel.org>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <a874741f266f57502d671843b9d4a9b563c372e3.1683573703.git.zanussi@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlZxVm4zZE00SFRVcUpIR0czeldFV3VpbDlxbEFHWXJkTElQU1RTS2V0Unls?=
 =?utf-8?B?M3JCNzlzcG5NOVVKdS9udmgwWE5TOGhGRFN2UFZlUGdPWWVOL1IrTnRnRVE3?=
 =?utf-8?B?Ui83MGVtc1hMRGp6bndZWlJZS2ZMUDhTVWg5MnRqMzlLNTVjTHdyTkxMYk5C?=
 =?utf-8?B?OGpjTytKL1E5UFpHNFZqQk5jMVpQZ082K3gzMlc1RGJWTXBxNlVnTHhsWWFn?=
 =?utf-8?B?K2l1NC9LSHBjOFMydGxpYUxCNjJ0VWUxeWcrU1lyOGR2VWduc0JEU2tTV3da?=
 =?utf-8?B?bTd2RzJCcHl2aDlmbE4rTEFsZkt6YVU0YkUvUjhzWGpQT2FrZWFxQkUyUEZ4?=
 =?utf-8?B?WUpjYlBrVzljajFnOVBDVkxVbm1MZmFhTXYwcUZldnFNY0pwcXRVRGw4QVJL?=
 =?utf-8?B?Sll6MVdOajUvZytyZUhGTjFNR3gxY3EvNTZRWUxWZ2hhN3krRDROOUcyTy9K?=
 =?utf-8?B?WkVhVDVtVTR0V0daS0gvNDZ4MmNoa1dZd002OC9uZVcrdlF0Y0ZSQUd5Qzln?=
 =?utf-8?B?Rk1DUkpla2pLUWkvQUdCRVlHTzh4L0pJV1BsNWw5UEVsMHR0SFNEK3pjYjdO?=
 =?utf-8?B?aHhCa09GQXdHNnV5OHFHNXY3ZURHSk1waUt0c043MkFYd1F6VnR3bkZiWWhP?=
 =?utf-8?B?YnY2aGpVcERoMGtWUS9NZ3QvY09aN2Q1V0ZJdnpoSjVTMForY0tWVmNpd3pE?=
 =?utf-8?B?MTRHZ3hFeTUzR3ZxV3FQVnBTNE84KzlnWE9lZVRTSWhubWpLeTVUUEVCV2t5?=
 =?utf-8?B?cVlvV2pjS2dibzZwVzJoMk84V0NTc2lhWDZkUnVoOE9rSUlyb1dpRmppNzRJ?=
 =?utf-8?B?NnlIOFJjcnpsaEtqRkk3QUlkbEdCeGdkcWZJeDhTbjF6RmNyQ1J0OXpINFZ1?=
 =?utf-8?B?aGlWd1E5Tm1hUVVTSERMTm9tVng0VHl1MUFvcm5Nb1YxWklsR0xjb1pHT0VE?=
 =?utf-8?B?dVpMZWc5Um9DTjA4bS81UW5XdWViNDBGeHRHbXhxYzZaM0lmUXNXTjhvakhQ?=
 =?utf-8?B?enVMUWlTMDNtUytmYW5YVGNyVkI2aUoySmxMcDhZQ3VESXgrNXpJZmRlZmFE?=
 =?utf-8?B?czRTN1R0WTdBY0VDbGlvYURHSVJMSXFJOFZjcTZDbUVma3hITmZGdkNYNHNY?=
 =?utf-8?B?NVUwRFprUmhpMTRJNzRIRTFwRmcwMlU1UHpFb1Y4K3pSQmwzTTlIS0QvTjJM?=
 =?utf-8?B?UXJ0RVl2bktqSFF5eEVzSndzYis5TldZcHZQa3htWFkrbTVKT3pZSjByRGRV?=
 =?utf-8?B?WEhiVGxicUNqSzhYQ3JuZTcwMEFrMHoxdDM2M1JVK0srbElBQzR0R2FqOGhy?=
 =?utf-8?B?MzdXQXkyUm1OQzBmU2tLaHdPa3A3NnVXUm5Dc3BOWmhNTjAvTHozR1dlRGxZ?=
 =?utf-8?B?Si9WQVlkdlFTZEZIdEhoM2NGa3FLb01Id0J2VDRrMGRieDNpOWZPdEM3Z3g5?=
 =?utf-8?B?YXN6TmkwbHZvVU5rdFBoVGU3OUlLNk9PSzJBY2V4NGN3US9DRHN5STlJTjM5?=
 =?utf-8?B?RnpjTFpEUml2Y0daNFJ1bVNFM05RWFZIOWN6aFdXemlGMlVnbFN4OERJYzFp?=
 =?utf-8?B?NUFKV2JGcjErbnQwQ1VvanJZUllaWHV2S0VZZ0kzTDB5Zmk1UzlxTlk1MWpJ?=
 =?utf-8?B?b2pXK3VHM1lJckxQRXFUb21BRDR6TEtUcWR1ajBaajc3M0thdG5LMkVCaHIx?=
 =?utf-8?B?bXRNaEtNZnZadlB3M0Zhd29BN3JNUXhsRUMrc3ZlOTBQZE1rTkFmVm95V2JL?=
 =?utf-8?B?SjNvMGRmN3ZrTUtDMzZFejNXMFdKR2xFWkIwSFNJbE1GUVE4MmhocWFBMStk?=
 =?utf-8?B?dERvZFNNSVkwSE5lVWRwcXV0aGdFTlptUkZwQzdOc0NtbldVZmMrUkwzcGhL?=
 =?utf-8?B?bjB2UFRHYlR4eUZZcTM2VmZSUUl5Qno1OStieTlBdUM1MXR3VzJ4bWJ3WXVx?=
 =?utf-8?B?K1hqSXpnYlZnZXFJbzhJNTlPdFFpd25Ucyt2RW15YmtBenhURVJUWFJHaG9p?=
 =?utf-8?B?Tk9tNW9ONmRsNUVYcVBpd3AwYllJdVd0L3J0VmM3dkdIZGRNanBuTG9ubVZx?=
 =?utf-8?B?WHc0KzU2WldZNjE3bEtya3Z0OW1WRDFRRlg5NmNDQzhnU2JvQzV2Ly94bWFq?=
 =?utf-8?Q?jpoQX04OPYajlq9UzTaV8D2fh?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d8504165-6545-446c-f3a4-08db50b59de0
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2023 17:48:37.3525
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yfXlMcW1zzEpCfhbbgYo6DCDAEPmJzCsaPhJ6FVHa5gSOO4EYZNKNK0ZPRvT+Z4lmYFTC2m5cKhFuB/PjXUG8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5235
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi, Tom,

On 5/8/23 13:07, Tom Zanussi wrote:
> From: Dave Jiang <dave.jiang@intel.com>
> 
> With the possibility of multiple wq drivers that can be bound to the wq,
> the user config tool accel-config needs a way to know which wq driver to
> bind to the wq. Introduce per wq driver_name sysfs attribute where the user
> can indicate the driver to be bound to the wq. This allows accel-config to
> just bind to the driver using wq->driver_name.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> ---
>   .../ABI/stable/sysfs-driver-dma-idxd          |  6 ++++
>   drivers/dma/idxd/cdev.c                       |  8 ++++++
>   drivers/dma/idxd/dma.c                        |  6 ++++
>   drivers/dma/idxd/idxd.h                       |  9 ++++++
>   drivers/dma/idxd/sysfs.c                      | 28 +++++++++++++++++++
>   include/uapi/linux/idxd.h                     |  1 +
>   6 files changed, 58 insertions(+)
> 
> diff --git a/Documentation/ABI/stable/sysfs-driver-dma-idxd b/Documentation/ABI/stable/sysfs-driver-dma-idxd
> index 3becc9a82bdf..d5daae442fe7 100644
> --- a/Documentation/ABI/stable/sysfs-driver-dma-idxd
> +++ b/Documentation/ABI/stable/sysfs-driver-dma-idxd
> @@ -244,6 +244,12 @@ Description:	Shows the operation capability bits displayed in bitmap format
>   		correlates to the operations allowed. It's visible only
>   		on platforms that support the capability.
>   
> +What:		/sys/bus/dsa/devices/wq<m>.<n>/driver_name
> +Date:		Mar 27, 2023 > +KernelVersion:	6.4.0

Need to be changed to 6.5.0 now:)

After fixing the KernelVersion,

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua