Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp10168655rwr; Fri, 12 May 2023 04:58:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4NIZ9+2wbsgx1KRPg53QgDY2FfdNVkTsx/o4OxZvAC6moBgPIHn0etLRVhBwAQSa5sTRK8 X-Received: by 2002:a17:90a:f30d:b0:24e:5f04:d72b with SMTP id ca13-20020a17090af30d00b0024e5f04d72bmr22263701pjb.48.1683892714282; Fri, 12 May 2023 04:58:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683892714; cv=none; d=google.com; s=arc-20160816; b=GtGtl+72LwjFVHhRZLG4/gq8lotzUoNNIfIPPqAgHvbnETGNM99lDIZh4SWkMKBICs QqS73S5ybCGH4PIZ2A9Jg5R8fq8O6nOnhZpCwXaBug19L8SZdVldPcL10B48aUKiwy51 iydgdPC7Gvfp/0Cpz3iLQ/baDnEtUDMR2cTaqNv7g+cazT13LzFnRiP7ioFAB2JHutTU +6Dd2mY6jWnEnpSDPYhUooh/XHqhLydPRfjaoi2e9T3o4EDRjJWAO59ZeeKn9YZmL9R1 9dRnriIjDmdW5FQNy9lpIhH77AeYeJ+Y6S15tfDP91K4EKZ9v98cgkXD0SM4BLD8PBAf Zuqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=uKB4QtR0n5LChGE5XNR0cadgxyW2ZDUSc7YPOOkbIWY=; b=TRRWmTeKiiELjazNyjSMkwSk2f0CGo7MAJj6e838dFptrQMX6iAuUOHDDkOd7cfvOT sGVmpi5rLhXokEl8IM5hnQU7czYgwYjaPZQgZr/jKzLYG+H5An9gthxKjeVwl0YF2Oao VdkQ6r242nHrQ4WTxibLKrCK6HZsMRG+rSy5r6WAeYICIcfSd/cHJ0Jou3yvfzgNOTwg GkKhiuxMev4aYolGWpr41d+2BzXragutdpUrHyYgCeT/NZYJLTv66yjvPqHxemt2/jgr wxbpjZi8XBRM/DKvhysaEIBbL1iNnYfwUIAiFWMOHSBMHb9/eyWMt727b6kGUs4ynhqE exqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i17-20020a17090acf9100b0024e60919369si7709459pju.172.2023.05.12.04.58.17; Fri, 12 May 2023 04:58:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241002AbjELLkD (ORCPT + 99 others); Fri, 12 May 2023 07:40:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240230AbjELLkC (ORCPT ); Fri, 12 May 2023 07:40:02 -0400 Received: from cavan.codon.org.uk (cavan.codon.org.uk [176.126.240.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B3ABFA; Fri, 12 May 2023 04:40:01 -0700 (PDT) Received: by cavan.codon.org.uk (Postfix, from userid 1000) id 1D9DF40A6F; Fri, 12 May 2023 12:40:00 +0100 (BST) Date: Fri, 12 May 2023 12:40:00 +0100 From: Matthew Garrett To: Ross Philipson Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, iommu@lists.linux-foundation.org, kexec@lists.infradead.org, linux-efi@vger.kernel.org, dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, ardb@kernel.org, James.Bottomley@hansenpartnership.com, luto@amacapital.net, nivedita@alum.mit.edu, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com Subject: Re: [PATCH v6 11/14] reboot: Secure Launch SEXIT support on reboot paths Message-ID: <20230512114000.GG14461@srcf.ucam.org> References: <20230504145023.835096-1-ross.philipson@oracle.com> <20230504145023.835096-12-ross.philipson@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230504145023.835096-12-ross.philipson@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, May 04, 2023 at 02:50:20PM +0000, Ross Philipson wrote: > If the MLE kernel is being powered off, rebooted or halted, > then SEXIT must be called. Note that the SEXIT GETSEC leaf > can only be called after a machine_shutdown() has been done on > these paths. The machine_shutdown() is not called on a few paths > like when poweroff action does not have a poweroff callback (into > ACPI code) or when an emergency reset is done. In these cases, > just the TXT registers are finalized but SEXIT is skipped. What are the consequences of SEXIT not being called, and why is it ok to skip it in these circumstances?