Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2ae2d187-5db7-9207-7846-1a80e87047b2@starfivetech.com>
Date:   Mon, 15 May 2023 11:27:35 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v7 4/4] crypto: starfive - Add hash and HMAC support
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     "David S . Miller" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Emil Renner Berthing <kernel@esmil.dk>,
        Conor Dooley <conor@kernel.org>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        <linux-crypto@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
References: <20230504073400.1170979-1-jiajie.ho@starfivetech.com>
 <20230504073400.1170979-5-jiajie.ho@starfivetech.com>
 <ZF4bKe0YkpcQakLs@gondor.apana.org.au>
Content-Language: en-US
From:   Jia Jie Ho <jiajie.ho@starfivetech.com>
In-Reply-To: <ZF4bKe0YkpcQakLs@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On 12/5/2023 6:55 pm, Herbert Xu wrote:
> On Thu, May 04, 2023 at 03:34:00PM +0800, Jia Jie Ho wrote:
>>
>> +	writel(~STARFIVE_IE_MASK_HASH_DONE, cryp->base + STARFIVE_IE_MASK_OFFSET);
>> +	writel(csr.v, cryp->base + STARFIVE_HASH_SHACSR);
> 
> With compile testing I get
> 
> ../drivers/crypto/starfive/jh7110-hash.c: In function ‘starfive_hash_start’:
> ../drivers/crypto/starfive/jh7110-hash.c:110:9: warning: conversion from ‘long unsigned int’ to ‘unsigned int’ changes value from ‘18446744073709551611’ to ‘4294967291’ [-Woverflow]
> 

Hi Herbert,
I've added COMPILE_TEST in the Kconfig, then ran make W=1, sparse and smatch.
However it did not produce the error message.

+config CRYPTO_DEV_JH7110
+       tristate "StarFive JH7110 cryptographic engine driver"
+       depends on SOC_STARFIVE || COMPILE_TEST
+       select CRYPTO_ENGINE

Symbol: COMPILE_TEST [=y]
Type  : bool
Defined at init/Kconfig:142

make C=2 drivers/crypto/
make W=1 drivers/crypto/
~/smatch/smatch_scripts/kchecker drivers/crypto/

Am I missing something?

Thanks,
Jia Jie