Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230513074339.266879-1-mmyangfl@gmail.com> <20230513074339.266879-3-mmyangfl@gmail.com>
 <ZGc2m5dJh79y3pxO@gondor.apana.org.au>
In-Reply-To: <ZGc2m5dJh79y3pxO@gondor.apana.org.au>
From:   Yangfl <mmyangfl@gmail.com>
Date:   Sat, 20 May 2023 03:03:27 +0800
Message-ID: <CAAXyoMM7WisnMKTHrfx0WdMY9Xa492caaeCNrjKOdMsS0QBXhA@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] crypto: hisilicon/advca - Add SHA support
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-crypto@vger.kernel.org, Weili Qian <qianweili@huawei.com>,
        Zhou Wang <wangzhou1@hisilicon.com>,
        "David S. Miller" <davem@davemloft.net>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Herbert Xu <herbert@gondor.apana.org.au> =E4=BA=8E2023=E5=B9=B45=E6=9C=8819=
=E6=97=A5=E5=91=A8=E4=BA=94 16:43=E5=86=99=E9=81=93=EF=BC=9A
>
> On Sat, May 13, 2023 at 03:43:22PM +0800, David Yang wrote:
> >
> > +static int hica_sha_export(const struct hica_sha_priv *priv, void *out=
,
> > +                        unsigned int digestsize)
> > +{
> > +     if (hica_sha_wait(priv, SHA_RECORD_READY))
> > +             return -ETIMEDOUT;
> > +
> > +     for (unsigned int i =3D 0; i < digestsize; i +=3D sizeof(u32))
> > +             *(u32 *) (out + i) =3D
> > +                     be32_to_cpu(readl_relaxed(priv->base + SHA_OUT0 +=
 i));
> > +
> > +     return 0;
> > +}
>
> Can you please explain what this is doing? Is this exporting
> the finalized hash, or the intermediate state?
>
> If it's exporting the intermediate state, why aren't you implementing
> an import function?
>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

The intermediate state. Importing is done by hica_sha_init, since if I
got it right, crypto hash api are required to handle multiple requests
simultaneously, thus there will be no sense to set ctrl and state
separately.