Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 14:19:10 -0500
From:   John Allen <john.allen@amd.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Tom Lendacky <thomas.lendacky@amd.com>,
        "David S . Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH 3/3] crypto: ccp - Add support for PCI device 0x156E
Message-ID: <ZGfLrtmVOcCYiWFW@johallen-workstation>
References: <20230519032414.94247-1-mario.limonciello@amd.com>
 <20230519032414.94247-4-mario.limonciello@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230519032414.94247-4-mario.limonciello@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Rxv8GyDZBxzis5rONnwt9bwXXtp8lFuNKGb00UqcQbF7Qvb54rFiet8DeLbS?=
 =?us-ascii?Q?+F2QBPQrCUyxcViV6AsNdGBCMpkVHke3rv/F7P2RQ26kCaTXnhBlAB/z/aSz?=
 =?us-ascii?Q?0glHNgg8No4rTOk3SmN2IsfB/9Z/GVFcF9m3Q56G8iKKBF0ZUN5VER9bh+vP?=
 =?us-ascii?Q?Ly4UEHh4DBf49+zOFhB9VfsnOFGDDNqTV1IDevU7HiJUvSIoP1a+Xt4t8/vS?=
 =?us-ascii?Q?waLDY7IBJT2w9uGBYPDwFkBUAhlA9myNzf7nPYXGrnrKVzgZXEbAMpFg5Aor?=
 =?us-ascii?Q?nKICPoOK2SuErb9AEvUL4rN2HhqFGY7U3bbmePwpX6lXEv7MZshnDoAMN0kE?=
 =?us-ascii?Q?asfQZZB9tpGb4MEG8vqxS1tUCiHZvujO1nScZUWFXWei1Ptf2prfU+WhUkYC?=
 =?us-ascii?Q?g0YE6OrQ4QIG2dqLljTq13803Yqx3564PV9zaj4VIEJte96WZ660B+mwaRE3?=
 =?us-ascii?Q?V0zFpMObZ1amXKxq1tKhiHAnFmjih56EFrGEVeruvnu9CYRmAeBdmZAiMC8b?=
 =?us-ascii?Q?xFlUMSBzdsBENBslmxc99zx4B71k7jCRczchCZopjH29d7QDqXOP7DZ/MKkl?=
 =?us-ascii?Q?m35Sirp5xPEVxXAyAllgFotFrpo+2Y9eS0CVe6JaBix0tu/H8NqwW0AC4HHj?=
 =?us-ascii?Q?98SLGErV89UQhSLLxQwbsx+TvA9jS6Yx1nNcBPTYDFHxWga1El+5lKqdEpCm?=
 =?us-ascii?Q?6vZSoMDB9nOG+UdwW8SinijT7u62PK+3CmiwpdNj66s/tNR33JE1pdC1/jjN?=
 =?us-ascii?Q?+cRypHoA/TDlG1GpQTzwdZchUCIWOSZgWq0YKcuxOT529NZhpnDspRAAt3PZ?=
 =?us-ascii?Q?0MsigAIXk3Q0fAIGRgLvfrorbaDk+uQW4dDKy8Vc6I/ncUY5rVfbRn+0i0Wx?=
 =?us-ascii?Q?iTVwbIyk8LSFOZzpLNZ1frLW8cjYYVzB+Pa1N7uw3zuddU1hNKswR4jK+gp2?=
 =?us-ascii?Q?9tlQxRuCgQ1c99Acw10xjSypjNBjGEAZhgS0ROvtQ6ubuvPopyP1kuNpTZyJ?=
 =?us-ascii?Q?cqpYUc966zBxEY/gnB6PiM6aQQzdeuJuYxrM2hgtFiEO3VnynEkzANpFXdYB?=
 =?us-ascii?Q?qyx+bEv63nnMbSBIPuWwti1ERJ26d5g6Q+o38UUgmqisjqCjA04BDwJm1DZ2?=
 =?us-ascii?Q?g6A3DzFZBetR+bxi57VilLyMKk3AwQ4FNGejpIZc+cGKEhXRCCnfeG1r6YKl?=
 =?us-ascii?Q?3g/CqETQgAimDUfDqFWGbYeE9t6JpfoOZ66tU1A+7q2OWPq8aioslPB8ZCBm?=
 =?us-ascii?Q?KN2X9ceY/daaXyMCbjRDXJslhsGGWweMR4XYv9Dgi2tJq9kHXDNg9riGd5Se?=
 =?us-ascii?Q?g0AqpA2A/XN7NIi4e/RvIc5ps6kuV+xnlJD3BAj06zwKd3clsaA6bC38AIEM?=
 =?us-ascii?Q?VoAKcrxCHDs4TtB3gtsQZdti7vMS20vDZjmUHTmU2/Yy4FE8mpSXPPcJeKgU?=
 =?us-ascii?Q?iUO9rSNEeeGBhPxM0m6YLxf7meYLkiSpbUMUCHRG1i2YLNEXv2qd+wF8LLU0?=
 =?us-ascii?Q?srGIgFcJXRUk7JeNB9WKppiacETqXz/uUMlFplkoJ8R7jV0iznJ2Y3CYAHjZ?=
 =?us-ascii?Q?xcPaX45RcydSRzoBa7+DKcOsZZ31HjxycHTeAVaE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdf14d23-f2b4-4d36-d340-08db589df21d
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5995.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 19:19:20.0092
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2+tjXWwK8M3XCOQLEVeGSvR8souhi8WT5LndWMpp7Mvvb3Gv/nJJs9WJvIia7/CzQrMRJ3PLnmpxZ2zwprXBlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7069
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Thu, May 18, 2023 at 10:24:14PM -0500, Mario Limonciello wrote:
> From: John Allen <john.allen@amd.com>
> 
> Add a new CCP/PSP PCI device ID and new PSP register offsets.
> 
> Signed-off-by: John Allen <john.allen@amd.com>

Hi Herbert,

Please hold off on applying this patch for now. I need to do a little
bit more testing.

Thanks,
John

> ---
>  drivers/crypto/ccp/sp-pci.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index d0d70af0c4c0..b603ad9b8341 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -420,6 +420,14 @@ static const struct psp_vdata pspv5 = {
>  	.intsts_reg		= 0x10514,	/* P2CMSG_INTSTS */
>  };
>  
> +static const struct psp_vdata pspv6 = {
> +	.sev                    = &sevv2,
> +	.tee                    = &teev2,
> +	.feature_reg            = 0x109fc,	/* C2PMSG_63 */
> +	.inten_reg              = 0x10510,	/* P2CMSG_INTEN */
> +	.intsts_reg             = 0x10514,	/* P2CMSG_INTSTS */
> +};
> +
>  #endif
>  
>  static const struct sp_dev_vdata dev_vdata[] = {
> @@ -478,6 +486,12 @@ static const struct sp_dev_vdata dev_vdata[] = {
>  		.bar = 2,
>  #ifdef CONFIG_CRYPTO_DEV_SP_PSP
>  		.psp_vdata = &pspv5,
> +#endif
> +	},
> +	{	/* 8 */
> +		.bar = 2,
> +#ifdef CONFIG_CRYPTO_DEV_SP_PSP
> +		.psp_vdata = &pspv6,
>  #endif
>  	},
>  };
> @@ -491,6 +505,7 @@ static const struct pci_device_id sp_pci_table[] = {
>  	{ PCI_VDEVICE(AMD, 0x15C7), (kernel_ulong_t)&dev_vdata[6] },
>  	{ PCI_VDEVICE(AMD, 0x1649), (kernel_ulong_t)&dev_vdata[6] },
>  	{ PCI_VDEVICE(AMD, 0x17E0), (kernel_ulong_t)&dev_vdata[7] },
> +	{ PCI_VDEVICE(AMD, 0x156E), (kernel_ulong_t)&dev_vdata[8] },
>  	/* Last entry must be zero */
>  	{ 0, }
>  };
> -- 
> 2.34.1
>