Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230520173105.8562-1-ebiggers@kernel.org>
In-Reply-To: <20230520173105.8562-1-ebiggers@kernel.org>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Sat, 20 May 2023 19:39:37 +0200
Message-ID: <CAMj1kXGkbOZ0hBr4Q3=MNoh+YrVV_fdq=banHJ-+0pO_NPw2Ww@mail.gmail.com>
Subject: Re: [PATCH] crypto/Kconfig: warn about performance overhead of CRYPTO_STATS
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-crypto@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 20 May 2023 at 19:31, Eric Biggers <ebiggers@kernel.org> wrote:
>
> From: Eric Biggers <ebiggers@google.com>
>
> Make the help text for CRYPTO_STATS explicitly mention that it reduces
> the performance of the crypto API.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  crypto/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 42751d63cd4d9..fdf3742f1106b 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -1393,6 +1393,9 @@ config CRYPTO_STATS
>         help
>           Enable the gathering of crypto stats.
>
> +         Enabling this option reduces the performance of the crypto API.  It
> +         should only be enabled when there is actually a use case for it.
> +
>           This collects data sizes, numbers of requests, and numbers
>           of errors processed by:
>           - AEAD ciphers (encrypt, decrypt)
>
> base-commit: f573db7aa528f11820dcc811bc7791b231d22b1c
> --
> 2.40.1
>