Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3461217rwd; Mon, 22 May 2023 14:17:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ44vjyPsVHQbT3Mug8fpMHU4rddo4ldJFXDKiy0x3qpGPnCTII03CQqWsEbufBvEzxj5Qhn X-Received: by 2002:a05:6a00:1404:b0:62a:4503:53ba with SMTP id l4-20020a056a00140400b0062a450353bamr14524658pfu.26.1684790223817; Mon, 22 May 2023 14:17:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684790223; cv=none; d=google.com; s=arc-20160816; b=pMaZ/GNxdTzTes9PaOlv9XxmuOh5Xz413nJI6Tuq1t+esrqH1KuQny3VTtudHvuoRC CbtCGg3UJcbb67A7OeETtG96WiWlrxB5yK5gn6a7cfMCtOF+tf3jeALFlfne3mYaklUQ xZ2Tz4trRggDxGxzNo79K5lnm6o9BZ1Oh/8bPQuwSzzZGeIh4hWPXlvW0xzrAgU4h8vV e560qXu5laYBpz+SYJaj/2VLCmdVE/Ee9YNrlI8jwpMMuG8y8lOJdsBQcfvwBIuHiQZN 7TIU3r+HuhDcOD3Y4PSDMZH4UmijSTfDvjgfoxpdld9uR0DmH+5DpAFITztmc04HVxVJ WEdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization:dkim-signature; bh=fNX29lVhLrCaEtXMXBHbZSzlgt5OSgtHfMaigHYodOA=; b=FBiMnZlwPgf5X1LLTAnX+pqhRP+TqOIGus4yK2xO5hz2Nu/FYQg1cMHRpXuPuHItto b5CtVYGDTdqbpdhujh7q5rcn2WtZ9GzUu9A1VJOLpOwBvyv88kMSYacQDHxr09yjtpc7 OBE/lYyE1P3fJb4Rz678TS/SbPED4UF2GOvkrbmCJ/oZJ1r3HbZOOZ0Uv6KMQmVurUNZ YLNCWvDNLjE5VTV8Le+q1wp4w7p/j/MV51ZYQK7cGvbVUb3YPoRVYR5KwCR4RcFQVvHO aRwo5UHeskE7WvrqGNI2KTERP9sXSePcMwb2kVAlxRK1/ZNI8ZYwhkTt/y0kob4R5WMW hkzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Rj7D5MP6; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u203-20020a6279d4000000b0063b5f25dd95si5216804pfc.391.2023.05.22.14.16.44; Mon, 22 May 2023 14:17:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Rj7D5MP6; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232262AbjEVVIA (ORCPT + 99 others); Mon, 22 May 2023 17:08:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230497AbjEVVH7 (ORCPT ); Mon, 22 May 2023 17:07:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51843C1 for ; Mon, 22 May 2023 14:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684789630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fNX29lVhLrCaEtXMXBHbZSzlgt5OSgtHfMaigHYodOA=; b=Rj7D5MP6EYh98wS/6fNasafGmHLirJ6WgEyOxcUhk5iqkQyDjnOyROG/RkeJ/yDnbTU7/M SEey4/aO9PKzzwjgh54NRLcqSdnFn+CG8AKL7CulTiYXKjCykmeFo9Y+W8nXbo6rujNsy6 xaLQ4E3w6W3ByiMKVJwtLfQ6kBNNWcw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-609-5k7AXqqhNnilgNylUa_0gQ-1; Mon, 22 May 2023 17:07:05 -0400 X-MC-Unique: 5k7AXqqhNnilgNylUa_0gQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 64B84811E8D; Mon, 22 May 2023 21:07:05 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.39.192.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CD0940CFD46; Mon, 22 May 2023 21:07:04 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <48886D84-1A04-4B07-A666-BB56684E759F@oracle.com> <380323.1681314997@warthog.procyon.org.uk> <1078650.1681394138@warthog.procyon.org.uk> <1235770.1681462057@warthog.procyon.org.uk> To: Herbert Xu Cc: dhowells@redhat.com, Chuck Lever III , Scott Mayhew , Ard Biesheuvel , Jeff Layton , Linux NFS Mailing List , "linux-crypto@vger.kernel.org" Subject: Re: Did the in-kernel Camellia or CMAC crypto implementation break? MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2892513.1684789623.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Mon, 22 May 2023 22:07:03 +0100 Message-ID: <2892515.1684789623@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Herbert Xu wrote: > > Actually, I was wondering about that. I see that all the testing data= seems > > to be statically loaded in testmgr.[ch], even if the algorithms to be = tested > > are resident in modules that aren't loaded yet (so it's kind of test "= on > > demand"). I guess it can't be split up amongst the algorithm modules = as some > > of the tests require stuff from multiple modules (eg. aes + cbs + cts)= . > = > Yes I've been meaning to split this up so they're colocated with > the generic implementation. I don't suppose you have anything to look at for this? Should I leave my testing stuff as it is for now until you've attempted this? David