Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 May 2023 18:13:44 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     linux-crypto@vger.kernel.org, Taehee Yoo <ap420073@gmail.com>,
        syzbot+a6abcf08bad8b18fd198@syzkaller.appspotmail.com
Subject: Re: [PATCH] crypto: x86/aria - Use 16 byte alignment for GFNI
 constant vectors
Message-ID: <ZG3jWHFZXGUqKmUt@gondor.apana.org.au>
References: <20230516181419.3633842-1-ardb@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230516181419.3633842-1-ardb@kernel.org>
Precedence: bulk

On Tue, May 16, 2023 at 08:14:19PM +0200, Ard Biesheuvel wrote:
> The GFNI routines in the AVX version of the ARIA implementation now use
> explicit VMOVDQA instructions to load the constant input vectors, which
> means they must be 16 byte aligned. So ensure that this is the case, by
> dropping the section split and the incorrect .align 8 directive, and
> emitting the constants into the 16-byte aligned section instead.
> 
> Note that the AVX2 version of this code deviates from this pattern, and
> does not require a similar fix, given that it loads these contants as
> 8-byte memory operands, for which AVX2 permits any alignment.
> 
> Cc: Taehee Yoo <ap420073@gmail.com>
> Fixes: 8b84475318641c2b ("crypto: x86/aria-avx - Do not use avx2 instructions")
> Reported-by: syzbot+a6abcf08bad8b18fd198@syzkaller.appspotmail.com
> Tested-by: syzbot+a6abcf08bad8b18fd198@syzkaller.appspotmail.com
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>  arch/x86/crypto/aria-aesni-avx-asm_64.S | 2 --
>  1 file changed, 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt