Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa90e73483b866a0622ad077f4af16978d1c1c8d.camel@linux.intel.com>
Subject: Re: [PATCH v5 13/15] crypto: iaa - Add support for default IAA
 'canned' compression mode
From:   Tom Zanussi <tom.zanussi@linux.intel.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     davem@davemloft.net, fenghua.yu@intel.com, vkoul@kernel.org,
        dave.jiang@intel.com, tony.luck@intel.com,
        wajdi.k.feghali@intel.com, james.guilford@intel.com,
        kanchana.p.sridhar@intel.com, giovanni.cabiddu@intel.com,
        linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
        dmaengine@vger.kernel.org
Date:   Wed, 24 May 2023 10:58:54 -0500
In-Reply-To: <ZG3dpbPlRXbF2ZxN@gondor.apana.org.au>
References: <20230516215009.51794-1-tom.zanussi@linux.intel.com>
         <20230516215009.51794-14-tom.zanussi@linux.intel.com>
         <ZG3dpbPlRXbF2ZxN@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

Hi Herbert,

On Wed, 2023-05-24 at 17:49 +0800, Herbert Xu wrote:
> On Tue, May 16, 2023 at 04:50:07PM -0500, Tom Zanussi wrote:
> .
> > To choose 'fixed' mode:
> >=20
> > =C2=A0 echo "fixed" >=C2=A0 /sys/bus/dsa/drivers/crypto/compression_mod=
e
> >=20
> > To choose 'canned' mode:
> >=20
> > =C2=A0 echo "canned" >=C2=A0 /sys/bus/dsa/drivers/crypto/compression_mo=
de
>=20
> This seems to be a strange way to switch modes.=C2=A0 How about just
> registering both algorithms and then let the user decide which
> one to use throught the algorithm name?
>=20

Yes, I think you're right.  The reason we did it this way was that
we're expecting to add more modes, such as 'dynamic' and/or 'canned-
dynamic' etc.

But I don't see a reason we couldn't just register them all and have
the user choose using the algorithm names, especially if that's the way
crypto users expect things to work.

Thanks,

Tom=20