Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7b74964a-01b0-4628-772d-bdfaf526f609@linaro.org>
Date:   Fri, 26 May 2023 08:49:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] crypto: Switch i2c drivers back to use .probe()
Content-Language: en-US
To:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>
Cc:     Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        kernel@pengutronix.de
References: <20230525210347.735106-1-u.kleine-koenig@pengutronix.de>
From:   Tudor Ambarus <tudor.ambarus@linaro.org>
In-Reply-To: <20230525210347.735106-1-u.kleine-koenig@pengutronix.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 5/25/23 22:03, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>

> ---
>  drivers/crypto/atmel-ecc.c     | 2 +-
>  drivers/crypto/atmel-sha204a.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
> index aac64b555204..432beabd79e6 100644
> --- a/drivers/crypto/atmel-ecc.c
> +++ b/drivers/crypto/atmel-ecc.c
> @@ -389,7 +389,7 @@ static struct i2c_driver atmel_ecc_driver = {
>  		.name	= "atmel-ecc",
>  		.of_match_table = of_match_ptr(atmel_ecc_dt_ids),
>  	},
> -	.probe_new	= atmel_ecc_probe,
> +	.probe		= atmel_ecc_probe,
>  	.remove		= atmel_ecc_remove,
>  	.id_table	= atmel_ecc_id,
>  };
> diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
> index 44a185a84760..c77f482d2a97 100644
> --- a/drivers/crypto/atmel-sha204a.c
> +++ b/drivers/crypto/atmel-sha204a.c
> @@ -141,7 +141,7 @@ static const struct i2c_device_id atmel_sha204a_id[] = {
>  MODULE_DEVICE_TABLE(i2c, atmel_sha204a_id);
>  
>  static struct i2c_driver atmel_sha204a_driver = {
> -	.probe_new		= atmel_sha204a_probe,
> +	.probe			= atmel_sha204a_probe,
>  	.remove			= atmel_sha204a_remove,
>  	.id_table		= atmel_sha204a_id,
>  
> 
> base-commit: ac9a78681b921877518763ba0e89202254349d1b