Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 27 May 2023 14:20:46 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     David Howells <dhowells@redhat.com>
Cc:     netdev@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        David Ahern <dsahern@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, linux-crypto@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Jeff Layton <jlayton@kernel.org>,
        Steve French <sfrench@samba.org>,
        Shyam Prasad N <nspmangalore@gmail.com>,
        Rohith Surabattula <rohiths.msft@gmail.com>,
        linux-cachefs@redhat.com, linux-cifs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH net-next 1/8] Move netfs_extract_iter_to_sg() to
 lib/scatterlist.c
Message-ID: <ZHH1nqZWOGzxlidT@corigine.com>
References: <20230526143104.882842-1-dhowells@redhat.com>
 <20230526143104.882842-2-dhowells@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230526143104.882842-2-dhowells@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k5f0cerJ30/hXpQz2q12q1QpqrKX/KBfnbgRDORHvUewXNM5RmdqdRQg2Hbn?=
 =?us-ascii?Q?/Ha485msQpZxB/WWJg1gh12VJAPyhLYawBCE7MGwnM3YfUnZBEGpWjVsQuTZ?=
 =?us-ascii?Q?/Qv/sqCQhJleQ+rZvyiw+E/AMfivjIX4vPLB4vLU+qpOuFhF9PwDZn+ox0LH?=
 =?us-ascii?Q?6NcnPUaGJvHCUU7aogUovg09ylYUbTRFJ/RkIn3OsesNRmNZPHHXdnR97kaX?=
 =?us-ascii?Q?lP4y8qnF7B47ekLVIMg7M104tHP1BxcsGP6ZuLrvWmpNIOl1/k4/eI5/vuhy?=
 =?us-ascii?Q?k5bB8P/Iz3c5mq7nTjLD3Sf/9ZLvuwMxZOP/xaqXldiMyzP/06wtSpjoTUy9?=
 =?us-ascii?Q?wf6MwsgnukoQLd6OfnGXqT8iw/qWDzizrY0K6ZeH3VS0HaMDHweQSNpHW6fx?=
 =?us-ascii?Q?YbQ1T9XQeuD3OP1HBiDZtLEGek9USF47aDp1BLSZRgOr5/vnKv/cnPAqzEP8?=
 =?us-ascii?Q?JuRBXXfRw1rhopnLqzo1so83K0L3Or+Zgr1IOzy1Gfb4RhSZxhRWnWTEeRkD?=
 =?us-ascii?Q?s/4mxuf9+7qV8AkdAnSgNVdVVigE7R5iTsz0aMkNd5PVtU37DqkKNd9o9UBa?=
 =?us-ascii?Q?tLcfIST+0HUoQ7CyvT+X4wJdnwyQ0nkB9X3S6QfPgvs3jbX7M4YOokwwr9fs?=
 =?us-ascii?Q?TCzax3IUKUTo7kcP/C+FOfODKEwXvtszG/IkFibK4tHM2hvnDsFQxOC5rrSe?=
 =?us-ascii?Q?39IDbz7ov6DqJVWLLMPHicgBjLsxdUJ6egcLWaZ9aOSbot0c/IMm4d442lcv?=
 =?us-ascii?Q?oe7LxYMBfTsOw0WitkfCVQ/AeqA48aWtesECNhsA21aJw9CRa7PulJGxq6SL?=
 =?us-ascii?Q?+9K9C3PXD6vH3Dd73TY7aSnWeWjZ9S8lf2X2B6nqxOJMOW/uBW5bdn7HuM5K?=
 =?us-ascii?Q?q3AlQuOjYryYHf5zbnnTnXhNh3yOnE0nQU92DY+413DJ8e8F8Nxhb48x81h5?=
 =?us-ascii?Q?4QHBj7ZkPBJmGdVJsWCfrasFPQL99b4RBUm3FuCt4W4ETSvIgSMZF79hGtj4?=
 =?us-ascii?Q?XVMtaocGEdpELsRShp5OQjcBfZVnM7weAfoR8+NnPDpDSMHPu9RP42HeQ/MM?=
 =?us-ascii?Q?6VifeUqkjebcZlbmYbb21M/M+VaYRirfzCNfLkRxrNK1nnPSTisqbLjn+VwD?=
 =?us-ascii?Q?iRdAgaod5RwmvQEAIfKJ8U2q7Bi9TDXj3gsjIBffB3qSM0LGrATisI9vgvLC?=
 =?us-ascii?Q?6eNrUpSrPCR96/+HnX7anSfZrmoSfPAI2dOeor6i9zg2rCnSr3wSTSzSt/7N?=
 =?us-ascii?Q?JtCScNE9vekzVFMMXi/U4GX0F0qBXpZcdoBn5C25J/s/lqfjaxjFSNEPCpRo?=
 =?us-ascii?Q?um2bJB058q+AhvBFqLNezgy63wrLtedw699955M5tEUTy00+xO3TU7Lw977g?=
 =?us-ascii?Q?Ki7wThY9wgxv4IdVb2krplfmVCOTUfBpXsBZtKHokodOkIQ3W+i4G8URoOvf?=
 =?us-ascii?Q?wBR+IqGhEwuXgCW21R/NlYVtsnfd5Zd20V9O4L0N4XnHzy2steFpwykcXqAb?=
 =?us-ascii?Q?0IyGaifUL/BbUuih7yDDcAFpstJmv0Orvb5RVOW3Mssw37xDIsKOaHD6n6j8?=
 =?us-ascii?Q?L2dxNkPprEyqVgXvyeX5I23C7ansEOGT2yxFE1kfBjGtJoKpVWVpD+i/Lt8s?=
 =?us-ascii?Q?o1TWEn99DqNi00m3fmPLMqk8ywhkZCZUV2Jav9E4txLTH7t7wKwUZKROGMPK?=
 =?us-ascii?Q?rOiJvA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a2b2c9e-1703-484f-3077-08db5eacd16c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2023 12:20:54.5261
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qif1qLOblT+2Rt+zeOY2vOcnWyv8g80QjRNKwzZ+GNdgt14Epf0u0eDelBDo8YJxlyg8lzsZyOv9Bb+5JFGuWEN0Wwm8hqdIIIF1MxNTQ3U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR13MB6143
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Fri, May 26, 2023 at 03:30:57PM +0100, David Howells wrote:

...

> +/**
> + * netfs_extract_iter_to_sg - Extract pages from an iterator and add ot an sglist
> + * @iter: The iterator to extract from
> + * @maxsize: The amount of iterator to copy
> + * @sgtable: The scatterlist table to fill in
> + * @sg_max: Maximum number of elements in @sgtable that may be filled
> + * @extraction_flags: Flags to qualify the request
> + *
> + * Extract the page fragments from the given amount of the source iterator and
> + * add them to a scatterlist that refers to all of those bits, to a maximum
> + * addition of @sg_max elements.
> + *
> + * The pages referred to by UBUF- and IOVEC-type iterators are extracted and
> + * pinned; BVEC-, KVEC- and XARRAY-type are extracted but aren't pinned; PIPE-
> + * and DISCARD-type are not supported.
> + *
> + * No end mark is placed on the scatterlist; that's left to the caller.
> + *
> + * @extraction_flags can have ITER_ALLOW_P2PDMA set to request peer-to-peer DMA
> + * be allowed on the pages extracted.
> + *
> + * If successul, @sgtable->nents is updated to include the number of elements

Hi David,

I know you are just moving things about here.
But if you need to re-spin for some other reason,
perhaps you could correct the spelling of successful.

> + * added and the number of bytes added is returned.  @sgtable->orig_nents is
> + * left unaltered.
> + *
> + * The iov_iter_extract_mode() function should be used to query how cleanup
> + * should be performed.
> + */

...