Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <de7e577a-b01f-cf93-7f77-288d2d04b4b1@intel.com>
Date:   Tue, 30 May 2023 13:50:02 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v7 10/12] crypto: x86/aesni - Use the proper data type in
 struct aesni_xts_ctx
To:     Eric Biggers <ebiggers@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
        <dm-devel@redhat.com>, <elliott@hpe.com>, <gmazyland@gmail.com>,
        <luto@kernel.org>, <dave.hansen@linux.intel.com>,
        <tglx@linutronix.de>, <bp@alien8.de>, <mingo@kernel.org>,
        <x86@kernel.org>, <herbert@gondor.apana.org.au>, <ardb@kernel.org>,
        <dan.j.williams@intel.com>, <bernie.keany@intel.com>,
        <charishma1.gairuboyina@intel.com>,
        <lalithambika.krishnakumar@intel.com>, <nhuck@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>
References: <20230410225936.8940-1-chang.seok.bae@intel.com>
 <20230524165717.14062-1-chang.seok.bae@intel.com>
 <20230524165717.14062-11-chang.seok.bae@intel.com>
 <20230526065414.GB875@sol.localdomain>
Content-Language: en-US
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <20230526065414.GB875@sol.localdomain>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUF4U2FSQUYwMzBKbzhvZVFTcUVsK3poUkw3WkU4WlpTeWZESjlhazBzLzJy?=
 =?utf-8?B?Q3RFN0ppWjdmVzVPUGFjY2RQRWZrT2hsdVBoRUgzRlVSRFY0YmJqUWp2L1Rw?=
 =?utf-8?B?Tnl0U1U2MmlPTWQ4aHJtdlVTQnp5TmR5MjQ3WG91YzFVUW1xWkVTUGw3Z1lh?=
 =?utf-8?B?MXh5Wm1mMm5EQlpCSFFsblY3MGlMR0c1NFZKS3pkRFNSVE5IZFJvMUxlNW9s?=
 =?utf-8?B?Y1BFek9QejNuMkIyWXNtcHFXUy92MDlDMTZsZ2JwMzNOVVFYeU9sQlBZd25J?=
 =?utf-8?B?Y2I5SFFYT3YwTXhLR2h5VnQvcUg4RzRWenI1MWFEbkdaTlhyNG1JVDl5ZXNy?=
 =?utf-8?B?Vk94WVBsNWZSNEZUamhoUkJreXRHbUxvRUExNkQzNlBDUlRkZEcxcmZkOVQ4?=
 =?utf-8?B?bnY4cks3ZWFqSnBSWFc2ZWMzNDVMa0JoZW5PNzQ4aUswaWVydUdPV00xQ0NU?=
 =?utf-8?B?QjJBblVqaTU5ZGdxak90ZGgwVy9taWdVc21IY1d2UEZCeVBOL01PckFjc0lJ?=
 =?utf-8?B?SkZnQnZZSXBVNCsxenpieTNOMDVUdld5RDNveitvWDNxRFJxYk4xaFZYR1RU?=
 =?utf-8?B?SXFlcnVhU09PcWwyaU9RUEhiNkF1eUZpRUhKV0pGRytiZzR1RW84cSt4ZGN6?=
 =?utf-8?B?Q1QrS0VpVExWZ2ZpRHorN3BGZko3a01td1o1MmhmYUdmdk5jaVExYTA5a2Ft?=
 =?utf-8?B?TlJhalRyVU9wdGswS3ArblQ5bVVvMW85Y0J5R3NaUkxWdkdYSCt4YXExWWdS?=
 =?utf-8?B?WDNNSUJiMnA0a096WENCbkVMTS85RHlnTXBhd0piLzkxTjlQU0NGR2VFMEhj?=
 =?utf-8?B?RVh4RHNYcjJ2VUVucldndk1BWTNFcW9EUjM4TDRiVmlBbFAwN0o3Tm40UDdn?=
 =?utf-8?B?NVN3VnExNE8zWVE5ZVB5UDdNcW1LZmZsNzhmcXBtbk5qZEtPZ3dFcVV6VGpU?=
 =?utf-8?B?QWpTVXdoUDVNdURTRkplRnlVSlNzVDgxa3p4WkhJdjBGYzNvRzdHeUlHZ2xG?=
 =?utf-8?B?dGZ2SzNDQXpqeHl0bFIxeXFpaVp4eWt5RWN6SGR4SG5GblhuVnpuaDM1a1lC?=
 =?utf-8?B?cTZKTmkwa3c1U0VvWk1YTzRscUNMT25naXd4UG5rNjBjNTdqcW9UYlN4NkdW?=
 =?utf-8?B?ZlpvQjhtZUJ1SC83dmVKRitYemN5aEJWbVBFcHdNRXc1SitUWkRta2JpcVlv?=
 =?utf-8?B?QUpHRGtLOEl4WG1xQUJIeGFXdTB5eUxlUExxT3hhR1gwTXhUNHZYK0c0VElD?=
 =?utf-8?B?QjN0Qm9TTTFXQU5oZ0o0QUxnK1JTUGF0TFFRMGFCSzVIdzR0MS9xdStqUDN1?=
 =?utf-8?B?TTRZbkRKNFJFZFh5ZGZQSUdwSm5QcDNsVDBnbERET0tyc0V3T1ZLblgrUFF6?=
 =?utf-8?B?em56c2Y0aTZOOXNqUGRRUU5tSGdsNGplRWJtbmpKR09DRWhPRm9xbnVGbHlH?=
 =?utf-8?B?M2NmbUtOVVRvckFUOEwvZ1JJSUZqLzQzTHBPZUF3cXlXa3FmUGpZYmtudGhL?=
 =?utf-8?B?WDIwQzFTaWF5S2M0bm9EZ2NSMlQ5T1cxeEt2c0JQZzhHNkdxaWszQUJIL09J?=
 =?utf-8?B?d3hGS0RPblFzcnBTSC95STU5UUt0M0ZtWGN2TDZQanh3Nno3NzJwMlkybE0w?=
 =?utf-8?B?TW1hVWVySEFOdlZtVjlQeFVwd0FuaEJGdnY3QU9WRjIyeEhzT0hVS1IrNTZk?=
 =?utf-8?B?UHJ3bWVtZlRWWHpTdTBlQWJqaUowNlNXVXgrb2U0WEc3dVlkeGV0QnNKck1O?=
 =?utf-8?B?ejJwa0RoZEM0akN1dFM1ZXZ6dVIrOUU2cjlwSngwQVNYa3U0TkZTZVlNdXds?=
 =?utf-8?B?VFNZY25mSmdlR2hmY1dwblE4VkNNUzBrY3pMS0tLWCtSUmRieDdENFB4TW1O?=
 =?utf-8?B?cWFTSE5hbk0wRFFHVVBLdlNoTFFFbU1CT3JIOFNMUjNZdUJJeXh5RzU1WmxS?=
 =?utf-8?B?Tjk0VGNNdk5hKzFMWnNGaWxvcUFqL2lleStnc0o5YnF2YmZwbHlTV0FGV3Fz?=
 =?utf-8?B?NnVmYi9pbHdPOUc3MHpid3F6L0RtR21XdHhoZ3VSMVBtZzFFaGgrbjg0ZElT?=
 =?utf-8?B?RlR1cUppU3Awb0p1UytaN2tvN3lic2ZoOE1ldVdVeVRNVFdGeWc1dU10cHpK?=
 =?utf-8?B?N3ZGcDBDbWdhY3ZsMFp0SkNaNzMxOXphcG5aWjdxSmorVC9QdEMzSEtxMXRG?=
 =?utf-8?B?VlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b3140f6-e2af-4b1f-f6a4-08db614f7199
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 20:50:04.1876
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F3FrHt79uNMtyimBYsZocgP8KUN1cd583fZP/2FIEb9YOgl55F7M4I5GiYhZAUn8tA3KIhXBTbIPlM5tbRY8efN1GJTvCdMS4YNTm3FkXZk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7168
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 5/25/2023 11:54 PM, Eric Biggers wrote:
> On Wed, May 24, 2023 at 09:57:15AM -0700, Chang S. Bae wrote:
>> +static inline unsigned long aes_align_addr(unsigned long addr)
>> +{
>> +	return (crypto_tfm_ctx_alignment() >= AESNI_ALIGN) ?
>> +	       ALIGN(addr, 1) : ALIGN(addr, AESNI_ALIGN);
>> +}
> 
> Wouldn't it be simpler to make this take and return 'void *'?  Then the callers
> wouldn't need to cast to/from 'unsigned long'.
> 
> Also, aligning to a 1-byte boundary is a no-op.
> 
> So, please consider the following:
> 
> static inline void *aes_align_addr(void *addr)
> {
> 	if (crypto_tfm_ctx_alignment() >= AES_ALIGN)
> 		return addr;
> 	return PTR_ALIGN(addr, AES_ALIGN);
> }
> 
> Also, aesni_rfc4106_gcm_ctx_get() and generic_gcmaes_ctx_get() should call this
> too, rather than duplicating similar code.

Indeed, your suggestion can improve the overall code there.

Thanks!
Chang