Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 May 2023 17:32:22 -0500
From:   John Allen <john.allen@amd.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Tom Lendacky <thomas.lendacky@amd.com>,
        "David S . Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH 3/3] crypto: ccp - Add support for PCI device 0x156E
Message-ID: <ZHfK9hsCyrAeRyYz@johallen-workstation>
References: <20230519032414.94247-1-mario.limonciello@amd.com>
 <20230519032414.94247-4-mario.limonciello@amd.com>
 <ZGfLrtmVOcCYiWFW@johallen-workstation>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZGfLrtmVOcCYiWFW@johallen-workstation>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?I06rgvuOnF4ainxqLVKn8wrHixEgXBAaM6f2z+CKgsh7IuGz3/KLjDvfLoI4?=
 =?us-ascii?Q?25TF1KeFDwA9B90K8lhkEOByzfvD72C8iPGkKITkTM/z+M3XFBwzEH5x8FWE?=
 =?us-ascii?Q?HtFR+6gcdt+g3TnxQpIhtG8vUnEW2h4pqpNZU19AYQOwc5SIBgzhtfUMcoTC?=
 =?us-ascii?Q?jZQD9K7OuU1m+JD8ff/bc5zwlMnv00LPEmce+txfWOcL9eiFCsl3oEstb1/d?=
 =?us-ascii?Q?YwMH4JOQVZe0Ej2qPI8fGJVHFJAV+segL842C8X5/NrP0xRmotAVFLTOLByW?=
 =?us-ascii?Q?MBtwiSFaPHezTwnqZYgSwtgbujNfmon6TyTI/8fyaJyj625NEmq+n5aYa5f+?=
 =?us-ascii?Q?p59DiNpRsc4bVukzGGPy9xbSmtk0ZVEfiL+QNIY12z+mIKk21hqotu09mWwt?=
 =?us-ascii?Q?j4Ca7SwguSFwPoNsEJrl6Wug4Q/nXMA2oHv3VlhnUQqEtNQBThKQ77ioZxiV?=
 =?us-ascii?Q?jG1T2Ud0p+SZ+9TRFOvvdi6p3tWOZ5sWcnAoyNpGgjFl7BVI1thyTtbkfH0R?=
 =?us-ascii?Q?AT4wclo/+eeMTebPYfUctZeMwcG6H6T8sPu1xJHeT94WxrFhquFMnnBGW4Ol?=
 =?us-ascii?Q?SFBQ3LG+ieIQxmHMdB9GoB3eWt+dyyCEyTALz699PZz5kuW9UMr9s8+Ec8j5?=
 =?us-ascii?Q?yXxaR1dWdgbNGgpxJvEzJFgftco5BAYlIT3E4zKdXkkQbRgK2199cVC3+Jz4?=
 =?us-ascii?Q?q+sJxiU+NJ9W/lglt0adBaQNjZwJy2ngVaCr8zVG+QjuOsAGA+HqlzKkU4dO?=
 =?us-ascii?Q?kr7jGe5RK0ORYIJ5z+hZD7PDaHK9De2Rq1x4r0tOtGnn0mLrPXVWxK12AUED?=
 =?us-ascii?Q?0br93D/MFrlMhYVlLbYDzaV0DvtY/XGA/bhiqzJwTKQShdjdWWokc5wFQuBe?=
 =?us-ascii?Q?7/stA19nu0oUBCbdqSa3+xCB/n1tDFDC8Myr4pTPG2iH3UtEcO4dp631Tlna?=
 =?us-ascii?Q?nG7vuh47Juir1pamvPCwPmD2Mr493rZSACIKfvz3W/zH0msJC23kjmS/Yoqg?=
 =?us-ascii?Q?eOIKAJEH/cUHQ49P4Ys6olEM6yolh5ELXoybFxK4lFKk+afdscHdCGlpbt//?=
 =?us-ascii?Q?6rR+uKvrrbmvQRmzFIlJlk8vCkrXMVCdeat2CBP0Etut1/K3JmnAJi/hobFS?=
 =?us-ascii?Q?aO8U7XPLfIEHY8U8JGsWHN/uZRlkQ5RoBwIIEuGxcKKUwT04Peon/sVDy55X?=
 =?us-ascii?Q?lGyP+T7B9FGRMQNJQ4I2F5Pio5fFSVoZENQSLdm6FaBFmaGJItMHc8SQji/r?=
 =?us-ascii?Q?iezkcb6BDDW5Qfyv4ZFnWY5/c3aaq8xpTSul644ohz3Qw20PHoBU6/uFdcY/?=
 =?us-ascii?Q?cjNiN5plEyt08Xod0tCQjEx//jQyg/Zn5V9q4RQTUHaf87TYr9yFc6tOvOL8?=
 =?us-ascii?Q?sPqgy0qfLkXBmbviW5j+nT0EL+AVgLOkcfmuxJXHUwmYjwDL/Y/r0wLjHmz9?=
 =?us-ascii?Q?nogryvVChE2Wkvy7v/nh5AUY8Z7XAUZZsKXhfmP6muX0tYP0WD5Eqg7Qd9a4?=
 =?us-ascii?Q?YJxN5hEoXXAl2iizSELVzs10Pjn//FjmdA5hTPSWGxucuHhqcorZstlY1EDs?=
 =?us-ascii?Q?iFKAgC40R6sMzf16woxu31ZEXdhBxxepZQrPGHrZ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b94e8f70-611b-47a7-4683-08db6226e9ff
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5995.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 22:32:27.9550
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +JTqMqY1BqUJP5whdXFaGgkDHINDBGeirqoo7o31XHB03Ljlew9ZkCSLlDTNBuEBudOGFPXzLP6Mm+Jk3DbM0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6759
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Fri, May 19, 2023 at 02:19:10PM -0500, John Allen wrote:
> On Thu, May 18, 2023 at 10:24:14PM -0500, Mario Limonciello wrote:
> > From: John Allen <john.allen@amd.com>
> > 
> > Add a new CCP/PSP PCI device ID and new PSP register offsets.
> > 
> > Signed-off-by: John Allen <john.allen@amd.com>
> 
> Hi Herbert,
> 
> Please hold off on applying this patch for now. I need to do a little
> bit more testing.
> 
> Thanks,
> John

Hi Herbert,

I completed the aforementioned testing. This patch can be applied if
everything else in the series looks good.

Thanks,
John

> 
> > ---
> >  drivers/crypto/ccp/sp-pci.c | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> > index d0d70af0c4c0..b603ad9b8341 100644
> > --- a/drivers/crypto/ccp/sp-pci.c
> > +++ b/drivers/crypto/ccp/sp-pci.c
> > @@ -420,6 +420,14 @@ static const struct psp_vdata pspv5 = {
> >  	.intsts_reg		= 0x10514,	/* P2CMSG_INTSTS */
> >  };
> >  
> > +static const struct psp_vdata pspv6 = {
> > +	.sev                    = &sevv2,
> > +	.tee                    = &teev2,
> > +	.feature_reg            = 0x109fc,	/* C2PMSG_63 */
> > +	.inten_reg              = 0x10510,	/* P2CMSG_INTEN */
> > +	.intsts_reg             = 0x10514,	/* P2CMSG_INTSTS */
> > +};
> > +
> >  #endif
> >  
> >  static const struct sp_dev_vdata dev_vdata[] = {
> > @@ -478,6 +486,12 @@ static const struct sp_dev_vdata dev_vdata[] = {
> >  		.bar = 2,
> >  #ifdef CONFIG_CRYPTO_DEV_SP_PSP
> >  		.psp_vdata = &pspv5,
> > +#endif
> > +	},
> > +	{	/* 8 */
> > +		.bar = 2,
> > +#ifdef CONFIG_CRYPTO_DEV_SP_PSP
> > +		.psp_vdata = &pspv6,
> >  #endif
> >  	},
> >  };
> > @@ -491,6 +505,7 @@ static const struct pci_device_id sp_pci_table[] = {
> >  	{ PCI_VDEVICE(AMD, 0x15C7), (kernel_ulong_t)&dev_vdata[6] },
> >  	{ PCI_VDEVICE(AMD, 0x1649), (kernel_ulong_t)&dev_vdata[6] },
> >  	{ PCI_VDEVICE(AMD, 0x17E0), (kernel_ulong_t)&dev_vdata[7] },
> > +	{ PCI_VDEVICE(AMD, 0x156E), (kernel_ulong_t)&dev_vdata[8] },
> >  	/* Last entry must be zero */
> >  	{ 0, }
> >  };
> > -- 
> > 2.34.1
> >