Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Jun 2023 18:24:56 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Stephan =?iso-8859-1?Q?M=FCller?= <smueller@chronox.de>
Cc:     linux-crypto@vger.kernel.org, Vladis Dronov <vdronov@redhat.com>,
        Marcelo Cerri <marcelo.cerri@canonical.com>,
        Joachim Vandersmissen <git@jvdsn.com>,
        John Cabaj <john.cabaj@canonical.com>
Subject: Re: [PATCH] crypto: jitter - correct health test during
 initialization
Message-ID: <ZHnDeKiJcm82s6ZD@gondor.apana.org.au>
References: <12219330.O9o76ZdvQC@positron.chronox.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <12219330.O9o76ZdvQC@positron.chronox.de>
Precedence: bulk

On Thu, May 25, 2023 at 07:00:05PM +0200, Stephan M?ller wrote:
> With the update of the permanent and intermittent health errors, the
> actual indicator for the health test indicates a potential error only
> for the one offending time stamp gathered in the current iteration
> round. The next iteration round will "overwrite" the health test result.
> 
> Thus, the entropy collection loop in jent_gen_entropy checks for
> the health test failure upon each loop iteration. However, the
> initialization operation checked for the APT health test once for
> an APT window which implies it would not catch most errors.
> 
> Thus, the check for all health errors is now invoked unconditionally
> during each loop iteration for the startup test.
> 
> With the change, the error JENT_ERCT becomes unused as all health
> errors are only reported with the JENT_HEALTH return code. This
> allows the removal of the error indicator.
> 
> Fixes: 3fde2fe99aa6 ("crypto: jitter - permanent and intermittent health errors"
> )
> Reported-by: Joachim Vandersmissen <git@jvdsn.com>
> Signed-off-by: Stephan Mueller <smueller@chronox.de>
> ---
>  crypto/jitterentropy.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt