Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0925dd9e-3588-38da-8dfb-0ac2ff568655@intel.com>
Date:   Sun, 4 Jun 2023 15:02:32 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v8 10/12] crypto: x86/aesni - Use the proper data type in
 struct aesni_xts_ctx
Content-Language: en-US
To:     Eric Biggers <ebiggers@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
        <dm-devel@redhat.com>, <elliott@hpe.com>, <gmazyland@gmail.com>,
        <luto@kernel.org>, <dave.hansen@linux.intel.com>,
        <tglx@linutronix.de>, <bp@alien8.de>, <mingo@kernel.org>,
        <x86@kernel.org>, <herbert@gondor.apana.org.au>, <ardb@kernel.org>,
        <dan.j.williams@intel.com>, <bernie.keany@intel.com>,
        <charishma1.gairuboyina@intel.com>,
        <lalithambika.krishnakumar@intel.com>, <nhuck@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>
References: <20230524165717.14062-1-chang.seok.bae@intel.com>
 <20230603152227.12335-1-chang.seok.bae@intel.com>
 <20230603152227.12335-11-chang.seok.bae@intel.com>
 <20230604153434.GA1212@quark.localdomain>
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <20230604153434.GA1212@quark.localdomain>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGlrQU1seVNLQnIyS3ZXeExUNHhDdXR5ZHB2NHIzQkh0anFhYm8xNVRmWHRa?=
 =?utf-8?B?eGw2TU9RU1BFeDlTanNCdDlEdVRWeWFOMDJEM2F0ekVEU084MFUza0RTUHVJ?=
 =?utf-8?B?MFNFVnpURExON2kvTCtZUEdWc2N4NklNRDN4U0tkNkgrYUE0TlptZG9VanFM?=
 =?utf-8?B?ekpkeWRGYmhncnpQaUV3amNwRzZURm5PTzVwd3U0WkgxZjdZL2tPSno4WkU1?=
 =?utf-8?B?cUJoRDEwUEErSjhZc05UUlhMTVAzcjd2QnNVTTNoanpjZWdpcG5aQ2ovQlBj?=
 =?utf-8?B?WUloYzRXMTRvZm01Qmw1NEVCNmNENTBqb2hyQ2ZMUjdJOC9ydW5TOHBtZWRD?=
 =?utf-8?B?V2xSV2xGRno2R1I3QzdtTkF1dFEvdkFnamJoTmJFYVIyaUlnMEtZQ21KVFZ2?=
 =?utf-8?B?c0FwNGpBRWJqb3c0ZnZMSFR5TkNUbTFGVC85U2FnZTlYdExJbUFGejJoLzJr?=
 =?utf-8?B?V2dqQ0E1dUI1Q3A1VVZWVHVBZ3VMRUZtWDF3aGNLWTRIRS95RGtzTzRUaEoy?=
 =?utf-8?B?Lzd3cWtkSlZYQkU1OUVkb2JsWUtUb09BSFp2enlIUkdHQVB4Z2MwMXpSRXNC?=
 =?utf-8?B?a2hxamFTczVndlJqWFRzMGlwME93VHlxVEZJMzdJbHhNL0UwejJvMC83VHpQ?=
 =?utf-8?B?ZHhKS21SZzBkZC9uZ2tRV0VJU2dEbWZzbityc3lrNmhaZ2pOR2s4NlFVeEpM?=
 =?utf-8?B?eEV2azZaaEM3U3hVRzlYL0hpc1R5bElxRkdua2xjVzNzWnN5cktsd203THhm?=
 =?utf-8?B?N1JXUUpoQVRMWndNNXdUME1lOUlYVVg1aWNlbitMdjE0WDdMZzZ1Ry9mY2p6?=
 =?utf-8?B?YWV4Q0Fpd2cvSWVtVElISHRId1QrNGhaZWxjZWRBbGl1VTdoaS8ycUgrWGlh?=
 =?utf-8?B?ai9xWVJhZVN5UTRGd0NtbjdUN0p5YnJIbGMvVFh3bWFQK1l1OWQ2OURacjBX?=
 =?utf-8?B?cmdJT0xQaWN5b09kVFJJNWZNVCtGYWZQOGJEZXp5WHVSNGZBTjFqejFKVXdD?=
 =?utf-8?B?V2xpV0Q1T2JaejMyd2xaUFVsaXBFYVByRWZrVE9OSUpPNTNhRi9HL3BrUnlN?=
 =?utf-8?B?QzNLenMvSHcwWTA3YzUyNFFraFVNdlNEa3NMRTVYYUZsZlVHQkFsQ3FETHhi?=
 =?utf-8?B?TUxkcGk5ZVB1QmRybHJ1YTlZdmdleno5V0dxOGp3N0d6M2ZiK1N1T2gybEpP?=
 =?utf-8?B?RHZzNWhobXdhUVZTKysreDkyS3lqcjc5Y25PNCtra0hSSUxITGhDbHFPZnU5?=
 =?utf-8?B?WEY1WEdJb01zbUhlUmJFM2xWbU11bEgrYkF1YjUrVDdTdDJ5bDdoZ0d0T2VN?=
 =?utf-8?B?TkFkVmFkbFc3alRFNUJldWlRLzBIelpzczhGR1lwWGRNMUpPUW5NOW82RUdV?=
 =?utf-8?B?bTNpbHJCWktuRDF3NGFhZk9WRFJwdUxxeWhqUUZkY2xFT3UyNTNGMWdjempw?=
 =?utf-8?B?RkRaVjZQYzNtVTg5TS9kTURROXYySGxqd012L3FKWmExWTFNZUhZb1BFODBZ?=
 =?utf-8?B?UWJtYXhFVndGYWdpL011cS96ZGdNK3cvY29ISXZyQVBvSlZ3MmZ3anQ5M2ZS?=
 =?utf-8?B?bWFOQnhTKzNwYlFaZURkNmRINWVxai9EbmEzd1NqelV6V2diM3FhNmtCd2M0?=
 =?utf-8?B?WEw3ZDVVRlRvRVJWSm8wODBlQ3RaZTk3ejRrWlVTWFJWQmwxbTRlYk9EOUxu?=
 =?utf-8?B?Y3JQY21zU21lKzNTL0xHUGk1M1Q3UVhtY1oxWGRVK3N5WUwyN2M3RUF5bENq?=
 =?utf-8?B?REVlcHFPekJkZGVNc1FiVlZoTGNrWUthVVFkMjZhcFZORjl4bFJBZjNzcjVC?=
 =?utf-8?B?TmQ0N2xWaFVCRWJQcUtoWGJOcnNSSWp2cVRncmJaTmJhMC9kUXFKUXRIek5y?=
 =?utf-8?B?WXFZTnY1Y0JoTWs4VCtnUVc1ZzU3Q1BNMStBdmFNRkNzeitYVmxwY2ptV0g4?=
 =?utf-8?B?TlJSaFZwR3pKQ0J0MmZDMEZjckZ1RWdqdXRTZGtFQUZKd2lxQnc2bWJIWlB1?=
 =?utf-8?B?dnQ5RVhhcmFBUkEwZ3dta05rMDZuM0w3d3pabVBOeGVjSTZkZTVGOVJuR284?=
 =?utf-8?B?ZXFFcVpBeWR2emN3anE1dFpMTUlUQ08zQk45K2RBNDhYOWR1ZFdvbnErQnpX?=
 =?utf-8?B?b3ZNZ21JVS9VcGRMSlJPdUpzTThyK0hsbmpmMTh6QmRMdmloQ2xnL0RVc05T?=
 =?utf-8?B?VWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bd29dd8b-c05f-43bb-6783-08db654767e7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2023 22:02:36.6341
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fo+B/aRvxooAKI0Qt8PsLojdE6az4x2y7xRWsWS271kO7F1Fgc9hVxZT4OhIjQzHW7EzRIyFMrrqgr12zaswZCZivCeDqzoiAdejJu5tQoY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6485
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 6/4/2023 8:34 AM, Eric Biggers wrote:
> 
> To re-iterate what I said on v6, the runtime alignment to a 16-byte boundary
> should happen when translating the raw crypto_skcipher_ctx() into the pointer to
> the aes_xts_ctx.  It should not happen when accessing each individual field in
> the aes_xts_ctx.
> 
> Yet, this code is still doing runtime alignment when accessing each individual
> field, as the second argument to aes_set_key_common() is 'void *raw_ctx' which
> aes_set_key_common() runtime-aligns to crypto_aes_ctx.
> 
> We should keep everything consistent, which means making aes_set_key_common()
> take a pointer to crypto_aes_ctx and not do the runtime alignment.

Let me clarify what is the problem this patch tried to solve here. The 
current struct aesni_xts_ctx is ugly. So, the main story is let's fix it 
before using the code for AES-KL.

Then, the rework part may be applicable for code re-usability. That 
seems to be okay to do here.

Fixing the runtime alignment entirely seems to be touching other code 
than AES-XTS. Yes, that's ideal cleanup for consistency. But, it seems 
to be less relevant in this series.  I'd be happy to follow up on that 
improvement though.

Thanks,
Chang