Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 12:14:08 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc:     linux-crypto@vger.kernel.org, qat-linux@intel.com,
        damian.muszynski@intel.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] crypto: qat - add missing function declaration in
 adf_dbgfs.h
Message-ID: <ZH6ykJEQo/vWAyPg@gondor.apana.org.au>
References: <20230603082853.44631-1-giovanni.cabiddu@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230603082853.44631-1-giovanni.cabiddu@intel.com>
Precedence: bulk

On Sat, Jun 03, 2023 at 09:28:53AM +0100, Giovanni Cabiddu wrote:
> The function adf_dbgfs_exit() was improperly named causing the build to
> fail when CONFIG_DEBUG_FS=n.
> 
> Rename adf_dbgfs_cleanup() as adf_dbgfs_exit().
> 
> This fixes the following build error:
>       CC [M]  drivers/crypto/intel/qat/qat_c62x/adf_drv.o
>     drivers/crypto/intel/qat/qat_c62x/adf_drv.c: In function ‘adf_cleanup_accel’:
>     drivers/crypto/intel/qat/qat_c62x/adf_drv.c:69:9: error: implicit declaration of function ‘adf_dbgfs_exit’; did you mean ‘adf_dbgfs_init’? [-Werror=implicit-function-declaration]
>        69 |         adf_dbgfs_exit(accel_dev);
>           |         ^~~~~~~~~~~~~~
>           |         adf_dbgfs_init
>     cc1: all warnings being treated as errors
>     make[2]: *** [scripts/Makefile.build:252: drivers/crypto/intel/qat/qat_c62x/adf_drv.o] Error 1
>     make[1]: *** [scripts/Makefile.build:494: drivers/crypto/intel/qat/qat_c62x] Error 2
>     make: *** [Makefile:2026: drivers/crypto/intel/qat] Error 2
> 
> Fixes: 9260db6640a6 ("crypto: qat - move dbgfs init to separate file")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202306030654.5t4qkyN1-lkp@intel.com/
> Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
>  drivers/crypto/intel/qat/qat_common/adf_dbgfs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt