Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 16:21:51 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Franziska Naepelt <franziska.naepelt@googlemail.com>
Cc:     linux-crypto@vger.kernel.org, davem@davemloft.net,
        linux-kernel@vger.kernel.org,
        Franziska Naepelt <franziska.naepelt@gmail.com>
Subject: Re: [PATCH] crypto: Fix checkpatch issues
Message-ID: <ZH7sn7i2t+5IrXXK@gondor.apana.org.au>
References: <20230603142453.92582-1-franziska.naepelt@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230603142453.92582-1-franziska.naepelt@gmail.com>
Precedence: bulk

On Sat, Jun 03, 2023 at 04:24:53PM +0200, Franziska Naepelt wrote:
> crypto/crct10dif_common.c
> - WARNING: Missing or malformed SPDX-License-Identifier tag
> 
> crypto/fcrypt.c
> - WARNING: Missing or malformed SPDX-License-Identifier tag
> - WARNING: Block comments use a trailing */ on a separate line
> 
> crypto/hmac.c
> - WARNING: Missing a blank line after declarations
> 
> crypto/md4.c
> - WARNING: Missing or malformed SPDX-License-Identifier tag
> - ERROR: space required after that ',' (ctx:VxV)
> - ERROR: space prohibited after that open square bracket '['
> - WARNING: space prohibited between function name and open parenthesis '('
> - ERROR: code indent should use tabs where possible
> 
> not fixed:
> crypto/md4.c
> - ERROR: space required after that ',' (ctx:VxV)
>    Lines 64, 65, 66 have not been fixed due to readability
> 
> Signed-off-by: Franziska Naepelt <franziska.naepelt@gmail.com>
> ---
>  crypto/crct10dif_common.c |  1 +
>  crypto/fcrypt.c           |  4 +++-
>  crypto/hmac.c             |  1 +
>  crypto/md4.c              | 11 ++++++-----
>  4 files changed, 11 insertions(+), 6 deletions(-)

Please split these up into individual patches.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt