Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <649f4d8d5e96b3c8e39ab56487888fe86e543066.camel@redhat.com>
Subject: Re: [PATCH net-next v2 08/10] crypto: af_alg: Support
 MSG_SPLICE_PAGES
From:   Paolo Abeni <pabeni@redhat.com>
To:     David Howells <dhowells@redhat.com>,
        Herbert Xu <herbert@gondor.apana.org.au>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        David Ahern <dsahern@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, linux-crypto@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Date:   Tue, 06 Jun 2023 10:32:08 +0200
In-Reply-To: <822308.1685619312@warthog.procyon.org.uk>
References: <bd2750e52b47af1782233e254114eb8d627f1073.camel@redhat.com>
         <20230530141635.136968-1-dhowells@redhat.com>
         <20230530141635.136968-9-dhowells@redhat.com>
         <822308.1685619312@warthog.procyon.org.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-06-01 at 12:35 +0100, David Howells wrote:
> Paolo Abeni <pabeni@redhat.com> wrote:
>=20
> > > +	if ((msg->msg_flags & MSG_SPLICE_PAGES) &&
> > > +	    !iov_iter_is_bvec(&msg->msg_iter))
> > > +		return -EINVAL;
> > > +
> > ...
> > It looks like the above expect/supports only ITER_BVEC iterators, what
> > about adding a WARN_ON_ONCE(<other iov type>)?
>=20
> Meh.  I relaxed that requirement as I'm now using tools to extract stuff =
from
> any iterator (extract_iter_to_sg() in this case) rather than walking the
> bvec[] directly.  I forgot to remove the check from af_alg.  I can add an
> extra patch to remove it.  Also, it probably doesn't matter for AF_ALG si=
nce
> that's only likely to be called from userspace, either directly (which wi=
ll
> not set MSG_SPLICE_PAGES) or via splice (which will pass a BVEC).  Intern=
al
> kernel code will use crypto API directly.

Thank you for the clarification, I got lost a bit. The patch LGTM as
is.

>=20
> > Also, I'm keeping this series a bit more in pw to allow Herbert or
> > others to have a look.

@Herbert, the series LGTM, I think we should apply it. If you have any
concerns, please voice them soon!

Thanks,

Paolo