Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230603142453.92582-1-franziska.naepelt@gmail.com> <ZH7sn7i2t+5IrXXK@gondor.apana.org.au>
In-Reply-To: <ZH7sn7i2t+5IrXXK@gondor.apana.org.au>
From:   =?UTF-8?Q?Franziska_N=C3=A4pelt?= 
        <franziska.naepelt@googlemail.com>
Date:   Tue, 6 Jun 2023 13:30:19 +0200
Message-ID: <CAAUT3iMD=K4GStMVG5YrenBJdDW08biu+jBJ9cPmz_un99o-Ug@mail.gmail.com>
Subject: Re: [PATCH] crypto: Fix checkpatch issues
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-crypto@vger.kernel.org, davem@davemloft.net,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Am Di., 6. Juni 2023 um 10:21 Uhr schrieb Herbert Xu
<herbert@gondor.apana.org.au>:
>
> On Sat, Jun 03, 2023 at 04:24:53PM +0200, Franziska Naepelt wrote:
> > crypto/crct10dif_common.c
> > - WARNING: Missing or malformed SPDX-License-Identifier tag
> >
> > crypto/fcrypt.c
> > - WARNING: Missing or malformed SPDX-License-Identifier tag
> > - WARNING: Block comments use a trailing */ on a separate line
> >
> > crypto/hmac.c
> > - WARNING: Missing a blank line after declarations
> >
> > crypto/md4.c
> > - WARNING: Missing or malformed SPDX-License-Identifier tag
> > - ERROR: space required after that ',' (ctx:VxV)
> > - ERROR: space prohibited after that open square bracket '['
> > - WARNING: space prohibited between function name and open parenthesis '('
> > - ERROR: code indent should use tabs where possible
> >
> > not fixed:
> > crypto/md4.c
> > - ERROR: space required after that ',' (ctx:VxV)
> >    Lines 64, 65, 66 have not been fixed due to readability
> >
> > Signed-off-by: Franziska Naepelt <franziska.naepelt@gmail.com>
> > ---
> >  crypto/crct10dif_common.c |  1 +
> >  crypto/fcrypt.c           |  4 +++-
> >  crypto/hmac.c             |  1 +
> >  crypto/md4.c              | 11 ++++++-----
> >  4 files changed, 11 insertions(+), 6 deletions(-)
>
> Please split these up into individual patches.
>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Done. Please find the individual patches here:

https://lore.kernel.org/lkml/20230606110322.96290-1-franziska.naepelt@gmail.com/
https://lore.kernel.org/lkml/20230606111042.96855-1-franziska.naepelt@gmail.com/
https://lore.kernel.org/lkml/20230606111749.97469-1-franziska.naepelt@gmail.com/
https://lore.kernel.org/lkml/20230606112610.98149-1-franziska.naepelt@gmail.com/

Thanks,
Franziska