Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 19:14:51 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Franziska Naepelt <franziska.naepelt@googlemail.com>,
        linux-crypto@vger.kernel.org
Cc:     herbert@gondor.apana.org.au, davem@davemloft.net,
        linux-kernel@vger.kernel.org,
        Franziska Naepelt <franziska.naepelt@gmail.com>,
        Linux SPDX Licenses <linux-spdx@vger.kernel.org>,
        James Morris <jmorris@intercode.com.au>,
        Steve French <sfrench@samba.org>
Subject: Re: [PATCH] crypto: md4: Fix checkpatch issues
Message-ID: <ZH8jO0FO2QJ7eGBV@debian.me>
References: <20230606112610.98149-1-franziska.naepelt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ba/Z41R8rl9t+wTp"
Content-Disposition: inline
In-Reply-To: <20230606112610.98149-1-franziska.naepelt@gmail.com>
Precedence: bulk


--ba/Z41R8rl9t+wTp
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 06, 2023 at 01:26:10PM +0200, Franziska Naepelt wrote:
> The following checkpatch issues have been fixed:
> - WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> - ERROR: space required after that ',' (ctx:VxV)
> - ERROR: space prohibited after that open square bracket '['
> - WARNING: space prohibited between function name and open parenthesis '('
> - ERROR: code indent should use tabs where possible

Again, please split up into one patch per fixes, as a patch series.

>=20
> not fixed:
> - ERROR: space required after that ',' (ctx:VxV)
> in lines: 64, 65, 66 have not ben fixed due to readability

Can you clearly explain why do you skip #define ROUNDx macros?

> -/*=20
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
>   * Cryptographic API.
>   *
>   * MD4 Message Digest Algorithm (RFC1320).

What about removing the license boilerplate text below (and thus convert
to SPDX)? Personally, I prefer having a SPDX conversion series for crypto/
directory instead.

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--ba/Z41R8rl9t+wTp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZH8jOAAKCRD2uYlJVVFO
o00BAP9UG2AFI4DVm8DvY97Ml59CFiyeX1FPrNTc5SOzYbrMqAEAqS0rkoBnJn6o
NtT32bb8/U3dleJsqZ01PleqrLephwk=
=lzaw
-----END PGP SIGNATURE-----

--ba/Z41R8rl9t+wTp--